You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/08 13:25:16 UTC

[GitHub] [hudi] nsivabalan opened a new pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

nsivabalan opened a new pull request #3768:
URL: https://github.com/apache/hudi/pull/3768


   ## What is the purpose of the pull request
   
   After removing glob pattern requirement in base path while loading hudi, fs.globStatus(basePath) also returns ".hoodie" meta paths. When metadata is enabled, we may not want those files to be returned. Hence, removing all meta paths from the globPattern look up. 
   
   ## Brief change log
   - Fixed HoodieSparkSqlUtils.globPath() to skip all meta paths. 
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:
   
     - Fixed tests in TestHoodieSparkUtils to verify the fix.
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3768:
URL: https://github.com/apache/hudi/pull/3768#issuecomment-938643768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d08cac085906b121ab6e72e822add6d38a3c6034",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2548",
       "triggerID" : "d08cac085906b121ab6e72e822add6d38a3c6034",
       "triggerType" : "PUSH"
     }, {
       "hash" : "87885b79753568ed685fa0d29d44cdcb7fe06d69",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "87885b79753568ed685fa0d29d44cdcb7fe06d69",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d08cac085906b121ab6e72e822add6d38a3c6034 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2548) 
   * 87885b79753568ed685fa0d29d44cdcb7fe06d69 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] garyli1019 commented on a change in pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #3768:
URL: https://github.com/apache/hudi/pull/3768#discussion_r726711740



##########
File path: hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSparkUtils.scala
##########
@@ -64,8 +64,24 @@ object HoodieSparkUtils extends SparkAdapterSupport {
    * [[org.apache.spark.deploy.SparkHadoopUtil]] becomes private since Spark 3.0.0 and hence we had to copy it locally.
    */
   def globPath(fs: FileSystem, pattern: Path): Seq[Path] = {
-    Option(fs.globStatus(pattern)).map { statuses =>
-      statuses.map(_.getPath.makeQualified(fs.getUri, fs.getWorkingDirectory)).toSeq
+    // find base path to assist in skipping meta paths

Review comment:
       ok sure, not a big deal. Maybe we can remove the comment of this method above then.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3768:
URL: https://github.com/apache/hudi/pull/3768#issuecomment-938643768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d08cac085906b121ab6e72e822add6d38a3c6034",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2548",
       "triggerID" : "d08cac085906b121ab6e72e822add6d38a3c6034",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d08cac085906b121ab6e72e822add6d38a3c6034 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2548) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3768:
URL: https://github.com/apache/hudi/pull/3768#issuecomment-938643768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d08cac085906b121ab6e72e822add6d38a3c6034",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d08cac085906b121ab6e72e822add6d38a3c6034",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d08cac085906b121ab6e72e822add6d38a3c6034 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3768:
URL: https://github.com/apache/hudi/pull/3768#issuecomment-938643768






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3768:
URL: https://github.com/apache/hudi/pull/3768#issuecomment-938643768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d08cac085906b121ab6e72e822add6d38a3c6034",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2548",
       "triggerID" : "d08cac085906b121ab6e72e822add6d38a3c6034",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d08cac085906b121ab6e72e822add6d38a3c6034 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2548) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on a change in pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3768:
URL: https://github.com/apache/hudi/pull/3768#discussion_r726622650



##########
File path: hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSparkUtils.scala
##########
@@ -64,8 +64,24 @@ object HoodieSparkUtils extends SparkAdapterSupport {
    * [[org.apache.spark.deploy.SparkHadoopUtil]] becomes private since Spark 3.0.0 and hence we had to copy it locally.
    */
   def globPath(fs: FileSystem, pattern: Path): Seq[Path] = {
-    Option(fs.globStatus(pattern)).map { statuses =>
-      statuses.map(_.getPath.makeQualified(fs.getUri, fs.getWorkingDirectory)).toSeq
+    // find base path to assist in skipping meta paths

Review comment:
       not sure if it is required. I did not see a reason why do we need to include meta paths in any of our flows. thats why left it as is. Let me know if there is a need for one. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan merged pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3768:
URL: https://github.com/apache/hudi/pull/3768


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] garyli1019 commented on a change in pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #3768:
URL: https://github.com/apache/hudi/pull/3768#discussion_r725753489



##########
File path: hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSparkUtils.scala
##########
@@ -64,8 +64,24 @@ object HoodieSparkUtils extends SparkAdapterSupport {
    * [[org.apache.spark.deploy.SparkHadoopUtil]] becomes private since Spark 3.0.0 and hence we had to copy it locally.
    */
   def globPath(fs: FileSystem, pattern: Path): Seq[Path] = {
-    Option(fs.globStatus(pattern)).map { statuses =>
-      statuses.map(_.getPath.makeQualified(fs.getUri, fs.getWorkingDirectory)).toSeq
+    // find base path to assist in skipping meta paths

Review comment:
       This method seems copied from Spark. IMO we could change the name to `globPathWithoutMeta` or have a separate method to `filterMeta()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3768:
URL: https://github.com/apache/hudi/pull/3768#issuecomment-938643768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d08cac085906b121ab6e72e822add6d38a3c6034",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2548",
       "triggerID" : "d08cac085906b121ab6e72e822add6d38a3c6034",
       "triggerType" : "PUSH"
     }, {
       "hash" : "87885b79753568ed685fa0d29d44cdcb7fe06d69",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2599",
       "triggerID" : "87885b79753568ed685fa0d29d44cdcb7fe06d69",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 87885b79753568ed685fa0d29d44cdcb7fe06d69 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2599) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan merged pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3768:
URL: https://github.com/apache/hudi/pull/3768


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3768: [HUDI-2494] Fixing glob pattern to skip all hoodie meta paths

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3768:
URL: https://github.com/apache/hudi/pull/3768#issuecomment-938643768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d08cac085906b121ab6e72e822add6d38a3c6034",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2548",
       "triggerID" : "d08cac085906b121ab6e72e822add6d38a3c6034",
       "triggerType" : "PUSH"
     }, {
       "hash" : "87885b79753568ed685fa0d29d44cdcb7fe06d69",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2599",
       "triggerID" : "87885b79753568ed685fa0d29d44cdcb7fe06d69",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d08cac085906b121ab6e72e822add6d38a3c6034 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2548) 
   * 87885b79753568ed685fa0d29d44cdcb7fe06d69 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2599) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org