You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/14 08:38:00 UTC
[GitHub] [flink] zentol opened a new pull request #13630: [FLINK-19637][coordination][tests] Remove AllocationIdsExposingRMGateway
zentol opened a new pull request #13630:
URL: https://github.com/apache/flink/pull/13630
The AllocationIdsExposingResourceManagerGateway is a utility for capturing the allocation IDs that are issued by the JobMaster. These are used by 2 tests to construct a matching slot offer that is sent from the TaskExecutor to the JobMaster.
However, it is not required that these IDs are matching at the moment, because the slot pool will accept the slots anyway because no connection was established to the ResourceManager.
Furthermore, with declarative resource management the AllocationID is no longer generated by the JobMaster, so we can use any AllocationID we like.
As such we can remove this utility because it is simply unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13630: [FLINK-19637][coordination][tests] Remove AllocationIdsExposingRMGateway
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13630:
URL: https://github.com/apache/flink/pull/13630#issuecomment-708252915
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 68fd067cb4cc7185000a60b63d7bd37ae45e0818 (Wed Oct 14 08:39:39 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13630: [FLINK-19637][coordination][tests] Remove AllocationIdsExposingRMGateway
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13630:
URL: https://github.com/apache/flink/pull/13630#issuecomment-708277823
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225e04e7dd2148ab679454f5d00fe67a4838056",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c225e04e7dd2148ab679454f5d00fe67a4838056",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c225e04e7dd2148ab679454f5d00fe67a4838056 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13630: [FLINK-19637][coordination][tests] Remove AllocationIdsExposingRMGateway
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13630:
URL: https://github.com/apache/flink/pull/13630#issuecomment-708277823
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225e04e7dd2148ab679454f5d00fe67a4838056",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7593",
"triggerID" : "c225e04e7dd2148ab679454f5d00fe67a4838056",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c225e04e7dd2148ab679454f5d00fe67a4838056 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7593)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13630: [FLINK-19637][coordination][tests] Remove AllocationIdsExposingRMGateway
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13630:
URL: https://github.com/apache/flink/pull/13630#issuecomment-708277823
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225e04e7dd2148ab679454f5d00fe67a4838056",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7593",
"triggerID" : "c225e04e7dd2148ab679454f5d00fe67a4838056",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c225e04e7dd2148ab679454f5d00fe67a4838056 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7593)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #13630: [FLINK-19637][coordination][tests] Remove AllocationIdsExposingRMGateway
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #13630:
URL: https://github.com/apache/flink/pull/13630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org