[GitHub] [phoenix] richardantal commented on a change in pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…

[GitBox <gi...@apache.org>]

richardantal commented on a change in pull request #953:
URL: https://github.com/apache/phoenix/pull/953#discussion_r516604261



##########
File path: phoenix-core/src/test/java/org/apache/phoenix/schema/MetaDataClientTest.java
##########
@@ -83,4 +85,13 @@ public void testHandleCreateTableMutationCodeWithNewCode() throws SQLException {
         }
     }
 
+    @Test
+    public void testMetaDataProtocolVersion() {
+        long serversTimstamp = System.currentTimeMillis();
+        String version = MetaDataProtocol.getVersion(serversTimstamp);
+        assertEquals("4.16.x", version);  // We have to update it after every release
+        assertEquals(String.format("%d.%d.%s", PHOENIX_MAJOR_VERSION, PHOENIX_MINOR_VERSION, "x"),

Review comment:
       Yeah, that is right!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org