You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/08 09:31:40 UTC

[GitHub] [airflow] ashb opened a new pull request, #26228: Prepare to release 2.4.0beta1

ashb opened a new pull request, #26228:
URL: https://github.com/apache/airflow/pull/26228

   As I like to have the branch point for a relase as "late" as possible,
   I'm committing the version change to main, and then branching off.
   
   The release notes/changelog are _far_ from complete, but lets take what
   newsfragments we have


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240521429

   > My "fix" was to just remove the `--version-suffix-for-pypi` from the build images workflow -- we dont' need it there do we?
   
   We need that at least to indicate in the production imaage that the version  is not the "released" one. It might be confusing for someone who looks at the image for testing for example so I prefer to override it to dev0 always.
   
   It's more needed for providers - becasue they will fail to generate documentation (this is a protection agains accidentally trying to release the same version again - so for providers adding suffix on CI serves also this role, but I think keeping dev0 always when it is not specified for the regular CI builds is a good thing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240492446

   ```
   CONTRIBUTORS_QUICK_START.rst:   Airflow source version: 2.4.0.dev0
   docs/docker-stack/README.md:You can find the following images there (Assuming Airflow version `2.4.0.dev0`):
   docs/docker-stack/README.md:* `apache/airflow:2.4.0.dev0` - the versioned Airflow image with default Python version (3.7 currently)
   docs/docker-stack/README.md:* `apache/airflow:2.4.0.dev0-pythonX.Y` - the versioned Airflow image with specific Python version
   docs/docker-stack/README.md:* `apache/airflow:slim-2.4.0.dev0`           - the versioned Airflow image with default Python version (3.7 currently)
   docs/docker-stack/README.md:* `apache/airflow:slim-2.4.0.dev0-pythonX.Y` - the versioned Airflow image with specific Python version
   docs/docker-stack/docker-examples/extending/add-apt-packages/Dockerfile:FROM apache/airflow:2.4.0.dev0
   docs/docker-stack/docker-examples/extending/add-build-essential-extend/Dockerfile:FROM apache/airflow:2.4.0.dev0
   docs/docker-stack/docker-examples/extending/add-providers/Dockerfile:FROM apache/airflow:2.4.0.dev0
   docs/docker-stack/docker-examples/extending/add-pypi-packages/Dockerfile:FROM apache/airflow:2.4.0.dev0
   docs/docker-stack/docker-examples/extending/custom-providers/Dockerfile:FROM apache/airflow:2.4.0.dev0
   docs/docker-stack/docker-examples/extending/embedding-dags/Dockerfile:FROM apache/airflow:2.4.0.dev0
   docs/docker-stack/docker-examples/extending/writable-directory/Dockerfile:FROM apache/airflow:2.4.0.dev0
   docs/docker-stack/entrypoint.rst:  docker run -it apache/airflow:2.4.0.dev0-python3.6 bash -c "ls -la"
   docs/docker-stack/entrypoint.rst:  > docker run -it apache/airflow:2.4.0.dev0-python3.6 python -c "print('test')"
   docs/docker-stack/entrypoint.rst:   docker run -it apache/airflow:2.4.0.dev0-python3.6 airflow webserver
   docs/docker-stack/entrypoint.rst:  > docker run -it apache/airflow:2.4.0.dev0-python3.6 help
   docs/docker-stack/entrypoint.rst:    FROM airflow:2.4.0.dev0
   docs/docker-stack/entrypoint.rst:    FROM airflow:2.4.0.dev0
   docs/docker-stack/entrypoint.rst:      apache/airflow:2.4.0.dev0-python3.8 webserver
   docs/docker-stack/entrypoint.rst:      apache/airflow:2.4.0.dev0-python3.8 webserver
   docs/docker-stack/entrypoint.rst:      apache/airflow:2.4.0.dev0-python3.8 webserver
   setup.py:version = '2.4.0.dev0'
   ```
   
   I think those can stay until 2.4.0 is released GA?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on a diff in pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #26228:
URL: https://github.com/apache/airflow/pull/26228#discussion_r965804743


##########
tests/www/views/test_views_base.py:
##########
@@ -35,16 +34,14 @@ def test_index(admin_client):
     check_content_in_response('DAGs', resp)
 
 
-def test_doc_urls(admin_client):
+def test_doc_urls(admin_client, monkeypatch):
+    # Mocking this way is tying the test closer to the implementation much more than I'd like. :shrug:
+    from airflow.www.views import AirflowBaseView
+
+    monkeypatch.setitem(AirflowBaseView.extra_args, 'get_docs_url', lambda _: "!!DOCS_URL!!")
     resp = admin_client.get('/', follow_redirects=True)
-    if "dev" in version.version:

Review Comment:
   I did this, as otherwise we are just re-implementing the get_docs_url logic here in the test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240643611

   Right once static and docs build pass on this one (which is all the errors I had last time) I'll merge this and cut the beta.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240640765

   > Looks like CI wants us to update the versions anyway, cool I'll do that then.
   
   Yeah. Those are independent from `--suffix` the suffix is only for package preparation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240666239

   What a "favour" to release manager :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on a diff in pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26228:
URL: https://github.com/apache/airflow/pull/26228#discussion_r965751778


##########
RELEASE_NOTES.rst:
##########
@@ -21,6 +21,127 @@
 
 .. towncrier release notes start
 
+Airflow 2.4.0beta1 (2022-09-08)
+-------------------------------
+
+Significant Changes
+^^^^^^^^^^^^^^^^^^^
+
+- The DB related classes: ``DBApiHook``, ``SQLSensor`` have been moved to ``apache-airflow-providers-common-sql`` provider. (NEW)
+- DAGS used in a context manager no longer need to be assigned to a module variable
+
+  Previously you had do assign a DAG to a module-level variable in order for Airflow to pick it up. For example this
+
+  .. code-block:: python
+
+     with DAG(dag_id="example") as dag:
+         ...
+
+
+     @dag
+     def dag_maker():
+         ...
+
+
+     dag2 = dag_maker()
+
+
+  can become
+
+  .. code-block:: python
+
+     with DAG(dag_id="example"):
+         ...
+
+
+     @dag
+     def dag_maker():
+         ...
+
+
+     dag_maker()
+
+  If you want to disable the behaviour for any reason then set ``auto_register=False`` on the dag::
+
+  .. code-block::
+
+     # This dag will not be picked up by Airflow as it's not assigned to a variable
+     with DAG(dag_id="example", auto_register=False):
+        ...
+  (#23592)
+- DAG runs sorting logic changed in grid view
+
+  The ordering of DAG runs in the grid view has been changed to be more "natural".
+  The new logic generally orders by data interval, but a custom ordering can be
+  applied by setting the DAG to use a custom timetable. (#25090)
+- Deprecation of ``schedule_interval`` and ``timetable`` arguments
+
+  We added new DAG argument ``schedule`` that can accept a cron expression, timedelta object, *timetable* object, or list of dataset objects. Arguments ``schedule_interval`` and ``timetable`` are deprecated.
+
+  If you previously used the ``@daily`` cron preset, your DAG may have looked like this:
+
+  .. code-block:: python
+      with DAG(
+          dag_id='my_example',
+          start_date=datetime(2021, 1, 1),
+          schedule_interval='@daily',
+      ):
+          ...
+
+  Going forward, you should use the ``schedule`` argument instead:
+
+  .. code-block:: python
+      with DAG(
+          dag_id='my_example',
+          start_date=datetime(2021, 1, 1),
+          schedule='@daily',
+      ):
+          ...
+
+  The same is true if you used a custom timetable.  Previously you would have used the ``timetable`` argument:
+
+  .. code-block:: python
+      with DAG(
+          dag_id='my_example',
+          start_date=datetime(2021, 1, 1),
+          timetable=EventsTimetable(event_dates=[pendulum.datetime(2022, 4, 5)]),
+      ):
+          ...
+
+  Now you should use the ``schedule`` argument:
+
+  .. code-block:: python
+      with DAG(
+          dag_id='my_example',
+          start_date=datetime(2021, 1, 1),
+          schedule=EventsTimetable(event_dates=[pendulum.datetime(2022, 4, 5)]),
+      ):
+          ...
+
+  (#25410)
+- Removal of experimental Smart Sensors
+
+  Smart Sensors were added in 2.0 and deprecated in favour of Deferable operators in 2.2, and have now been removed. (#25507)
+- The ``contrib`` packages have now dynamically generated modules and while users can continue using the deprecated contrib classes, they are no longer visible for static code check tools and will be reported as missing. It is recommended for the users to move to non-deprecated classes. (#26153)

Review Comment:
   ```suggestion
   - The ``contrib`` packages anddeprecated moduiles from Airlfow 1.10 in "airflow.hooks", "airflow.operators", "airflow.sensors", have now dynamically generated modules and while users can continue using the deprecated contrib classes, they are no longer visible for static code check tools and will be reported as missing. It is recommended for the users to move to non-deprecated classes. (#26153, #26179, #26167)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on a diff in pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26228:
URL: https://github.com/apache/airflow/pull/26228#discussion_r965751778


##########
RELEASE_NOTES.rst:
##########
@@ -21,6 +21,127 @@
 
 .. towncrier release notes start
 
+Airflow 2.4.0beta1 (2022-09-08)
+-------------------------------
+
+Significant Changes
+^^^^^^^^^^^^^^^^^^^
+
+- The DB related classes: ``DBApiHook``, ``SQLSensor`` have been moved to ``apache-airflow-providers-common-sql`` provider. (NEW)
+- DAGS used in a context manager no longer need to be assigned to a module variable
+
+  Previously you had do assign a DAG to a module-level variable in order for Airflow to pick it up. For example this
+
+  .. code-block:: python
+
+     with DAG(dag_id="example") as dag:
+         ...
+
+
+     @dag
+     def dag_maker():
+         ...
+
+
+     dag2 = dag_maker()
+
+
+  can become
+
+  .. code-block:: python
+
+     with DAG(dag_id="example"):
+         ...
+
+
+     @dag
+     def dag_maker():
+         ...
+
+
+     dag_maker()
+
+  If you want to disable the behaviour for any reason then set ``auto_register=False`` on the dag::
+
+  .. code-block::
+
+     # This dag will not be picked up by Airflow as it's not assigned to a variable
+     with DAG(dag_id="example", auto_register=False):
+        ...
+  (#23592)
+- DAG runs sorting logic changed in grid view
+
+  The ordering of DAG runs in the grid view has been changed to be more "natural".
+  The new logic generally orders by data interval, but a custom ordering can be
+  applied by setting the DAG to use a custom timetable. (#25090)
+- Deprecation of ``schedule_interval`` and ``timetable`` arguments
+
+  We added new DAG argument ``schedule`` that can accept a cron expression, timedelta object, *timetable* object, or list of dataset objects. Arguments ``schedule_interval`` and ``timetable`` are deprecated.
+
+  If you previously used the ``@daily`` cron preset, your DAG may have looked like this:
+
+  .. code-block:: python
+      with DAG(
+          dag_id='my_example',
+          start_date=datetime(2021, 1, 1),
+          schedule_interval='@daily',
+      ):
+          ...
+
+  Going forward, you should use the ``schedule`` argument instead:
+
+  .. code-block:: python
+      with DAG(
+          dag_id='my_example',
+          start_date=datetime(2021, 1, 1),
+          schedule='@daily',
+      ):
+          ...
+
+  The same is true if you used a custom timetable.  Previously you would have used the ``timetable`` argument:
+
+  .. code-block:: python
+      with DAG(
+          dag_id='my_example',
+          start_date=datetime(2021, 1, 1),
+          timetable=EventsTimetable(event_dates=[pendulum.datetime(2022, 4, 5)]),
+      ):
+          ...
+
+  Now you should use the ``schedule`` argument:
+
+  .. code-block:: python
+      with DAG(
+          dag_id='my_example',
+          start_date=datetime(2021, 1, 1),
+          schedule=EventsTimetable(event_dates=[pendulum.datetime(2022, 4, 5)]),
+      ):
+          ...
+
+  (#25410)
+- Removal of experimental Smart Sensors
+
+  Smart Sensors were added in 2.0 and deprecated in favour of Deferable operators in 2.2, and have now been removed. (#25507)
+- The ``contrib`` packages have now dynamically generated modules and while users can continue using the deprecated contrib classes, they are no longer visible for static code check tools and will be reported as missing. It is recommended for the users to move to non-deprecated classes. (#26153)

Review Comment:
   ```suggestion
   - The ``airflow.contrib`` packages and deprecated modules from Airlfow 1.10 in ``airflow.hooks``, ``airflow.operators``, ``airflow.sensors`` packages, have now dynamically generated modules and while users can continue using the deprecated contrib classes, they are no longer visible for static code check tools and will be reported as missing. It is recommended for the users to move to non-deprecated classes. (#26153, #26179, #26167)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240666917

   BTW. I think the problem is that the newsfragments are not checked for spelling I will take a look at that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240640229

   > The auto register fragment is _so_ long I think we should change the items into subsections. Should this be done here or in a later PR?
   
   Yeah. We should split it definitely (and can be done separately)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240512740

   Yeah, just noticed that, and fixing the check in version head map to understand that.
   
   My "fix" was to just remove the `--version-suffix-for-pypi` from the build images workflow -- we dont' need it there do we?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240617735

   Looks like CI wants us to update the versions anyway, cool I'll do that then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240681882

   Tested docs locally, living fast-n-loose :shipit: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] uranusjr commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240512081

   The auto register fragment is _so_ long I think we should change the items into subsections. Should this be done here or in a later PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb merged pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
ashb merged PR #26228:
URL: https://github.com/apache/airflow/pull/26228


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240535500

   > The auto register fragment is _so_ long I think we should change the items into subsections. Should this be done here or in a later PR?
   
   Probably later PR -- we'll need to add a load more anyway (there's nothing in there about Datasets for instance)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240665234

   docs failiung though 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240665597

   > Incorrect Spelling: 'favour'
   > Line with Error: 'Smart Sensors were added in 2.0 and deprecated in favour of Deferable operators in 2.2, and have now been removed.'
   > Line Number: 127
   
   🫖 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ephraimbuddy commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240488364

   Should we also change all references of `2.4.0.dev0` to `2.4.0beta1`? Mostly in docs/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240674025

   > BTW. I think the problem is that the newsfragments are not checked for spelling I will take a look at that
   
   Yeah, I was thinking the same. A number of errors I had to fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240503454

   I think it should be `b1` not `beta1` because that's what setuptools normalize beta1 to in PyPI (I am also fixing the non-matching suffix problem in a moment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #26228: Prepare to release 2.4.0beta1

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26228:
URL: https://github.com/apache/airflow/pull/26228#issuecomment-1240517040

   Fix here: https://github.com/apache/airflow/pull/26230
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org