[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #36012: GH-35859: [Python] Actually change the default row group size to 1Mi

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on code in PR #36012:
URL: https://github.com/apache/arrow/pull/36012#discussion_r1238952785


##########
python/pyarrow/_parquet.pyx:
##########
@@ -1767,7 +1767,7 @@ cdef class ParquetWriter(_Weakrefable):
             int64_t c_row_group_size
 
         if row_group_size is None or row_group_size == -1:
-            c_row_group_size = ctable.num_rows()
+            c_row_group_size = min(ctable.num_rows(), 1024*1024)

Review Comment:
   Either way is fine for me, but so it would like the following (defined at the top of the file, after the imports):
   
   https://github.com/apache/arrow/blob/2ce4a38fcf1fbd0d759b6c2cdf657f27ee6f02a9/python/pyarrow/_dataset.pyx#L42-L46
   
   (but for something that is not reused multiple times, it is less worth it, I think)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org