You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "Jeremy Haile (JIRA)" <ji...@apache.org> on 2009/01/21 14:08:00 UTC

[jira] Commented: (JSEC-8) Change instance variables from private to protected

    [ https://issues.apache.org/jira/browse/JSEC-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665818#action_12665818 ] 

Jeremy Haile commented on JSEC-8:
---------------------------------

I do agree that this isn't good on a sweeping level, but I also hate projects that make all instance variables private to the point that classes that should be extensible aren't extensible because you can't extend them and access the data that you need.  Sure, there are other ways to promote extensibility other than providing access to all instance variables, but I don't think we always do that either.  Regardless of how we achieve it, we have many classes that aren't very extensible due to their use of private instance variables and we should consider how to resolve that problem.

> Change instance variables from private to protected
> ---------------------------------------------------
>
>                 Key: JSEC-8
>                 URL: https://issues.apache.org/jira/browse/JSEC-8
>             Project: JSecurity
>          Issue Type: Improvement
>          Components: Specification API
>            Reporter: Alan Cabrera
>            Assignee: Les Hazlewood
>             Fix For: 1.0
>
>
> Currently most instance variables are private, which limits options when the classes are extended. We are standardizing on protected from now on, but the existing classes should be updated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.