You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/07/17 17:14:33 UTC

[PR] Refactor MCP request context session identity [shardingsphere]

terrymanu opened a new pull request, #39173:
URL: https://github.com/apache/shardingsphere/pull/39173

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor MCP request context session identity [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39173:
URL: https://github.com/apache/shardingsphere/pull/39173


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor MCP request context session identity [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39173:
URL: https://github.com/apache/shardingsphere/pull/39173#issuecomment-5005977309

   ### Summary
   
   **Review Result: Mergeable**
   
   The latest PR head is code-scope mergeable: the session identity refactor, transport enum migration, lifecycle synchronization, and attribution handling are internally consistent, and no actionable correctness regression was found. CI was not reviewed by request.
   
   ### Review Details
   
   - Reviewed latest head `ff948bee02437a88961ab59e30a468c99e06c6a4` against merge-base `5c0e8aac13e35850b71bac61832de1e8881844cb`.
   - Reviewed all 77 files reported by GitHub; the file list matched the local diff scope.
   - Rechecked session identity propagation, HTTP attribution/security validation, transport enum migration, lifecycle locking, session cleanup, and updated callers/tests.
   - Verification passed:
     - MCP module test compilation
     - Focused MCP session, HTTP transport, attribution, and security tests
     - Spotless
     - Checkstyle
   - Documentation was updated for the new request-context and session-attribution contracts.
   - Not reviewed: GitHub Actions, check runs, and CI status, by request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org