You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by bu...@apache.org on 2007/04/25 16:27:55 UTC
DO NOT REPLY [Bug 42242] New: - revision view is broken
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42242>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42242
Summary: revision view is broken
Product: Lenya
Version: Trunk
Platform: Other
OS/Version: other
Status: NEW
Severity: blocker
Priority: P2
Component: Revision Controller
AssignedTo: dev@lenya.apache.org
ReportedBy: nettings@apache.org
two oddities wrt revisions:
* in lenya.usecase=tab.revisions, click on revision N. the link points to N+1.
* regardless of the revision you ask for, you always get the current one.
a quick grep through the code shows that the only time we actually evaluate the
"lenya.revision" parameter is in global-sitemap.xmap, to determine whether to
display a menu (old revisions don't get one to keep the user from trying to edit
them).
there seem to be doctype-specific (uugh!) "view-revision" thingies, but i can't
tell how they are supposed to work.
we should fix this for 1.4 unless it implies intrusive changes...
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42242] - [PATCH] revision view is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42242>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42242
andreas@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|revision view is broken |[PATCH] revision view is
| |broken
------- Additional Comments From andreas@apache.org 2007-04-25 08:52 -------
This snippet has to be added to DocumentSourceFactory:
if (target.isRevisionSpecified()) {
if (queryString == null) {
queryString = "";
}
queryString += "rev=" + target.getRevisionNumber();
}
Unfortunately I have another overlapping patch pending (see bug 42237), so it's
quite hard to create a real patch.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42242] - revision view is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42242>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42242
------- Additional Comments From andreas@apache.org 2007-04-25 08:21 -------
(In reply to comment #0)
> two oddities wrt revisions:
> * in lenya.usecase=tab.revisions, click on revision N. the link points to N+1.
That's because it starts to count with 1, but the first revision doesn't have a
backup and therefore it is not in the list (see Revisions.java):
entries = this.rcml.getBackupEntries();
We could display the actual version numbers, but then the list would start with
"2". Or maybe we could add a backup for the initial version (no idea why this
doesn't happen).
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42242] - [PATCH] revision view is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42242>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42242
andreas@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|blocker |normal
------- Additional Comments From andreas@apache.org 2007-04-26 04:53 -------
(In reply to comment #0)
> * regardless of the revision you ask for, you always get the current one.
I applied the patch, so this aspect of the issue should be resolved.
Nevertheless I'm leaving this open since the revision numbering and backup
handling needs to be improved.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42242] - [PATCH] revision view is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42242>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42242
------- Additional Comments From nettings@apache.org 2007-04-25 08:59 -------
can't really figure where that snippet belongs... but you can back out your
other pending patch - it's filed safely in bugzilla and queued for 1.4.1, and a
workaround is in place.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42242] - revision view is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42242>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42242
------- Additional Comments From andreas@apache.org 2007-04-25 08:35 -------
(In reply to comment #2)
> let me get this straight: we have revisions, and each revision also has a backup
> copy?
The revision information is stored in the .rcml file. For a check-in revision it
is optional if a backup shall be created.
> why?
Actually I have no idea, it has been like that before I joined the project.
> and yes, if that is the case, we should have a backup for rev1 as well...
Maybe we should just make the backup mandatory (at least until we have
incremental version storage).
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42242] - [PATCH] revision view is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42242>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42242
andreas@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From andreas@apache.org 2007-04-26 05:33 -------
Now the obsure fake check-in entry isn't added anymore, so the version numbers
should reflect the actual changes.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42242] - revision view is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42242>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42242
------- Additional Comments From nettings@apache.org 2007-04-25 08:31 -------
(In reply to comment #1)
> That's because it starts to count with 1, but the first revision doesn't have
> a backup and therefore it is not in the list (see Revisions.java):
>
> entries = this.rcml.getBackupEntries();
>
> We could display the actual version numbers, but then the list would start with
> "2". Or maybe we could add a backup for the initial version (no idea why this
> doesn't happen).
let me get this straight: we have revisions, and each revision also has a backup
copy? why?
and yes, if that is the case, we should have a backup for rev1 as well...
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42242] - revision view is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42242>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42242
------- Additional Comments From andreas@apache.org 2007-04-25 08:42 -------
The DocumentSourceFactory doesn't include the rev parameter in the lenya:// URL.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org