You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/30 02:15:19 UTC
[GitHub] [pulsar] horizonzy commented on a diff in pull request #16290: [fix][doc] Modify comments and doc for brokerDeleteInactiveTopicsMaxInactiveDurationSeconds
horizonzy commented on code in PR #16290:
URL: https://github.com/apache/pulsar/pull/16290#discussion_r910545812
##########
conf/broker.conf:
##########
@@ -188,7 +188,7 @@ brokerDeleteInactiveTopicsMode=delete_when_no_subscriptions
brokerDeleteInactivePartitionedTopicMetadataEnabled=false
# Max duration of topic inactivity in seconds, default is not present
-# If not present, 'brokerDeleteInactiveTopicsFrequencySeconds' will be used
Review Comment:
https://github.com/apache/pulsar/blob/f230d15ffcd5f74cca13bd23b35ace784d6f8ce6/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java#L2834-L2840
##########
deployment/terraform-ansible/templates/broker.conf:
##########
@@ -133,7 +133,7 @@ brokerDeleteInactiveTopicsFrequencySeconds=60
brokerDeleteInactiveTopicsMode=delete_when_no_subscriptions
# Max duration of topic inactivity in seconds, default is not present
-# If not present, 'brokerDeleteInactiveTopicsFrequencySeconds' will be used
+# If present, 'brokerDeleteInactiveTopicsFrequencySeconds' will be used
Review Comment:
Should not change it
##########
conf/broker.conf:
##########
@@ -188,7 +188,7 @@ brokerDeleteInactiveTopicsMode=delete_when_no_subscriptions
brokerDeleteInactivePartitionedTopicMetadataEnabled=false
# Max duration of topic inactivity in seconds, default is not present
-# If not present, 'brokerDeleteInactiveTopicsFrequencySeconds' will be used
Review Comment:
Should not change it
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -576,7 +576,7 @@ public class ServiceConfiguration implements PulsarConfiguration {
@FieldContext(
category = CATEGORY_POLICIES,
doc = "Max duration of topic inactivity in seconds, default is not present\n"
- + "If not present, 'brokerDeleteInactiveTopicsFrequencySeconds' will be used\n"
+ + "If present, 'brokerDeleteInactiveTopicsFrequencySeconds' will be used\n"
Review Comment:
Should not change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org