[GitHub] EvelynTurner commented on issue #5211: [Bug fix] Divide by 1000.000 in epoch_ms_to_dttm() to not lose precision in Presto

[GitBox <gi...@apache.org>]

EvelynTurner commented on issue #5211: [Bug fix] Divide by 1000.000 in epoch_ms_to_dttm() to not lose precision in Presto
URL: https://github.com/apache/incubator-superset/pull/5211#issuecomment-397916176
 
 
   @john-bodley That's because of your `parse_decimal_literals_as_double` setting..
   
   > For compatibility reasons decimal literals without explicit type specifier (e.g. 1.2) are treated as the values of the DOUBLE type by default, but this is subject to change in future releases. This behavior is controlled by:
   > System wide property: parse-decimal-literals-as-double
   > Session wide property: parse_decimal_literals_as_double
   
   https://prestodb.io/docs/current/language/types.html#floating-point
   
   I can always set it as true, but I didn't see any harm in accommodating to the other setting as well. Maybe we can document it somewhere that people need to set those properties as `true` for Presto then.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org