You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by ��������� <94...@gmail.com> on 2019/12/03 13:20:33 UTC
Can the SpanLayer.java not enum and let user custome?
Can you open this class Let user customer.
I think this code had no strong contract with server side.
Maybe I hadn't clear this project. please point out.
Thanks~!
Re: Can the SpanLayer.java not enum and let user custome?
Posted by ZhuoSi Chen <94...@gmail.com>.
On 2019/12/04 11:03:06, Sheng Wu <wu...@gmail.com> wrote:
> Which layer? If it makes sense, you could do that on upstream(Apache repo).
> The reason we prefer to lock it, is that these values are sensitive for
> analysis. If people add the value randomly, the analysis will break. This
> is for the project feature stability.
>
> ZhuoSi Chen <94...@gmail.com>于2019年12月4日 周三下午7:01写道：
>
> >
> >
> > On 2019/12/04 10:39:42, Sheng Wu <wu...@gmail.com> wrote:
> > > Good to know. Could you give me more details why you want to extend this
> > > type?
> > >
> > > ZhuoSi Chen <94...@gmail.com>于2019年12月4日 周三下午6:37写道：
> > >
> > > >
> > > >
> > > > On 2019/12/03 13:56:52, Sheng Wu <wu...@gmail.com> wrote:
> > > > > Hi Zhuosi
> > > > >
> > > > > You still haven’t subscribed the mail list. Please do, otherwise, the
> > > > > discussion
> > > > >
> > > > > 陈卓思 <94...@gmail.com>于2019年12月3日 周二下午9:54写道：
> > > > >
> > > > > > Can you open this class Let user customer.
> > > > > > I think this code had no strong contract with server side.
> > > > > > Maybe I hadn't clear this project. please point out.
> > > > > > Thanks~!
> > > > > >
> > > > > --
> > > > > Sheng Wu 吴晟
> > > > >
> > > > > Apache SkyWalking
> > > > > Apache Incubator
> > > > > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > > > > Zipkin
> > > > > Twitter, wusheng1108
> > > > >
> > > > I had I had subscribe by the qq email and the qq email don't support by
> > > > the apache.
> > > > Now I had subscribe by the gmail too and my gmail also reciver the mail
> > > > contain the content
> > > > I'm working for my owner, who can be reached
> > > > at dev-owner@skywalking.apache.org.
> > > > Acknowledgment: I have added the address
> > > > 94mu***@gmail.com
> > > > to the dev mailing list.
> > > > what I should do next？
> > > >
> > > --
> > > Sheng Wu 吴晟
> > >
> > > Apache SkyWalking
> > > Apache Incubator
> > > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > > Zipkin
> > > Twitter, wusheng1108
> >
> > Because I think the code should more freedom.
> > And I want to add a new one to SpanLayer.I find no way to go on.
> > Also I don't know what is will effect.
> >
> --
> Sheng Wu 吴晟
>
> Apache SkyWalking
> Apache Incubator
> Apache ShardingSphere, ECharts, DolphinScheduler podlings
> Zipkin
> Twitter, wusheng1108
Thank you for your answer！
Re: Can the SpanLayer.java not enum and let user custome?
Posted by Sheng Wu <wu...@gmail.com>.
Which layer? If it makes sense, you could do that on upstream(Apache repo).
The reason we prefer to lock it, is that these values are sensitive for
analysis. If people add the value randomly, the analysis will break. This
is for the project feature stability.
ZhuoSi Chen <94...@gmail.com>于2019年12月4日 周三下午7:01写道：
>
>
> On 2019/12/04 10:39:42, Sheng Wu <wu...@gmail.com> wrote:
> > Good to know. Could you give me more details why you want to extend this
> > type?
> >
> > ZhuoSi Chen <94...@gmail.com>于2019年12月4日 周三下午6:37写道：
> >
> > >
> > >
> > > On 2019/12/03 13:56:52, Sheng Wu <wu...@gmail.com> wrote:
> > > > Hi Zhuosi
> > > >
> > > > You still haven’t subscribed the mail list. Please do, otherwise, the
> > > > discussion
> > > >
> > > > 陈卓思 <94...@gmail.com>于2019年12月3日 周二下午9:54写道：
> > > >
> > > > > Can you open this class Let user customer.
> > > > > I think this code had no strong contract with server side.
> > > > > Maybe I hadn't clear this project. please point out.
> > > > > Thanks~!
> > > > >
> > > > --
> > > > Sheng Wu 吴晟
> > > >
> > > > Apache SkyWalking
> > > > Apache Incubator
> > > > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > > > Zipkin
> > > > Twitter, wusheng1108
> > > >
> > > I had I had subscribe by the qq email and the qq email don't support by
> > > the apache.
> > > Now I had subscribe by the gmail too and my gmail also reciver the mail
> > > contain the content
> > > I'm working for my owner, who can be reached
> > > at dev-owner@skywalking.apache.org.
> > > Acknowledgment: I have added the address
> > > 94mu***@gmail.com
> > > to the dev mailing list.
> > > what I should do next？
> > >
> > --
> > Sheng Wu 吴晟
> >
> > Apache SkyWalking
> > Apache Incubator
> > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > Zipkin
> > Twitter, wusheng1108
>
> Because I think the code should more freedom.
> And I want to add a new one to SpanLayer.I find no way to go on.
> Also I don't know what is will effect.
>
--
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108
Re: Can the SpanLayer.java not enum and let user custome?
Posted by ZhuoSi Chen <94...@gmail.com>.
On 2019/12/04 10:39:42, Sheng Wu <wu...@gmail.com> wrote:
> Good to know. Could you give me more details why you want to extend this
> type?
>
> ZhuoSi Chen <94...@gmail.com>于2019年12月4日 周三下午6:37写道：
>
> >
> >
> > On 2019/12/03 13:56:52, Sheng Wu <wu...@gmail.com> wrote:
> > > Hi Zhuosi
> > >
> > > You still haven’t subscribed the mail list. Please do, otherwise, the
> > > discussion
> > >
> > > 陈卓思 <94...@gmail.com>于2019年12月3日 周二下午9:54写道：
> > >
> > > > Can you open this class Let user customer.
> > > > I think this code had no strong contract with server side.
> > > > Maybe I hadn't clear this project. please point out.
> > > > Thanks~!
> > > >
> > > --
> > > Sheng Wu 吴晟
> > >
> > > Apache SkyWalking
> > > Apache Incubator
> > > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > > Zipkin
> > > Twitter, wusheng1108
> > >
> > I had I had subscribe by the qq email and the qq email don't support by
> > the apache.
> > Now I had subscribe by the gmail too and my gmail also reciver the mail
> > contain the content
> > I'm working for my owner, who can be reached
> > at dev-owner@skywalking.apache.org.
> > Acknowledgment: I have added the address
> > 94mu***@gmail.com
> > to the dev mailing list.
> > what I should do next？
> >
> --
> Sheng Wu 吴晟
>
> Apache SkyWalking
> Apache Incubator
> Apache ShardingSphere, ECharts, DolphinScheduler podlings
> Zipkin
> Twitter, wusheng1108
Because I think the code should more freedom.
And I want to add a new one to SpanLayer.I find no way to go on.
Also I don't know what is will effect.
Re: Can the SpanLayer.java not enum and let user custome?
Posted by Sheng Wu <wu...@gmail.com>.
Good to know. Could you give me more details why you want to extend this
type?
ZhuoSi Chen <94...@gmail.com>于2019年12月4日 周三下午6:37写道：
>
>
> On 2019/12/03 13:56:52, Sheng Wu <wu...@gmail.com> wrote:
> > Hi Zhuosi
> >
> > You still haven’t subscribed the mail list. Please do, otherwise, the
> > discussion
> >
> > 陈卓思 <94...@gmail.com>于2019年12月3日 周二下午9:54写道：
> >
> > > Can you open this class Let user customer.
> > > I think this code had no strong contract with server side.
> > > Maybe I hadn't clear this project. please point out.
> > > Thanks~!
> > >
> > --
> > Sheng Wu 吴晟
> >
> > Apache SkyWalking
> > Apache Incubator
> > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > Zipkin
> > Twitter, wusheng1108
> >
> I had I had subscribe by the qq email and the qq email don't support by
> the apache.
> Now I had subscribe by the gmail too and my gmail also reciver the mail
> contain the content
> I'm working for my owner, who can be reached
> at dev-owner@skywalking.apache.org.
> Acknowledgment: I have added the address
> 94mu***@gmail.com
> to the dev mailing list.
> what I should do next？
>
--
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108
Re: Can the SpanLayer.java not enum and let user custome?
Posted by ZhuoSi Chen <94...@gmail.com>.
On 2019/12/03 13:56:52, Sheng Wu <wu...@gmail.com> wrote:
> Hi Zhuosi
>
> You still haven’t subscribed the mail list. Please do, otherwise, the
> discussion
>
> 陈卓思 <94...@gmail.com>于2019年12月3日 周二下午9:54写道：
>
> > Can you open this class Let user customer.
> > I think this code had no strong contract with server side.
> > Maybe I hadn't clear this project. please point out.
> > Thanks~!
> >
> --
> Sheng Wu 吴晟
>
> Apache SkyWalking
> Apache Incubator
> Apache ShardingSphere, ECharts, DolphinScheduler podlings
> Zipkin
> Twitter, wusheng1108
>
I had I had subscribe by the qq email and the qq email don't support by the apache.
Now I had subscribe by the gmail too and my gmail also reciver the mail contain the content
I'm working for my owner, who can be reached
at dev-owner@skywalking.apache.org.
Acknowledgment: I have added the address
94mu***@gmail.com
to the dev mailing list.
what I should do next？
Re: Can the SpanLayer.java not enum and let user custome?
Posted by Sheng Wu <wu...@gmail.com>.
Hi Zhuosi
You still haven’t subscribed the mail list. Please do, otherwise, the
discussion
陈卓思 <94...@gmail.com>于2019年12月3日 周二下午9:54写道：
> Can you open this class Let user customer.
> I think this code had no strong contract with server side.
> Maybe I hadn't clear this project. please point out.
> Thanks~!
>
--
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108