[jira] [Commented] (HAMA-456) Add getPeerName(int index) and Fix getAllPeerNames()

["Thomas Jungblut (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HAMA-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129582#comment-13129582 ] 

Thomas Jungblut commented on HAMA-456:
--------------------------------------

Additionally I would just sort the array of the children before using the index, so the method returns the same host on other hosts.

If we want to remove getAllPeerNames though, I would throw an UnsupportedOperationException and set this to deprecated with a link to getPeerName(int index).
                
> Add getPeerName(int index) and Fix getAllPeerNames()
> ----------------------------------------------------
>
>                 Key: HAMA-456
>                 URL: https://issues.apache.org/jira/browse/HAMA-456
>             Project: Hama
>          Issue Type: Bug
>          Components: bsp
>    Affects Versions: 0.3.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.4.0
>
>
> 1. Add getPeerName(int index) and move mater task election logic into bsp() function.
> 2. getAllPeerNames() will always return null in bsp() function.
> {code}
>   public String[] getAllPeerNames() {
>     String[] result = null;
>     try {
>       result = zk.getChildren("/" + jobConf.getJobID().toString(), this)
>           .toArray(new String[0]);
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira