You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2012/12/04 22:56:58 UTC
[jira] [Created] (CASSANDRA-5026) Reduce log spam from counter
shard warnings
Jonathan Ellis created CASSANDRA-5026:
-----------------------------------------
Summary: Reduce log spam from counter shard warnings
Key: CASSANDRA-5026
URL: https://issues.apache.org/jira/browse/CASSANDRA-5026
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Jonathan Ellis
Assignee: Sylvain Lebresne
Priority: Minor
Fix For: 1.1.8
The invalid counter shard warning we can get after unclean shutdown in periodic commitlog mode or after node movement (CASSANDRA-4071) can spam the log hard since it is logged once per read until compaction merges it away.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5026) Reduce log spam from counter
shard warnings
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510054#comment-13510054 ]
Jonathan Ellis commented on CASSANDRA-5026:
-------------------------------------------
Possible fixes include:
# forcing compaction when we see the problem
# keeping a Map of shards we've logged it for and shutting up about it after the first time
# only logging it during compaction instead of the read path
(1) is conceptually simple but problematic for LCS. (2) intertwines logging w/ server logic at a level that makes me uncomfortable. Which leaves (3) as the best option IMO.
> Reduce log spam from counter shard warnings
> -------------------------------------------
>
> Key: CASSANDRA-5026
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5026
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.1.8
>
>
> The invalid counter shard warning we can get after unclean shutdown in periodic commitlog mode or after node movement (CASSANDRA-4071) can spam the log hard since it is logged once per read until compaction merges it away.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5026) Reduce log spam from counter
shard warnings
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510380#comment-13510380 ]
Sylvain Lebresne commented on CASSANDRA-5026:
---------------------------------------------
bq. only logging it during compaction
Agreed that it's the best option. It'll also make the message more true in the sense that the message says "will pick highest to self-heal", but we only "self-heal" things on compaction.
Patch attached for that.
> Reduce log spam from counter shard warnings
> -------------------------------------------
>
> Key: CASSANDRA-5026
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5026
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.1.8
>
> Attachments: 5026.txt
>
>
> The invalid counter shard warning we can get after unclean shutdown in periodic commitlog mode or after node movement (CASSANDRA-4071) can spam the log hard since it is logged once per read until compaction merges it away.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5026) Reduce log spam from counter
shard warnings
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-5026:
----------------------------------------
Attachment: 5026.txt
> Reduce log spam from counter shard warnings
> -------------------------------------------
>
> Key: CASSANDRA-5026
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5026
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.1.8
>
> Attachments: 5026.txt
>
>
> The invalid counter shard warning we can get after unclean shutdown in periodic commitlog mode or after node movement (CASSANDRA-4071) can spam the log hard since it is logged once per read until compaction merges it away.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira