You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/11/07 22:56:00 UTC
[jira] [Commented] (IMPALA-7822) Crash in repeat() constructing
strings > 1GB
[ https://issues.apache.org/jira/browse/IMPALA-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678913#comment-16678913 ]
ASF subversion and git services commented on IMPALA-7822:
---------------------------------------------------------
Commit 250d85e94eef356caac15de94ed500b7d7ec2ca6 in impala's branch refs/heads/master from [~tarmstrong@cloudera.com]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=250d85e ]
IMPALA-7822: handle overflows in repeat() builtin
We need to carefully check that the intermediate value fits in an
int64_t and the final size fits in an int. If they don't we
raise an error and fail the query.
Testing:
Added a couple of backend tests to exercise the
overflow check code paths.
Change-Id: I872ce77bc2cb29116881c27ca2a5216f722cdb2a
Reviewed-on: http://gerrit.cloudera.org:8080/11889
Reviewed-by: Thomas Marshall <th...@cmu.edu>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Crash in repeat() constructing strings > 1GB
> --------------------------------------------
>
> Key: IMPALA-7822
> URL: https://issues.apache.org/jira/browse/IMPALA-7822
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 2.3.0, Impala 2.5.0, Impala 2.4.0, Impala 2.6.0, Impala 2.7.0, Impala 2.8.0, Impala 2.9.0, Impala 2.10.0, Impala 2.11.0, Impala 3.0, Impala 3.1.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Critical
> Labels: crash
>
> {noformat}
> select repeat('x', 1024 * 1024 * 1024 * 1024);
> {noformat}
> {noformat}
> #0 0x0000000004551aa3 in google_breakpad::ExceptionHandler::SignalHandler(int, siginfo_t*, void*) ()
> #1 0x00007f72cdc0f362 in ?? () from /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so
> #2 0x00007f72cdc138b9 in JVM_handle_linux_signal ()
> from /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so
> #3 0x00007f72cdc06f78 in ?? () from /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so
> #4 <signal handler called>
> #5 0x00007f72cab8a06c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
> #6 0x00000000030e19da in impala::StringFunctions::Repeat (context=0x721f800, str=..., n=...)
> at be/src/exprs/string-functions-ir.cc:100
> #7 0x0000000003145c32 in impala::ScalarFnCall::InterpretEval<impala_udf::StringVal> (
> this=0xaf2cb40, eval=0xd26ccc0, row=0x0) at be/src/exprs/scalar-fn-call.cc:485
> #8 0x000000000312bd85 in impala::ScalarFnCall::GetStringVal (this=0xaf2cb40, eval=0xd26ccc0,
> row=0x0) at be/src/exprs/scalar-fn-call.cc:599
> #9 0x00000000030da116 in impala::ScalarExprEvaluator::GetValue (this=0xd26ccc0, expr=..., row=0x0)
> at be/src/exprs/scalar-expr-evaluator.cc:299
> #10 0x00000000030d9da5 in impala::ScalarExprEvaluator::GetValue (this=0xd26ccc0, row=0x0)
> at be/src/exprs/scalar-expr-evaluator.cc:250
> #11 0x0000000001fc59bc in Java_org_apache_impala_service_FeSupport_NativeEvalExprsWithoutRow (
> env=0xd25b1e0, caller_class=0x7f724d523280, thrift_expr_batch=0x7f724d523298,
> thrift_query_ctx_bytes=0x7f724d523290) at be/src/service/fe-support.cc:237
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org