You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "scottlan0113 (via GitHub)" <gi...@apache.org> on 2026/09/04 14:54:02 UTC
[PR] Add an InstancePlanMakerImplV2 extension point for the combine plan node [pinot]
scottlan0113 opened a new pull request, #19461:
URL: https://github.com/apache/pinot/pull/19461
## Motivation
`CombinePlanNode` exposes a protected method per combine operator, so an implementation can substitute the operator for one query type and leave the rest to the existing dispatch. Nothing outside `org.apache.pinot.core.plan.maker` can construct a subclass that uses them, though.
`makeInstancePlan` and `makeStreamingInstancePlan` both construct `CombinePlanNode` directly, so substituting means overriding one of those. Both open with `applyQueryOptions`, which is package-private and reads private server-level fields — `_maxExecutionThreads`, `_defaultExecutionThreads`, `_numGroupsLimit`, `_numGroupsWarningLimit`, and the trim/capacity settings — that `init()` populates from the server configuration and no accessor exposes. Nothing else calls it. So an override outside this package can neither invoke it nor reproduce it: a copy would compute the wrong execution-thread count and trim sizes.
## Change
Extract the construction into a protected `createCombinePlanNode()` used by both entry points.
```java
protected CombinePlanNode createCombinePlanNode(List<PlanNode> planNodes, QueryContext queryContext,
ExecutorService executorService, @Nullable ResultsBlockStreamer streamer) {
return new CombinePlanNode(planNodes, queryContext, executorService, streamer);
}
```
One method rather than one per entry point. The streaming/non-streaming distinction is already expressed inside `CombinePlanNode`, which picks the combine operator per query type; expressing it here as well would state the same choice twice, and a subclass substituting one query type still overrides only that one method.
The objects constructed, the conditions and their ordering are unchanged.
## Testing
56 existing tests pass across `CombinePlanNodeTest` (6), `InstancePlanMakerImplV2Test` (5), `SelectionCombineOperatorTest` (7), `SortedGroupByCombineOperatorsTest` (12), `StreamingGroupByCombineOperatorTest` (9) and `StreamingDistinctCombineOperatorTest` (17) — the construction moved, nothing about what gets constructed changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add an InstancePlanMakerImplV2 extension point for the combine plan node [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #19461:
URL: https://github.com/apache/pinot/pull/19461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add an InstancePlanMakerImplV2 extension point for the combine plan node [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19461:
URL: https://github.com/apache/pinot/pull/19461#issuecomment-5542915534
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19461?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 0.00%. Comparing base ([`1ccc708`](https://app.codecov.io/gh/apache/pinot/commit/1ccc708ea1c675a599a2c93bfa87553adffd0da3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b368d2d`](https://app.codecov.io/gh/apache/pinot/commit/b368d2d47d00281eb916dbdab7a2167afe8b1719?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (1ccc708) and HEAD (b368d2d). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (1ccc708) | HEAD (b368d2d) |
>|------|------|------|
>|lane-a|2|1|
>|integration|4|2|
>|java-25|6|2|
>|integration1|2|0|
>|temurin|6|2|
>|lane-b|2|1|
>|unittests1|1|0|
>|unittests|2|0|
>|unittests2|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19461 +/- ##
=============================================
- Coverage 67.64% 0.00% -67.65%
=============================================
Files 3488 3 -3485
Lines 224396 6 -224390
Branches 35422 0 -35422
=============================================
- Hits 151788 0 -151788
+ Misses 60577 6 -60571
+ Partials 12031 0 -12031
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/19461/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/19461/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/19461/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/19461/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
| [java-25](https://app.codecov.io/gh/apache/pinot/pull/19461/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-67.65%)` | :arrow_down: |
| [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19461/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19461/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/19461/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-67.65%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/19461/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19461/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/19461/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19461?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org