You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/02/26 01:30:46 UTC
[GitHub] chenboat commented on issue #3877: Pinot controller side change to
enhance LLC segment metadata upload.
chenboat commented on issue #3877: Pinot controller side change to enhance LLC segment metadata upload.
URL: https://github.com/apache/incubator-pinot/pull/3877#issuecomment-467255194
> +1 to @mcvsubbu's comment about adding it in the existing call instead of having a new segmentCommitEndWithMetadata. It would much simpler to migrate, and we'll avoid a lot of code duplication
I think @mcvsubbu was asking to add an optional form to the existing segmentCommitEnd() and add a new POST endpoint segmentCommitEndWithMetadata() ?
The current segmentCommitEnd() is a GET. If I make it a POST (which seems the right type to me) and add the form to it, would it be backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org