You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "Owen Nichols (Jira)" <ji...@apache.org> on 2019/12/31 20:41:00 UTC

[jira] [Updated] (GEODE-7609) Disable all buttons other than 'Squash and Merge' for GitHub PRs

     [ https://issues.apache.org/jira/browse/GEODE-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen Nichols updated GEODE-7609:
--------------------------------
    Description: 
It's all too easy to accidentally merge a PR without squashing, which can lead to commits like "spotless" and "fix test" landing on develop.  This makes bisect operations more difficult and makes it harder to revert or cherry-pick the fix later on.

Even if done intentionally, non-squashed merges also allow commits to land on develop which have not been verified to pass required PR checks.  This loophole needs to be closed.

  was:It's all too easy to accidentally merge a PR without squashing, which can lead to commits like "spotless" and "fix test" landing on develop.  This makes bisect operations more difficult and makes it harder to revert or cherry-pick the fix later on.

        Summary: Disable all buttons other than 'Squash and Merge' for GitHub PRs  (was: Disable 'Create a merge commit' for GitHub PRs)

> Disable all buttons other than 'Squash and Merge' for GitHub PRs
> ----------------------------------------------------------------
>
>                 Key: GEODE-7609
>                 URL: https://issues.apache.org/jira/browse/GEODE-7609
>             Project: Geode
>          Issue Type: Improvement
>          Components: github
>            Reporter: Owen Nichols
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> It's all too easy to accidentally merge a PR without squashing, which can lead to commits like "spotless" and "fix test" landing on develop.  This makes bisect operations more difficult and makes it harder to revert or cherry-pick the fix later on.
> Even if done intentionally, non-squashed merges also allow commits to land on develop which have not been verified to pass required PR checks.  This loophole needs to be closed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)