You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/09 02:23:29 UTC
[GitHub] [incubator-tvm] lixiaoquan opened a new pull request #6885: [Relay][TF] Keep node name in span
lixiaoquan opened a new pull request #6885:
URL: https://github.com/apache/incubator-tvm/pull/6885
With this PR, it is easy to trace a relay CallNode to its source in an imported model. It looks like:
```
%57 = nn.relu(%56) /* resnet_model/Relu_9 */;
%58 = transpose(%resnet_model/conv2d_12/kernel, axes=[3, 2, 0, 1]);
%59 = nn.conv2d(%57, %58, padding=[0, 0, 0, 0], channels=128, kernel_size=[1, 1]) /* resnet_model/conv2d_12/Conv2D */;
%60 = nn.batch_norm(%59, %resnet_model/batch_normalization_10/gamma, %resnet_model/batch_normalization_10/beta, %resnet_model/batch_normalization_10/moving_mean, %resnet_model/batch_normalization_10/moving_variance, epsilon=1.001e-05f) /* resnet_model/batch_normalization_10/FusedBatchNorm */;
```
I'm not sure whether it is the correct to use span.SourceName to store node name, but `line`, `column` doesn't make sense for an imported model.
@jroesch @junrushao1994 @zhiics Could you please help to review? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6885: [Relay][TF] Keep node name in span
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #6885:
URL: https://github.com/apache/incubator-tvm/pull/6885#issuecomment-724065100
I now think that span is the right way to do it, as long as we don't rely the information in passes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6885: [Relay][TF] Keep node name in span
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6885:
URL: https://github.com/apache/incubator-tvm/pull/6885#issuecomment-724065100
I now think that spand is the right way to do it, as long as we don't rely the information in passes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] lixiaoquan commented on pull request #6885: [Relay][TF] Keep node name in span
Posted by GitBox <gi...@apache.org>.
lixiaoquan commented on pull request #6885:
URL: https://github.com/apache/incubator-tvm/pull/6885#issuecomment-725260027
@jroesch I agree with you. It looks like a makeshift to use SourceName to store node name, I did this because it introduced very little change. I think we can add a `hint` field. I added a thread https://discuss.tvm.apache.org/t/expand-span-for-imported-module/8435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6885: [Relay][TF] Keep node name in span
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6885:
URL: https://github.com/apache/incubator-tvm/pull/6885
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6885: [Relay][TF] Keep node name in span
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6885:
URL: https://github.com/apache/incubator-tvm/pull/6885#issuecomment-725055722
@lixiaoquan I think we can do this, but I am not sure if overloading the source spans are the right way? perhaps we can sub-class or modify spans for handling whether they point into a source file or into an imported graph? I think it might be good to clarify this design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] FrozenGene commented on pull request #6885: [Relay][TF] Keep node name in span
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on pull request #6885:
URL: https://github.com/apache/incubator-tvm/pull/6885#issuecomment-723738107
Ah...I think it is a nice feature and should enable it in all frontend, this is good for profiling (like we use debug graph runtime to see every layer's output). But I remember @tqchen said we will have another WIP feature to do this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6885: [Relay][TF] Keep node name in span
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6885:
URL: https://github.com/apache/incubator-tvm/pull/6885#issuecomment-724130793
Perhaps we could also do similar things for other frontends
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org