[GitHub] [spark] AngersZhuuuu edited a comment on issue #25721: [WIP][SPARK-29018][SQL] Implement Spark Thrift Server with it's own code base on PROTOCOL_VERSION_V9

[GitBox <gi...@apache.org>]

AngersZhuuuu edited a comment on issue #25721: [WIP][SPARK-29018][SQL] Implement Spark Thrift Server with it's own code base on PROTOCOL_VERSION_V9
URL: https://github.com/apache/spark/pull/25721#issuecomment-544552243
 
 
   @juliuszsompolski 
   Good suggestion.  How about build a total new thriftserver in new package(your sugggestion) to make sure all the process is ok. Then after all things doing , rename it back to replace old one and remove 1.2.1/2.3.5 dir.
   
   I will focus on the code change about solve hive dependency and remove unused codes.
   And give a detail job list.
   
   When I do this, some code is public and used by 1.2.1/2.3.2 . But most class have some different between 1.2.1/2.3.5, big change from 1.2.1 to 2.3.5. 
   
   About import hive-service, it is acceptable, since we all implement thrift server code in spark/scala. 
   hive-jdbc have to use hive-service code, we need to solve hive dependency so we must delete 1.2.1/2.3.5 folder. We  just import what we need for hive-jdbc to used by `bin/beeline`. It won't impact our thriftsever's code and don't need to concern about version change of hive.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org