You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/05/06 22:30:16 UTC
Review Request 33912: Kerberos: no need for Manage Identities checkbox
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33912/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko and Yusaku Sako.
Bugs: AMBARI-10975
https://issues.apache.org/jira/browse/AMBARI-10975
Repository: ambari
Description
-------
We have a checkbox for "manage kerberos identities". if the user chooses existing MIT or AD on page 1 of the Kerberos Wizard, this is a given. If they choose manage manually, this is not required.
Doesn't seems like there is a need for this checkbox on the wizard since page 1 answers the question.
#Solution#
Edit `site_properties.js` file to hide the checkbox for Manage Identities. While there, made the Kerberos properties non-overridable.
Diffs
-----
ambari-web/app/data/HDP2/site_properties.js ae6051f
Diff: https://reviews.apache.org/r/33912/diff/
Testing
-------
Manually tested to see changes in the Kerberos Wizard and Kerberos configuration page.
Thanks,
Robert Levas
Re: Review Request 33912: Kerberos: no need for Manage Identities
checkbox
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33912/#review82878
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On May 6, 2015, 8:30 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33912/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 8:30 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Yusaku Sako.
>
>
> Bugs: AMBARI-10975
> https://issues.apache.org/jira/browse/AMBARI-10975
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have a checkbox for "manage kerberos identities". if the user chooses existing MIT or AD on page 1 of the Kerberos Wizard, this is a given. If they choose manage manually, this is not required.
>
> Doesn't seems like there is a need for this checkbox on the wizard since page 1 answers the question.
>
> #Solution#
> Edit `site_properties.js` file to hide the checkbox for Manage Identities. While there, made the Kerberos properties non-overridable.
>
>
> Diffs
> -----
>
> ambari-web/app/data/HDP2/site_properties.js ae6051f
>
> Diff: https://reviews.apache.org/r/33912/diff/
>
>
> Testing
> -------
>
> Manually tested to see changes in the Kerberos Wizard and Kerberos configuration page.
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 33912: Kerberos: no need for Manage Identities
checkbox
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33912/#review82881
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On May 6, 2015, 8:30 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33912/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 8:30 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Yusaku Sako.
>
>
> Bugs: AMBARI-10975
> https://issues.apache.org/jira/browse/AMBARI-10975
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have a checkbox for "manage kerberos identities". if the user chooses existing MIT or AD on page 1 of the Kerberos Wizard, this is a given. If they choose manage manually, this is not required.
>
> Doesn't seems like there is a need for this checkbox on the wizard since page 1 answers the question.
>
> #Solution#
> Edit `site_properties.js` file to hide the checkbox for Manage Identities. While there, made the Kerberos properties non-overridable.
>
>
> Diffs
> -----
>
> ambari-web/app/data/HDP2/site_properties.js ae6051f
>
> Diff: https://reviews.apache.org/r/33912/diff/
>
>
> Testing
> -------
>
> Manually tested to see changes in the Kerberos Wizard and Kerberos configuration page.
>
>
> Thanks,
>
> Robert Levas
>
>