You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by vi...@apache.org on 2021/06/23 09:04:34 UTC
[hudi] branch master updated: [HUDI-1826] Add ORC support in
HoodieSnapshotExporter (#3130)
This is an automated email from the ASF dual-hosted git repository.
vinoyang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new 43b9c1f [HUDI-1826] Add ORC support in HoodieSnapshotExporter (#3130)
43b9c1f is described below
commit 43b9c1fa1caf97f6fb2baf68e350615541ea0a0c
Author: Vaibhav Sinha <va...@gmail.com>
AuthorDate: Wed Jun 23 14:34:25 2021 +0530
[HUDI-1826] Add ORC support in HoodieSnapshotExporter (#3130)
---
.../main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java | 4 ++--
.../java/org/apache/hudi/utilities/TestHoodieSnapshotExporter.java | 2 +-
.../apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java b/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java
index ee31d4a..42ab6ca 100644
--- a/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java
+++ b/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java
@@ -85,7 +85,7 @@ public class HoodieSnapshotExporter {
public static class OutputFormatValidator implements IValueValidator<String> {
public static final String HUDI = "hudi";
- public static final List<String> FORMATS = CollectionUtils.createImmutableList("json", "parquet", HUDI);
+ public static final List<String> FORMATS = CollectionUtils.createImmutableList("json", "parquet", "orc", HUDI);
@Override
public void validate(String name, String value) {
@@ -104,7 +104,7 @@ public class HoodieSnapshotExporter {
@Parameter(names = {"--target-output-path"}, description = "Base path for the target output files (snapshots)", required = true)
public String targetOutputPath;
- @Parameter(names = {"--output-format"}, description = "Output format for the exported dataset; accept these values: json|parquet|hudi", required = true,
+ @Parameter(names = {"--output-format"}, description = "Output format for the exported dataset; accept these values: json|parquet|orc|hudi", required = true,
validateValueWith = OutputFormatValidator.class)
public String outputFormat;
diff --git a/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieSnapshotExporter.java b/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieSnapshotExporter.java
index ae74c1d..1096c92 100644
--- a/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieSnapshotExporter.java
+++ b/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieSnapshotExporter.java
@@ -32,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows;
public class TestHoodieSnapshotExporter {
@ParameterizedTest
- @ValueSource(strings = {"json", "parquet", "hudi"})
+ @ValueSource(strings = {"json", "parquet", "orc", "hudi"})
public void testValidateOutputFormatWithValidFormat(String format) {
assertDoesNotThrow(() -> {
new OutputFormatValidator().validate(null, format);
diff --git a/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java b/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java
index aefa49f..133205c 100644
--- a/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java
+++ b/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java
@@ -213,7 +213,7 @@ public class TestHoodieSnapshotExporter extends FunctionalTestHarness {
public class TestHoodieSnapshotExporterForNonHudi {
@ParameterizedTest
- @ValueSource(strings = {"json", "parquet"})
+ @ValueSource(strings = {"json", "parquet", "orc"})
public void testExportAsNonHudi(String format) throws IOException {
HoodieSnapshotExporter.Config cfg = new Config();
cfg.sourceBasePath = sourcePath;