You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2019/04/30 23:48:48 UTC
[kudu-CR] Normalize sentry package name
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13203
Change subject: Normalize sentry package name
......................................................................
Normalize sentry package name
This strips the 'apache' prefix and 'bin' suffix from the thirdparty
tarball package, which brings it inline with the hadoop package naming.
Change-Id: Ic17375e2bb1a2b0993224ebeaaabee2df8bb259f
---
M build-support/run_dist_test.py
M thirdparty/vars.sh
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/13203/1
--
To view, visit http://gerrit.cloudera.org:8080/13203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic17375e2bb1a2b0993224ebeaaabee2df8bb259f
Gerrit-Change-Number: 13203
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] Normalize sentry package name
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13203 )
Change subject: Normalize sentry package name
......................................................................
Patch Set 1:
Unrelated java test failure.
--
To view, visit http://gerrit.cloudera.org:8080/13203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic17375e2bb1a2b0993224ebeaaabee2df8bb259f
Gerrit-Change-Number: 13203
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 May 2019 00:42:24 +0000
Gerrit-HasComments: No
[kudu-CR] Normalize sentry package name
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13203 )
Change subject: Normalize sentry package name
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic17375e2bb1a2b0993224ebeaaabee2df8bb259f
Gerrit-Change-Number: 13203
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 May 2019 01:55:43 +0000
Gerrit-HasComments: No
[kudu-CR] Normalize sentry package name
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13203 )
Change subject: Normalize sentry package name
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13203/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13203/1//COMMIT_MSG@7
PS1, Line 7: Normalize sentry package name
> Hmm, wasn't there a reason we did it this way? I vaguely remember talking t
I think the conversation is to normalize it when repackage Sentry. https://gerrit.cloudera.org/#/c/11347/2/build-support/run_dist_test.py@153. Though I don't see repackage is a must have (but a nice to have) for now.
--
To view, visit http://gerrit.cloudera.org:8080/13203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic17375e2bb1a2b0993224ebeaaabee2df8bb259f
Gerrit-Change-Number: 13203
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 May 2019 00:41:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] Normalize sentry package name
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13203 )
Change subject: Normalize sentry package name
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13203/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13203/1//COMMIT_MSG@7
PS1, Line 7: Normalize sentry package name
Hmm, wasn't there a reason we did it this way? I vaguely remember talking to Dan about normalizing the names over a past code review.
--
To view, visit http://gerrit.cloudera.org:8080/13203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic17375e2bb1a2b0993224ebeaaabee2df8bb259f
Gerrit-Change-Number: 13203
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 30 Apr 2019 23:50:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] Normalize sentry package name
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13203 )
Change subject: Normalize sentry package name
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic17375e2bb1a2b0993224ebeaaabee2df8bb259f
Gerrit-Change-Number: 13203
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 May 2019 00:42:25 +0000
Gerrit-HasComments: No
[kudu-CR] Normalize sentry package name
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13203 )
Change subject: Normalize sentry package name
......................................................................
Normalize sentry package name
This strips the 'apache' prefix and 'bin' suffix from the thirdparty
tarball package, which brings it inline with the hadoop package naming.
Change-Id: Ic17375e2bb1a2b0993224ebeaaabee2df8bb259f
Reviewed-on: http://gerrit.cloudera.org:8080/13203
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M build-support/run_dist_test.py
M thirdparty/vars.sh
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Hao Hao: Verified
Andrew Wong: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic17375e2bb1a2b0993224ebeaaabee2df8bb259f
Gerrit-Change-Number: 13203
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Normalize sentry package name
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has removed a vote on this change.
Change subject: Normalize sentry package name
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic17375e2bb1a2b0993224ebeaaabee2df8bb259f
Gerrit-Change-Number: 13203
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Normalize sentry package name
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13203 )
Change subject: Normalize sentry package name
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic17375e2bb1a2b0993224ebeaaabee2df8bb259f
Gerrit-Change-Number: 13203
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 May 2019 00:42:08 +0000
Gerrit-HasComments: No