You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/01 20:08:42 UTC
[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #4870: API: Add a scan for changes
aokolnychyi commented on code in PR #4870:
URL: https://github.com/apache/iceberg/pull/4870#discussion_r887255666
##########
api/src/main/java/org/apache/iceberg/ChangeScan.java:
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg;
+
+import java.util.List;
+
+/**
+ * API for configuring a table scan for changes.
+ */
+public interface ChangeScan extends Scan<TableScan> {
+ /**
+ * Instructs this scan to look for changes starting from a particular snapshot (inclusive).
+ * <p>
+ * If the start snapshot is not configured, it is defaulted to the oldest ancestor
+ * of the end snapshot (inclusive).
+ *
+ * @param fromSnapshotId the start snapshot ID (inclusive)
+ * @return this for method chaining
+ */
+ ChangeScan fromSnapshotInclusive(long fromSnapshotId);
+
+ /**
+ * Instructs this scan to look for changes starting from a particular snapshot (exclusive).
+ * <p>
+ * If the start snapshot is not configured, it is defaulted to the oldest ancestor
+ * of the end snapshot (inclusive).
+ *
+ * @param fromSnapshotId the start snapshot ID (exclusive)
+ * @return this for method chaining
+ */
+ ChangeScan fromSnapshotExclusive(long fromSnapshotId);
+
+ /**
+ * Instructs this scan to look for changes up to a particular snapshot (inclusive).
+ * <p>
+ * If the end snapshot is not configured, it is defaulted to the current table snapshot (inclusive).
+ *
+ * @param toSnapshotId the end snapshot ID (inclusive)
+ * @return this for method chaining
+ */
+ ChangeScan toSnapshot(long toSnapshotId);
+
+ /**
+ * Instructs this scan to assign equality delete files to matching data files,
+ * which may be expensive if equality deletes are not scoped to particular partitions.
+ *
+ * @return this for method chaining
+ */
+ ChangeScan resolveEqualityDeletes();
+
+ /**
+ * Plans scan tasks for all file changes.
+ *
+ * @return this for method chaining
+ */
+ FileChangeIndex planFiles();
Review Comment:
I reconsidered this point as I am thinking of adapting the readers instead.
##########
api/src/main/java/org/apache/iceberg/ChangeScan.java:
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg;
+
+import java.util.List;
+
+/**
+ * API for configuring a table scan for changes.
+ */
+public interface ChangeScan extends Scan<TableScan> {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org