You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Gabriela Gibson <ga...@gmail.com> on 2013/04/30 17:07:47 UTC

[PATCH] get-deps.sh zlib version number and file type changed

[[[

Update the zlib HTTP link to fetch http://zlib.net/zlib-1.2.8.tar.gz

* subversion/build/get-deps.sh:
   ():  Update zlib version number.
   (get_zlib): Modify tar command and file extension.

]]]

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Ben Reser <be...@reser.org>.
On Tue, Apr 30, 2013 at 10:11 AM, Branko Čibej <br...@wandisco.com> wrote:
> +1, and I think this should go into 1.8 as well as trunk.

It will, part of our release process is to check that get-deps.sh
works now, and given that the zlib folks remove the link we use with
every version, we would have found this then.

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Branko Čibej <br...@wandisco.com>.
On 30.04.2013 17:07, Gabriela Gibson wrote:
> [[[
>
> Update the zlib HTTP link to fetch http://zlib.net/zlib-1.2.8.tar.gz
>
> * subversion/build/get-deps.sh:
>   ():  Update zlib version number.
>   (get_zlib): Modify tar command and file extension.
>
> ]]]

+1, and I think this should go into 1.8 as well as trunk.

-- Brane

-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com


Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Daniel Shahaf <da...@elego.de>.
Ben Reser wrote on Fri, May 03, 2013 at 22:41:37 -0700:
> On Fri, May 3, 2013 at 10:05 PM, Daniel Shahaf <da...@elego.de> wrote:
> > The same warning applies equally well to configure.ac and really to any
> > sh code we write for users to run.  I could see it lifted into the
> > coding style guidelines part of HACKING, for example.
> 
> Noted and adding to my todo list.

:-)

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Ben Reser <be...@reser.org>.
On Fri, May 3, 2013 at 10:05 PM, Daniel Shahaf <da...@elego.de> wrote:
> The same warning applies equally well to configure.ac and really to any
> sh code we write for users to run.  I could see it lifted into the
> coding style guidelines part of HACKING, for example.

Noted and adding to my todo list.

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Daniel Shahaf <da...@elego.de>.
Ben Reser wrote on Fri, May 03, 2013 at 13:00:10 -0700:
> On Wed, May 1, 2013 at 8:07 AM, Gabriela Gibson
> <ga...@gmail.com> wrote:
> > Should this note be a comment in get-deps.sh?
> 
> Done in r1478951.

The same warning applies equally well to configure.ac and really to any
sh code we write for users to run.  I could see it lifted into the
coding style guidelines part of HACKING, for example.

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Ben Reser <be...@reser.org>.
On Wed, May 1, 2013 at 8:07 AM, Gabriela Gibson
<ga...@gmail.com> wrote:
> Should this note be a comment in get-deps.sh?

Done in r1478951.

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Gabriela Gibson <ga...@gmail.com>.
On 30/04/13 18:27, Ben Reser wrote:

> 1) Need to avoid using GNU tar options on this.  Just like we don't
> use the j option to tar to deal with bzip2 we can't use the z option
> to deal with gzip.

Should this note be a comment in get-deps.sh?




Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Ben Reser <be...@reser.org>.
On Tue, Apr 30, 2013 at 12:38 PM, Daniel Shahaf <da...@elego.de> wrote:
> I figured we'd either release 1.6.22 without a -deps tarball, or
> resurrect the script from svn history.

We could indeed do that, it's come up before.

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Daniel Shahaf <da...@elego.de>.
Ben Reser wrote on Tue, Apr 30, 2013 at 12:36:03 -0700:
> On Tue, Apr 30, 2013 at 12:26 PM, Daniel Shahaf <da...@elego.de> wrote:
> >> tools/dist/make-deps-tarball.sh:ZLIB=zlib-1.2.7
> >
> > Script only used for 1.6 and earlier; we can probably remove the script
> > from HEAD.
> 
> Yes, but it needs to stay until we're sure we're not releasing any
> further 1.6.x release since we use the tools from trunk.

I figured we'd either release 1.6.22 without a -deps tarball, or
resurrect the script from svn history.

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Ben Reser <be...@reser.org>.
On Tue, Apr 30, 2013 at 12:26 PM, Daniel Shahaf <da...@elego.de> wrote:
> FWIW, I did find two references:

Ahh I did miss these.

>> tools/dev/windows-build/Makefile:ZLIBVER=1.2.3
>
> No opinion as I don't build on windows any more, but CCing jcorvel.
> (Johan: the question is whether we want to update the zlib version used
> by windows-build/Makefile.)

Yeah not sure what the status of that windows-build setup is.

>> tools/dist/make-deps-tarball.sh:ZLIB=zlib-1.2.7
>
> Script only used for 1.6 and earlier; we can probably remove the script
> from HEAD.

Yes, but it needs to stay until we're sure we're not releasing any
further 1.6.x release since we use the tools from trunk.

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Johan Corveleyn <jc...@gmail.com>.
On Tue, Apr 30, 2013 at 9:26 PM, Daniel Shahaf <da...@elego.de> wrote:
> FWIW, I did find two references:
>
>> tools/dev/windows-build/Makefile:ZLIBVER=1.2.3
>
> No opinion as I don't build on windows any more, but CCing jcorvel.
> (Johan: the question is whether we want to update the zlib version used
> by windows-build/Makefile.)

Yeah, no opinion here either. I started out with (a copy of) that
Makefile when I first tried to get svn built on Windows. I still use
my own local copy (which I copy around every time I start building a
new checkout/tarball), so I don't keep a close eye on the checked-in
version.

Anyway, I consider deps versions in there not actually "recommended
versions", but more "examples". When I start a new build, I usually
check what the latest versions are that I have already laying around
of those deps, and sometimes I do a quick google / website check to
see if one of them needs updating.

--
Johan

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Daniel Shahaf <da...@elego.de>.
Ben Reser wrote on Tue, Apr 30, 2013 at 12:03:29 -0700:
> On Tue, Apr 30, 2013 at 10:52 AM, Daniel Shahaf <da...@elego.de> wrote:
> > 4) Update INSTALL, README, build/ac-macros/zlib.m4, and wherever
> > else we mention what the recommended zlib version is
> 
> Not sure where that's from, but we don't recommend a version of zlib.
> The closest we come to that is the Windows docs say you need zlib 1.2
> or newer.

I stand corrected.

FWIW, I did find two references:

> tools/dev/windows-build/Makefile:ZLIBVER=1.2.3

No opinion as I don't build on windows any more, but CCing jcorvel.
(Johan: the question is whether we want to update the zlib version used
by windows-build/Makefile.)

> tools/dist/make-deps-tarball.sh:ZLIB=zlib-1.2.7

Script only used for 1.6 and earlier; we can probably remove the script
from HEAD.

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Ben Reser <be...@reser.org>.
On Tue, Apr 30, 2013 at 10:52 AM, Daniel Shahaf <da...@elego.de> wrote:
> 4) Update INSTALL, README, build/ac-macros/zlib.m4, and wherever
> else we mention what the recommended zlib version is

Not sure where that's from, but we don't recommend a version of zlib.
The closest we come to that is the Windows docs say you need zlib 1.2
or newer.

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Daniel Shahaf <da...@elego.de>.
Ben Reser wrote on Tue, Apr 30, 2013 at 10:27:18 -0700:
> On Tue, Apr 30, 2013 at 8:07 AM, Gabriela Gibson
> <ga...@gmail.com> wrote:
> > [[[
> >
> > Update the zlib HTTP link to fetch http://zlib.net/zlib-1.2.8.tar.gz
> >
> > * subversion/build/get-deps.sh:
> >   ():  Update zlib version number.
> >   (get_zlib): Modify tar command and file extension.
> >
> > ]]]
> 
> Applied in r1477730 with some changes.

4) Update INSTALL, README, build/ac-macros/zlib.m4, and wherever
else we mention what the recommended zlib version is

?

Re: [PATCH] get-deps.sh zlib version number and file type changed

Posted by Ben Reser <be...@reser.org>.
On Tue, Apr 30, 2013 at 8:07 AM, Gabriela Gibson
<ga...@gmail.com> wrote:
> [[[
>
> Update the zlib HTTP link to fetch http://zlib.net/zlib-1.2.8.tar.gz
>
> * subversion/build/get-deps.sh:
>   ():  Update zlib version number.
>   (get_zlib): Modify tar command and file extension.
>
> ]]]

Applied in r1477730 with some changes.

1) Need to avoid using GNU tar options on this.  Just like we don't
use the j option to tar to deal with bzip2 we can't use the z option
to deal with gzip.

2) Fixed the file path.

3) Added the ZLIB symbol to the "Update zlib version number" line.