You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "squah-confluent (via GitHub)" <gi...@apache.org> on 2026/03/10 12:20:50 UTC
[PR] KAFKA-20269: Refactor assignment update for delayed consumer assignments [kafka]
squah-confluent opened a new pull request, #21694:
URL: https://github.com/apache/kafka/pull/21694
Refactor the consumer target assignment update method to return both
the target assignment epoch and target assignment. When assignment
batching or assignment offload are implemented, the target assignment
update method may return the last target assignment, depending on
timings and the group coordinator config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20269: Refactor assignment update for delayed consumer assignments [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #21694:
URL: https://github.com/apache/kafka/pull/21694#discussion_r2911472491
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -276,6 +275,21 @@ private static class UpdateSubscriptionMetadataResult {
}
}
+ private record UpdateTargetAssignmentResult<T>(
+ int targetAssignmentEpoch,
+ T targetAssignment
+ ) {
+ private static UpdateTargetAssignmentResult<Assignment> fromLastTargetAssignment(
Review Comment:
nit: Given that we use it only once, I would inline the logic to keep all the logic in the core method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20269: Refactor assignment update for delayed consumer assignments [kafka]
Posted by "squah-confluent (via GitHub)" <gi...@apache.org>.
squah-confluent commented on code in PR #21694:
URL: https://github.com/apache/kafka/pull/21694#discussion_r2911487155
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -276,6 +275,21 @@ private static class UpdateSubscriptionMetadataResult {
}
}
+ private record UpdateTargetAssignmentResult<T>(
+ int targetAssignmentEpoch,
+ T targetAssignment
+ ) {
+ private static UpdateTargetAssignmentResult<Assignment> fromLastTargetAssignment(
Review Comment:
It will be used multiple times once batching and offload are implemented. It's needed when there is an in-flight offloaded assignment, the assignment interval has not elapsed and when starting an offloaded assignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20269 [1/N]: Refactor assignment update for delayed consumer assignments [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #21694:
URL: https://github.com/apache/kafka/pull/21694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20269: Refactor assignment update for delayed consumer assignments [kafka]
Posted by "squah-confluent (via GitHub)" <gi...@apache.org>.
squah-confluent commented on code in PR #21694:
URL: https://github.com/apache/kafka/pull/21694#discussion_r2911487155
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -276,6 +275,21 @@ private static class UpdateSubscriptionMetadataResult {
}
}
+ private record UpdateTargetAssignmentResult<T>(
+ int targetAssignmentEpoch,
+ T targetAssignment
+ ) {
+ private static UpdateTargetAssignmentResult<Assignment> fromLastTargetAssignment(
Review Comment:
It will be used multiple times once batching and offload are implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org