[jira] Commented: (SOLR-410) Audit the new ResponseBuilder class

["Yonik Seeley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541938 ] 

Yonik Seeley commented on SOLR-410:
-----------------------------------

Ongoing review + changes also applies to search components in general (SearchComponent class, etc).

I think distributed search is core enough that support should be built into SearchComponent, and anyone should be able to make their SearchComponent that works in both a distributed or non-distributed setup.

One implication of hooks meant for distributed search is that the number of times a component is called may be undefined (when merging results, one may find they need to make another request for more information).

> Audit the new ResponseBuilder class
> -----------------------------------
>
>                 Key: SOLR-410
>                 URL: https://issues.apache.org/jira/browse/SOLR-410
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>             Fix For: 1.3
>
>
> In SOLR-281, we added a ResponseBuilder class to help search components communicate with one another.  Before releasing 1.3, we need to make sure this is the best design and that it is an interface we can support in the future.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Commented: (SOLR-410) Audit the new ResponseBuilder class

[Yonik Seeley <yo...@apache.org>]

On Nov 12, 2007 3:34 PM, Ryan McKinley <ry...@gmail.com> wrote:
> What is your thought on resolving vs keeping open issues that need
> further review/changes?

If we know that changes need to be made (as is the case here), I think
it's OK to leave it open.
Committing things before they are "done" shouldn't become too much of
a regular practice... it's just that some of these issues are so
invasive that they block everything else anyway.

-Yonik

Re: [jira] Commented: (SOLR-410) Audit the new ResponseBuilder class

[Ryan McKinley <ry...@gmail.com>]

> 
> Yonik Seeley commented on SOLR-410:
> -----------------------------------
> 
> Ongoing review + changes also applies to search components in general (SearchComponent class, etc).
> 

Yes, of course!

What is your thought on resolving vs keeping open issues that need 
further review/changes?

Keeping SOLR-215 open I think caused more confusion then anything.

ryan