You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Gijs Kunze (JIRA)" <ji...@apache.org> on 2009/06/23 15:39:07 UTC
[jira] Created: (SOLR-1240) Numerical Range faceting
Numerical Range faceting
------------------------
Key: SOLR-1240
URL: https://issues.apache.org/jira/browse/SOLR-1240
Project: Solr
Issue Type: New Feature
Components: search
Reporter: Gijs Kunze
Priority: Minor
For faceting numerical ranges using many facet.query query arguments leads to unmanageably large queries as the fields you facet over increase. Adding the same faceting parameter for numbers which already exists for dates should fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1240) Numerical Range faceting
Posted by "Gijs Kunze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748374#action_12748374 ]
Gijs Kunze commented on SOLR-1240:
----------------------------------
I'd love to add it as a separate component, maybe moving date faceting to the same component since date faceting and numerical faceting is practically identical. But as I said, I'm not really that proficient in Java, haven't done any real Java programming since Swing was still new. So I'm not really sure I'm up to the task.
Looking at SOLR-792 as an example I looked at converting my patch but I think some re-factoring on the side of SimpleFacets might be in order first. My patch makes use of the parseParams method (which handles tagging/exclusion local parameters) and I can't see how to cleanly make use of that functionality from a separate component. I could copy the method and the member variables it manipulates to the component but I'd rather not perpetrate that code maintenance no-no.
> Numerical Range faceting
> ------------------------
>
> Key: SOLR-1240
> URL: https://issues.apache.org/jira/browse/SOLR-1240
> Project: Solr
> Issue Type: New Feature
> Components: search
> Reporter: Gijs Kunze
> Priority: Minor
> Attachments: SOLR-1240.patch
>
>
> For faceting numerical ranges using many facet.query query arguments leads to unmanageably large queries as the fields you facet over increase. Adding the same faceting parameter for numbers which already exists for dates should fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SOLR-1240) Numerical Range faceting
Posted by "Gijs Kunze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748374#action_12748374 ]
Gijs Kunze edited comment on SOLR-1240 at 9/2/09 2:25 AM:
----------------------------------------------------------
I'd love to add it as a separate component, maybe moving date faceting to the same component since date faceting and numerical faceting are practically identical. But as I said, I'm not really that proficient in Java, haven't done any real Java programming since Swing was still new. So I'm not really sure I'm up to the task.
Looking at SOLR-792 as an example I looked at converting my patch but I think some re-factoring on the side of SimpleFacets might be in order first. My patch makes use of the parseParams method (which handles tagging/exclusion local parameters) and I can't see how to cleanly make use of that functionality from a separate component. I could copy the method and the member variables it manipulates to the component but I'd rather not perpetrate that code maintenance no-no.
was (Author: gwkunze):
I'd love to add it as a separate component, maybe moving date faceting to the same component since date faceting and numerical faceting is practically identical. But as I said, I'm not really that proficient in Java, haven't done any real Java programming since Swing was still new. So I'm not really sure I'm up to the task.
Looking at SOLR-792 as an example I looked at converting my patch but I think some re-factoring on the side of SimpleFacets might be in order first. My patch makes use of the parseParams method (which handles tagging/exclusion local parameters) and I can't see how to cleanly make use of that functionality from a separate component. I could copy the method and the member variables it manipulates to the component but I'd rather not perpetrate that code maintenance no-no.
> Numerical Range faceting
> ------------------------
>
> Key: SOLR-1240
> URL: https://issues.apache.org/jira/browse/SOLR-1240
> Project: Solr
> Issue Type: New Feature
> Components: search
> Reporter: Gijs Kunze
> Priority: Minor
> Attachments: SOLR-1240.patch
>
>
> For faceting numerical ranges using many facet.query query arguments leads to unmanageably large queries as the fields you facet over increase. Adding the same faceting parameter for numbers which already exists for dates should fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1240) Numerical Range faceting
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748350#action_12748350 ]
Erik Hatcher commented on SOLR-1240:
------------------------------------
Let's please stop adding stuff to SimpleFacets. See SOLR-792 for an approach of adding additional faceting components instead of overloading the now not-so-SimpleFacets.
> Numerical Range faceting
> ------------------------
>
> Key: SOLR-1240
> URL: https://issues.apache.org/jira/browse/SOLR-1240
> Project: Solr
> Issue Type: New Feature
> Components: search
> Reporter: Gijs Kunze
> Priority: Minor
> Attachments: SOLR-1240.patch
>
>
> For faceting numerical ranges using many facet.query query arguments leads to unmanageably large queries as the fields you facet over increase. Adding the same faceting parameter for numbers which already exists for dates should fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1240) Numerical Range faceting
Posted by "Gijs Kunze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gijs Kunze updated SOLR-1240:
-----------------------------
Attachment: SOLR-1240.patch
My first try, my Java skill are not that great but it seems to work.
Test org.apache.solr.TestDistributedSearch seems to fail with this patch, I couldn't find out why exactly, my dev environment is not setup for Java debugging. I'm hoping it's simply because an extra lst tag is included in the facet results.
> Numerical Range faceting
> ------------------------
>
> Key: SOLR-1240
> URL: https://issues.apache.org/jira/browse/SOLR-1240
> Project: Solr
> Issue Type: New Feature
> Components: search
> Reporter: Gijs Kunze
> Priority: Minor
> Attachments: SOLR-1240.patch
>
>
> For faceting numerical ranges using many facet.query query arguments leads to unmanageably large queries as the fields you facet over increase. Adding the same faceting parameter for numbers which already exists for dates should fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.