You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/02 22:37:22 UTC

[GitHub] [beam] ihji commented on a change in pull request #11018: [BEAM-9415] fix postcommit xvr tests

ihji commented on a change in pull request #11018: [BEAM-9415] fix postcommit xvr tests
URL: https://github.com/apache/beam/pull/11018#discussion_r386693638
 
 

 ##########
 File path: sdks/java/testing/expansion-service/build.gradle
 ##########
 @@ -28,7 +28,7 @@ dependencies {
   compile project(path: ":runners:core-construction-java")
   compile project(path: ":sdks:java:io:parquet")
   compile project(path: ":sdks:java:core", configuration: "shadow")
-  provided library.java.hadoop_client
+  testRuntime library.java.hadoop_client
 
 Review comment:
   Yes. test expansion service jar is also used for SDK container dependency. hadoop client library should be included in the shadow jar.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services