You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/06/28 08:55:39 UTC

[GitHub] flink issue #2171: FLINK-3319 Added the or function to the CEP pattern

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2171
  
    Thanks for cleaning up the PR @thormanrd. 
    
    Could we also try to get rid of the merge commits? We actually always rebase in the Flink community and never merge branches. Furthermore, it seems as if you've transformed the `testTimeoutHandling` into another test case. This should be corrected.
    
    What I meant with the `OrFilterFunctionTest` is an explicit test of the `OrFilterFunction` and not an implicit test where it is embedded into a CEP program.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---