You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2005/03/02 20:50:20 UTC
DO NOT REPLY [Bug 33816] New: -
Unkosher lines in build.xml
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=33816>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=33816
Summary: Unkosher lines in build.xml
Product: Tomcat 5
Version: 5.5.7
Platform: PC
OS/Version: Linux
Status: NEW
Severity: trivial
Priority: P2
Component: Unknown
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: d.tonhofer@m-plify.com
Looks like jakarta-tomcat-5.5.7-src/jakarta-tomcat-5/build.xml
specifies a parameter called 'destfile' for target 'downloadgz'.
However, the definition of 'downloadgz' is such that said parameter is never used:
<target name="downloadgz" unless="exist" depends="setproxy,testexist">
<!-- Download and extract the package -->
<get src="${sourcefile}" dest="${base.path}/file.tar.gz" />
<gunzip src="${base.path}/file.tar.gz" dest="${base.path}/file.tar"/>
<untar src="${base.path}/file.tar" dest="${base.path}"/>
<delete file="${base.path}/file.tar"/>
<delete file="${base.path}/file.tar.gz"/>
</target>
So we can rip out the 'destfiles':
--- /usr/local/tarballs/jakarta-tomcat-5.5.7-src/jakarta-tomcat-5/build.xml.bak
2005-03-02 20:42:30.009017936 +0100
+++ /usr/local/tarballs/jakarta-tomcat-5.5.7-src/jakarta-tomcat-5/build.xml
2005-03-02 20:47:08.198726672 +0100
@@ -601,17 +601,14 @@
<!-- <antcall target="build-commons-modeler" /> -->
<!-- <antcall target="build-commons-daemon" /> -->
- <antcall target="downloadgz">
+ <antcall target="downloadgz">
<param name="sourcefile" value="${commons-collections-src.loc}"/>
- <param name="destfile" value="${tomcat-dbcp.jar}" />
</antcall>
- <antcall target="downloadgz">
+ <antcall target="downloadgz">
<param name="sourcefile" value="${commons-pool-src.loc}"/>
- <param name="destfile" value="${tomcat-dbcp.jar}" />
</antcall>
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-dbcp-src.loc}"/>
- <param name="destfile" value="${tomcat-dbcp.jar}" />
</antcall>
<antcall target="build-tomcat-dbcp" />
@@ -1714,48 +1711,39 @@
<!-- Downdown any sub package or tools needed. -->
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-beanutils.loc}"/>
- <param name="destfile" value="${commons-beanutils.jar}"/>
</antcall>
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-collections.loc}"/>
- <param name="destfile" value="${commons-collections.jar}"/>
</antcall>
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-el.loc}"/>
- <param name="destfile" value="${commons-el.jar}"/>
</antcall>
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-logging.loc}"/>
- <param name="destfile" value="${commons-logging.jar}"/>
</antcall>
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-modeler.loc}"/>
- <param name="destfile" value="${commons-modeler.jar}"/>
</antcall>
<antcall target="downloadgz">
<param name="sourcefile" value="${log4j.loc}"/>
- <param name="destfile" value="${log4j.jar}"/>
</antcall>
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-digester.loc}"/>
- <param name="destfile" value="${commons-digester.jar}"/>
</antcall>
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-fileupload.loc}"/>
- <param name="destfile" value="${commons-fileupload.jar}"/>
</antcall>
<antcall target="downloadgz">
<!-- xerces2 brings 2 files, test for one of them -->
<param name="sourcefile" value="${xerces.loc}"/>
- <param name="destfile" value="${xml-apis.jar}"/>
</antcall>
<antcall target="downloadzip">
@@ -1772,25 +1760,20 @@
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-launcher.loc}"/>
- <param name="destfile" value="${commons-launcher.jar}"/>
</antcall>
<!--
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-pool.loc}"/>
- <param name="destfile" value="${commons-pool.jar}"/>
</antcall>
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-dbcp.loc}"/>
- <param name="destfile" value="${commons-dbcp.jar}"/>
- <param name="destdir" value="${base.path}"/>
</antcall>
-->
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-httpclient.loc}"/>
- <param name="destfile" value="${commons-httpclient.jar}"/>
</antcall>
<antcall target="downloadfile">
@@ -1801,22 +1784,18 @@
<antcall target="downloadgz">
<param name="sourcefile" value="${struts.loc}"/>
- <param name="destfile" value="${struts.jar}"/>
</antcall>
<antcall target="downloadgz">
<param name="sourcefile" value="${commons-daemon.loc}"/>
- <param name="destfile" value="${commons-daemon.jar}"/>
</antcall>
<antcall target="downloadgz">
<param name="sourcefile" value="${jaxen.loc}"/>
- <param name="destfile" value="${jaxen.jar}"/>
</antcall>
<antcall target="downloadgz">
<param name="sourcefile" value="${saxpath.loc}"/>
- <param name="destfile" value="${saxpath.jar}"/>
</antcall>
<!-- Build the dependencies that are not yet released -->
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org