You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/06/30 21:48:03 UTC

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one 

Jean-Daniel Cryans has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3544

Change subject: [java client] Make integration tests run in kudu-client, fix one
......................................................................

[java client] Make integration tests run in kudu-client, fix one

Change-Id: I00818a4463a1045e5299568566954b441e708946
---
M java/kudu-client/pom.xml
M java/kudu-client/src/test/java/org/kududb/client/ITClient.java
2 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/3544/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I00818a4463a1045e5299568566954b441e708946
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: [java client] Make integration tests run in kudu-client, fix one
......................................................................


[java client] Make integration tests run in kudu-client, fix one

Change-Id: I00818a4463a1045e5299568566954b441e708946
Reviewed-on: http://gerrit.cloudera.org:8080/3544
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-client/pom.xml
M java/kudu-client/src/test/java/org/kududb/client/ITClient.java
2 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, but someone else must approve
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I00818a4463a1045e5299568566954b441e708946
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: [java client] Make integration tests run in kudu-client, fix one
......................................................................


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00818a4463a1045e5299568566954b441e708946
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: [java client] Make integration tests run in kudu-client, fix one
......................................................................


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2125/

-- 
To view, visit http://gerrit.cloudera.org:8080/3544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00818a4463a1045e5299568566954b441e708946
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: [java client] Make integration tests run in kudu-client, fix one
......................................................................


Patch Set 1:

(1 comment)

Why wasn't this already running? Was the first implementation pushed disabled intentionally? I can't remember...

http://gerrit.cloudera.org:8080/#/c/3544/1/java/kudu-client/pom.xml
File java/kudu-client/pom.xml:

PS1, Line 262:                 <groupId>org.apache.maven.plugins</groupId>
             :                 <artifactId>maven-failsafe-plugin</artifactId>
Nit: fix the indentation?


-- 
To view, visit http://gerrit.cloudera.org:8080/3544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00818a4463a1045e5299568566954b441e708946
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has uploaded a new patch set (#2).

Change subject: [java client] Make integration tests run in kudu-client, fix one
......................................................................

[java client] Make integration tests run in kudu-client, fix one

Change-Id: I00818a4463a1045e5299568566954b441e708946
---
M java/kudu-client/pom.xml
M java/kudu-client/src/test/java/org/kududb/client/ITClient.java
2 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/3544/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00818a4463a1045e5299568566954b441e708946
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: [java client] Make integration tests run in kudu-client, fix one
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00818a4463a1045e5299568566954b441e708946
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: [java client] Make integration tests run in kudu-client, fix one
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2124/

-- 
To view, visit http://gerrit.cloudera.org:8080/3544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00818a4463a1045e5299568566954b441e708946
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: [java client] Make integration tests run in kudu-client, fix one
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3544/1/java/kudu-client/pom.xml
File java/kudu-client/pom.xml:

PS1, Line 262:                 <groupId>org.apache.maven.plugins</groupId>
             :                 <artifactId>maven-failsafe-plugin</artifactId>
> Nit: fix the indentation?
Ugh looks like our files aren't all indented the same. Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/3544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00818a4463a1045e5299568566954b441e708946
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes