You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@asterixdb.apache.org by abdullah alamoudi <am...@apache.org> on 2015/11/09 18:22:43 UTC
Code Review Checklist
Hi Dev,
Just wanted to share with you that our code review checklist has been
uploaded to our wiki. Check it out at
https://cwiki.apache.org/confluence/display/ASTERIXDB/Code+Review+Checklist
, adhere to it and use it to make sure the code you're submitting/reviewing
meets our minimum standard.
Also, feel free to contribute to the list, improve it, and if you can
automate some of the items in the list, that would be even better.
Cheers,
Abdullah.
Re: Code Review Checklist
Posted by Till Westmann <ti...@apache.org>.
I can’t find this user on https://cwiki.apache.org/ … :(
On 9 Nov 2015, at 10:30, Steven Jacobs wrote:
> sjaco002@apache.org
>
> Steven
>
> On Mon, Nov 9, 2015 at 9:39 AM, Till Westmann <ti...@apache.org>
> wrote:
>
>> Steven, I just tried to give you access, but I can’t find your user
>> name
>> in the Wiki.
>> Could you tell me your user name?
>>
>> Thanks,
>> Till
>>
>>
>> On 9 Nov 2015, at 9:36, Till Westmann wrote:
>>
>> Yes, there’s a way around this, you need to either get the right
>> access
>>> rights (which I can do) or log in (if you already have them).
>>> However, I the question is, if we really want that. As it is a
>>> shared
>>> resource, the checkmarks would be the same ones for everybody.
>>> Do you see a use for that?
>>>
>>> Cheers,
>>> Till
>>>
>>> On 9 Nov 2015, at 9:28, Steven Jacobs wrote:
>>>
>>> Note- the checkboxes on this page are actually "checkable" and
>>> display an
>>>> error when you click on them. Is there a way around this?
>>>> Steven
>>>>
>>>> On Mon, Nov 9, 2015 at 9:22 AM, abdullah alamoudi
>>>> <am...@apache.org>
>>>> wrote:
>>>>
>>>> Hi Dev,
>>>>> Just wanted to share with you that our code review checklist has
>>>>> been
>>>>> uploaded to our wiki. Check it out at
>>>>>
>>>>> https://cwiki.apache.org/confluence/display/ASTERIXDB/Code+Review+Checklist
>>>>> , adhere to it and use it to make sure the code you're
>>>>> submitting/reviewing
>>>>> meets our minimum standard.
>>>>>
>>>>> Also, feel free to contribute to the list, improve it, and if you
>>>>> can
>>>>> automate some of the items in the list, that would be even better.
>>>>>
>>>>> Cheers,
>>>>> Abdullah.
>>>>>
>>>>>
Re: Code Review Checklist
Posted by Steven Jacobs <sj...@ucr.edu>.
sjaco002@apache.org
Steven
On Mon, Nov 9, 2015 at 9:39 AM, Till Westmann <ti...@apache.org> wrote:
> Steven, I just tried to give you access, but I can’t find your user name
> in the Wiki.
> Could you tell me your user name?
>
> Thanks,
> Till
>
>
> On 9 Nov 2015, at 9:36, Till Westmann wrote:
>
> Yes, there’s a way around this, you need to either get the right access
>> rights (which I can do) or log in (if you already have them).
>> However, I the question is, if we really want that. As it is a shared
>> resource, the checkmarks would be the same ones for everybody.
>> Do you see a use for that?
>>
>> Cheers,
>> Till
>>
>> On 9 Nov 2015, at 9:28, Steven Jacobs wrote:
>>
>> Note- the checkboxes on this page are actually "checkable" and display an
>>> error when you click on them. Is there a way around this?
>>> Steven
>>>
>>> On Mon, Nov 9, 2015 at 9:22 AM, abdullah alamoudi <am...@apache.org>
>>> wrote:
>>>
>>> Hi Dev,
>>>> Just wanted to share with you that our code review checklist has been
>>>> uploaded to our wiki. Check it out at
>>>>
>>>> https://cwiki.apache.org/confluence/display/ASTERIXDB/Code+Review+Checklist
>>>> , adhere to it and use it to make sure the code you're
>>>> submitting/reviewing
>>>> meets our minimum standard.
>>>>
>>>> Also, feel free to contribute to the list, improve it, and if you can
>>>> automate some of the items in the list, that would be even better.
>>>>
>>>> Cheers,
>>>> Abdullah.
>>>>
>>>>
Re: Code Review Checklist
Posted by Till Westmann <ti...@apache.org>.
Steven, I just tried to give you access, but I can’t find your user
name in the Wiki.
Could you tell me your user name?
Thanks,
Till
On 9 Nov 2015, at 9:36, Till Westmann wrote:
> Yes, there’s a way around this, you need to either get the right
> access rights (which I can do) or log in (if you already have them).
> However, I the question is, if we really want that. As it is a shared
> resource, the checkmarks would be the same ones for everybody.
> Do you see a use for that?
>
> Cheers,
> Till
>
> On 9 Nov 2015, at 9:28, Steven Jacobs wrote:
>
>> Note- the checkboxes on this page are actually "checkable" and
>> display an
>> error when you click on them. Is there a way around this?
>> Steven
>>
>> On Mon, Nov 9, 2015 at 9:22 AM, abdullah alamoudi <am...@apache.org>
>> wrote:
>>
>>> Hi Dev,
>>> Just wanted to share with you that our code review checklist has
>>> been
>>> uploaded to our wiki. Check it out at
>>> https://cwiki.apache.org/confluence/display/ASTERIXDB/Code+Review+Checklist
>>> , adhere to it and use it to make sure the code you're
>>> submitting/reviewing
>>> meets our minimum standard.
>>>
>>> Also, feel free to contribute to the list, improve it, and if you
>>> can
>>> automate some of the items in the list, that would be even better.
>>>
>>> Cheers,
>>> Abdullah.
>>>
Re: Code Review Checklist
Posted by Till Westmann <ti...@apache.org>.
Yes, there’s a way around this, you need to either get the right
access rights (which I can do) or log in (if you already have them).
However, I the question is, if we really want that. As it is a shared
resource, the checkmarks would be the same ones for everybody.
Do you see a use for that?
Cheers,
Till
On 9 Nov 2015, at 9:28, Steven Jacobs wrote:
> Note- the checkboxes on this page are actually "checkable" and display
> an
> error when you click on them. Is there a way around this?
> Steven
>
> On Mon, Nov 9, 2015 at 9:22 AM, abdullah alamoudi <am...@apache.org>
> wrote:
>
>> Hi Dev,
>> Just wanted to share with you that our code review checklist has been
>> uploaded to our wiki. Check it out at
>> https://cwiki.apache.org/confluence/display/ASTERIXDB/Code+Review+Checklist
>> , adhere to it and use it to make sure the code you're
>> submitting/reviewing
>> meets our minimum standard.
>>
>> Also, feel free to contribute to the list, improve it, and if you can
>> automate some of the items in the list, that would be even better.
>>
>> Cheers,
>> Abdullah.
>>
Re: Code Review Checklist
Posted by Steven Jacobs <sj...@ucr.edu>.
Note- the checkboxes on this page are actually "checkable" and display an
error when you click on them. Is there a way around this?
Steven
On Mon, Nov 9, 2015 at 9:22 AM, abdullah alamoudi <am...@apache.org> wrote:
> Hi Dev,
> Just wanted to share with you that our code review checklist has been
> uploaded to our wiki. Check it out at
> https://cwiki.apache.org/confluence/display/ASTERIXDB/Code+Review+Checklist
> , adhere to it and use it to make sure the code you're submitting/reviewing
> meets our minimum standard.
>
> Also, feel free to contribute to the list, improve it, and if you can
> automate some of the items in the list, that would be even better.
>
> Cheers,
> Abdullah.
>
Re: Code Review Checklist
Posted by Steven Jacobs <sj...@ucr.edu>.
Okay, I think I should be on the list now as sjaco002
Steven
On Mon, Nov 9, 2015 at 11:51 AM, Till Westmann <ti...@apache.org> wrote:
> I’ve grouped the list a bit. Please take a look if that makes sense (and
> feel free to use the list in guiding your reviews).
> Obviously, this list is neither complete or authoritative, please help to
> make it more useful (and not that “useful” != “longer” ;) ).
>
> Cheers,
> Till
>
>
> On 9 Nov 2015, at 9:22, abdullah alamoudi wrote:
>
> Hi Dev,
>> Just wanted to share with you that our code review checklist has been
>> uploaded to our wiki. Check it out at
>>
>> https://cwiki.apache.org/confluence/display/ASTERIXDB/Code+Review+Checklist
>> , adhere to it and use it to make sure the code you're
>> submitting/reviewing
>> meets our minimum standard.
>>
>> Also, feel free to contribute to the list, improve it, and if you can
>> automate some of the items in the list, that would be even better.
>>
>> Cheers,
>> Abdullah.
>>
>
Re: Code Review Checklist
Posted by Till Westmann <ti...@apache.org>.
I’ve grouped the list a bit. Please take a look if that makes sense
(and feel free to use the list in guiding your reviews).
Obviously, this list is neither complete or authoritative, please help
to make it more useful (and not that “useful” != “longer” ;) ).
Cheers,
Till
On 9 Nov 2015, at 9:22, abdullah alamoudi wrote:
> Hi Dev,
> Just wanted to share with you that our code review checklist has been
> uploaded to our wiki. Check it out at
> https://cwiki.apache.org/confluence/display/ASTERIXDB/Code+Review+Checklist
> , adhere to it and use it to make sure the code you're
> submitting/reviewing
> meets our minimum standard.
>
> Also, feel free to contribute to the list, improve it, and if you can
> automate some of the items in the list, that would be even better.
>
> Cheers,
> Abdullah.