You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/21 14:00:28 UTC

[GitHub] [shardingsphere] tuohai666 opened a new issue #6985: Add unit test cases & study PostgreSQL wire protocol

tuohai666 opened a new issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985


   Let's improve the coverage of PostgreSQL protocol up to 90%. The coverage is now much lower than MySQL.
   ![image](https://user-images.githubusercontent.com/24643893/90896167-c2a04f00-e3f5-11ea-969f-faacba2a810f.png)
   
   The target module is **shardingsphere-db-protocol-postgresql**
   
   Someone who want to participate in can simply submit a PR (at least contain all the tests of a single class), or reply this issue to tell what classes you want. I'll add all the classes in a TODO list later.
   
   Reference material
   The official document: https://www.postgresql.org/docs/12/protocol.html
   The famous postgres-for-the-wire: http://wulczer.org/postgres-on-the-wire.pdf


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678774959


   > 
   > 
   > I'd like to invite @xbkaishui and @sandynz , they have good understanding on Proxy or PostgreSQL.
   
   Hi @tuohai666 , thanks. I pick up the last ones:
   ```
   PostgreSQLComTerminationPacket.java
   PostgreSQLCommandCompletePacket.java
   PostgreSQLErrorResponsePacket.java
   PostgreSQLReadyForQueryPacket.java
   PostgreSQLAuthenticationMD5PasswordPacket.java
   PostgreSQLAuthenticationOKPacket.java
   PostgreSQLComStartupPacket.java
   PostgreSQLParameterStatusPacket.java
   PostgreSQLPasswordMessagePacket.java
   PostgreSQLRandomGenerator.java
   PostgreSQLSSLNegativePacket.java
   PostgreSQLPacketPayload.java
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-679835712


   Got it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678957902


   @gzdzss 
   Of course. Assigned. 
   Please note that the closing date for all PRs is **2020.8.27**.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 closed issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 closed issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 edited a comment on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 edited a comment on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-679830681


   @xbkaishui Can you have a check for these cases?
   
   - [ ] PostgreSQLRowDescriptionPacket.java   **( xbkaishui )**
   - [ ] BinaryStatementRegistry.java    **( xbkaishui )**
   - [ ] ConnectionScopeBinaryStatementRegistry.java    **( xbkaishui )**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] gzdzss commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
gzdzss commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678953170


   > @gzdzss There still have tasks in the TODO list, which ones do you want?
   > 
   > * [ ]  PostgreSQLInt2BinaryProtocolValue.java
   > * [ ]  PostgreSQLInt4BinaryProtocolValue.java
   > * [ ]  PostgreSQLInt8BinaryProtocolValue.java
   > * [ ]  PostgreSQLStringBinaryProtocolValue.java
   > * [ ]  PostgreSQLTimeBinaryProtocolValue.java
   > * [ ]  PostgreSQLComDescribePacket.java
   > * [ ]  PostgreSQLComExecutePacket.java
   > * [ ]  PostgreSQLComParsePacket.java
   > * [ ]  PostgreSQLParseCompletePacket.java
   > * [ ]  PostgreSQLComSyncPacket.java
   > * [ ]  PostgreSQLComQueryPacket.java
   > * [ ]  PostgreSQLDataRowPacket.java
   
   Can I have them all? Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 edited a comment on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 edited a comment on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678881837






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-679806251


   @xbkaishui Get it. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678319817


   @xbkaishui Thanks for response. You can pick up several items in the TODO list, I'll keep them for you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xbkaishui commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-679791887


   @tuohai666 I have finished the tests in my side,  below files are ingore for test, because those are either interfaces or normal java beans,  just let you konw 
   ```
   PostgreSQLCommandPacket.java
   PostgreSQLPacket.java
   PostgreSQLBinaryStatement.java
   PostgreSQLBinaryStatementParameterType.java
   PostgreSQLBinaryProtocolValue.java
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] gzdzss edited a comment on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
gzdzss edited a comment on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678953170


   > @gzdzss There still have tasks in the TODO list, which ones do you want?
   > 
   > * [x]  PostgreSQLInt2BinaryProtocolValue.java
   > * [x]  PostgreSQLInt4BinaryProtocolValue.java
   > * [x]  PostgreSQLInt8BinaryProtocolValue.java
   > * [x]  PostgreSQLStringBinaryProtocolValue.java
   > * [x]  PostgreSQLTimeBinaryProtocolValue.java
   > * [x]  PostgreSQLComDescribePacket.java
   > * [x]  PostgreSQLComExecutePacket.java
   > * [x]  PostgreSQLComParsePacket.java
   > * [x]  PostgreSQLParseCompletePacket.java
   > * [x]  PostgreSQLComSyncPacket.java
   > * [x]  PostgreSQLComQueryPacket.java
   > * [x]  PostgreSQLDataRowPacket.java
   
   Can I have them all? Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678943375


   @gzdzss Assigned. Please pick up files from the remain.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xbkaishui commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678324304


   belows are ok,  I can do others left if it is not urgent
   
   - PostgreSQLPacketCodecEngine.java
   - PostgreSQLArrayColumnType.java
   - PostgreSQLColumnType.java
   - PostgreSQLErrorCode.java
   - PostgreSQLPacket.java
   - PostgreSQLCommandPacket.java
   - PostgreSQLCommandPacketFactory.java
   - PostgreSQLCommandPacketType.java
   - PostgreSQLCommandPacketTypeLoader.java
   - PostgreSQLUnsupportedCommandPacket.java
   - PostgreSQLColumnDescription.java
   - PostgreSQLRowDescriptionPacket.java
   - BinaryStatementRegistry.java
   - ConnectionScopeBinaryStatementRegistry.java
   - PostgreSQLBinaryStatement.java
   - PostgreSQLBinaryStatementParameterType.java
   - PostgreSQLBinaryResultSetRowPacket.java
   - PostgreSQLBindCompletePacket.java
   - PostgreSQLComBindPacket.java
   - PostgreSQLBinaryProtocolValue.java
   - PostgreSQLBinaryProtocolValueFactory.java
   - PostgreSQLDateBinaryProtocolValue.java
   - PostgreSQLDoubleBinaryProtocolValue.java
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-679830681


   @xbkaishui Can you have a check for these ones?
   
   - [ ] PostgreSQLRowDescriptionPacket.java   **( xbkaishui )**
   - [ ] BinaryStatementRegistry.java    **( xbkaishui )**
   - [ ] ConnectionScopeBinaryStatementRegistry.java    **( xbkaishui )**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678310677


   I'd like to invite @xbkaishui and @sandynz , they have good understanding  on Proxy or PostgreSQL.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xbkaishui commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678316847


   hi yunlun, thanks for the invite. please kindly give some test cases. anything is ok thanks 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678945821


   @gzdzss There still have tasks in the TODO list, which ones do you want?
   
   - [ ] PostgreSQLInt2BinaryProtocolValue.java
   - [ ] PostgreSQLInt4BinaryProtocolValue.java
   - [ ] PostgreSQLInt8BinaryProtocolValue.java
   - [ ] PostgreSQLStringBinaryProtocolValue.java
   - [ ] PostgreSQLTimeBinaryProtocolValue.java
   - [ ] PostgreSQLComDescribePacket.java
   - [ ] PostgreSQLComExecutePacket.java
   - [ ] PostgreSQLComParsePacket.java
   - [ ] PostgreSQLParseCompletePacket.java
   - [ ] PostgreSQLComSyncPacket.java
   - [ ] PostgreSQLComQueryPacket.java
   - [ ] PostgreSQLDataRowPacket.java


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xbkaishui edited a comment on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
xbkaishui edited a comment on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678316847


   hi yonglun, thanks for the invite. please kindly give some test cases. anything is ok thanks 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xbkaishui commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678887474


   got it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] gzdzss commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
gzdzss commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678944613


   > @gzdzss Assigned. Please pick up files from the remain.
   
   OK , I will be next time as soon as possible.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] cenyu00 commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
cenyu00 commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678568906


   Hi, @tuohai666 
   I want chose one as my first sumbit PR to shardingSphere.  thx
   
   - PostgreSQLFloatBinaryProtocolValue.java


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] gzdzss edited a comment on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
gzdzss edited a comment on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678953170


   > @gzdzss There still have tasks in the TODO list, which ones do you want?
   > 
   > * [x]  PostgreSQLInt2BinaryProtocolValue.java
   > * [ ]  PostgreSQLInt4BinaryProtocolValue.java
   > * [ ]  PostgreSQLInt8BinaryProtocolValue.java
   > * [ ]  PostgreSQLStringBinaryProtocolValue.java
   > * [ ]  PostgreSQLTimeBinaryProtocolValue.java
   > * [ ]  PostgreSQLComDescribePacket.java
   > * [ ]  PostgreSQLComExecutePacket.java
   > * [ ]  PostgreSQLComParsePacket.java
   > * [ ]  PostgreSQLParseCompletePacket.java
   > * [ ]  PostgreSQLComSyncPacket.java
   > * [ ]  PostgreSQLComQueryPacket.java
   > * [ ]  PostgreSQLDataRowPacket.java
   
   Can I have them all? Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 closed issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 closed issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xbkaishui commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-679833250


   Yes, Already in this pr https://github.com/apache/shardingsphere/pull/7049, please help to check 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678881837


   @xbkaishui @cenyu00 @sandynz 
   The closing date for all PRs is 2020.8.27.
   It's a little urgent. If you can't finish all of them, please response as soon as possible.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] gzdzss commented on issue #6985: Add unit test cases & study PostgreSQL wire protocol

Posted by GitBox <gi...@apache.org>.
gzdzss commented on issue #6985:
URL: https://github.com/apache/shardingsphere/issues/6985#issuecomment-678942292


   assgin to me, thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org