You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Gwyn Evans (JIRA)" <ji...@apache.org> on 2013/08/02 01:13:49 UTC
[jira] [Commented] (WICKET-4966) Remove outdated BoxBorder
[ https://issues.apache.org/jira/browse/WICKET-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727051#comment-13727051 ]
Gwyn Evans commented on WICKET-4966:
------------------------------------
When it is removed, if not before, you'll want to tweak the 'Navomatic' example, as that currently uses BoxBorder!
> Remove outdated BoxBorder
> -------------------------
>
> Key: WICKET-4966
> URL: https://issues.apache.org/jira/browse/WICKET-4966
> Project: Wicket
> Issue Type: Task
> Components: wicket
> Affects Versions: 6.2.0
> Reporter: Peter Parson
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 7.0.0
>
>
> Just stubled upon BoxBorder, which is "A very simple border component that draws a thin black line around its children." and creates markup like this:
> <table width = "0%" border = "0" cellspacing = "0" cellpadding = "1" bgcolor = "black">
> <tr>
> <td width = "100%" valign = "top">
> <table width = "100%" border = "0" cellspacing = "0" cellpadding = "4" bgcolor = "white">
> <tr>
> <td width = "100%">
> <wicket:body/>
> </td>
> </tr>
> </table>
> </td>
> </tr>
> </table>
> I know, no one is forced to use it... but honestly: no developer should be lead to the assumption that creating a border like this is a good idea.
> I suggest to deprecate it, or otherwise move it to wicket-extension or somewhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira