You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by GitBox <gi...@apache.org> on 2020/08/01 01:27:47 UTC
[GitHub] [nutch] lewismc commented on a change in pull request #541: NUTCH-2809: Upgrade any23 plugin dependency
lewismc commented on a change in pull request #541:
URL: https://github.com/apache/nutch/pull/541#discussion_r462042836
##########
File path: src/plugin/any23/ivy.xml
##########
@@ -36,14 +36,12 @@
</publications>
<dependencies>
- <dependency org="org.apache.any23" name="apache-any23-core" rev="2.2" conf="*->default">
+ <dependency org="org.apache.any23" name="apache-any23-core" rev="2.3" conf="*->default">
+ <exclude org="javax.ws.rs" name="javax.ws.rs-api" />
<exclude org="org.apache.commons" name="commons-lang" />
<exclude org="org.apache.commons" name="commons-compress" />
- <exclude org="org.slf4j" name="slf4j-log4j12" />
Review comment:
Why did you remove this?
##########
File path: src/plugin/any23/ivy.xml
##########
@@ -36,14 +36,12 @@
</publications>
<dependencies>
- <dependency org="org.apache.any23" name="apache-any23-core" rev="2.2" conf="*->default">
+ <dependency org="org.apache.any23" name="apache-any23-core" rev="2.3" conf="*->default">
+ <exclude org="javax.ws.rs" name="javax.ws.rs-api" />
<exclude org="org.apache.commons" name="commons-lang" />
<exclude org="org.apache.commons" name="commons-compress" />
- <exclude org="org.slf4j" name="slf4j-log4j12" />
<exclude org="org.slf4j" name="slf4j-api" />
- <exclude org="xerces" />
Review comment:
Why did you remove this?
##########
File path: src/plugin/any23/plugin.xml
##########
@@ -25,162 +25,59 @@
<library name="any23.jar">
<export name="*"/>
</library>
- <library name="aopalliance-1.0.jar"/>
- <library name="apache-any23-api-2.2.jar"/>
- <library name="apache-any23-core-2.2.jar"/>
- <library name="apache-any23-csvutils-2.2.jar"/>
- <library name="apache-any23-encoding-2.2.jar"/>
- <library name="apache-any23-mime-2.2.jar"/>
- <library name="apache-mime4j-core-0.8.1.jar"/>
- <library name="apache-mime4j-dom-0.8.1.jar"/>
- <library name="asm-5.0.4.jar"/>
- <library name="bcmail-jdk15on-1.54.jar"/>
- <library name="bcpkix-jdk15on-1.54.jar"/>
- <library name="bcprov-jdk15on-1.54.jar"/>
- <library name="boilerpipe-1.1.0.jar"/>
- <library name="bzip2-0.9.1.jar"/>
- <library name="c3p0-0.9.1.1.jar"/>
- <library name="caffeine-2.5.6.jar"/>
- <library name="cdm-4.5.5.jar"/>
- <library name="commons-codec-1.10.jar"/>
- <library name="commons-collections4-4.1.jar"/>
- <library name="commons-csv-1.5.jar"/>
- <library name="commons-exec-1.3.jar"/>
- <library name="commons-httpclient-3.1.jar"/>
- <library name="commons-io-2.4.jar"/>
+ <library name="jcommander-1.72.jar"/>
Review comment:
The changes to the file are not correct. Please [follow the guidance](https://github.com/apache/nutch/blob/master/src/plugin/any23/howto_upgrade_any23.txt#L3-L6) and update this PR if you can. Thanks
##########
File path: src/plugin/any23/ivy.xml
##########
@@ -36,14 +36,12 @@
</publications>
<dependencies>
- <dependency org="org.apache.any23" name="apache-any23-core" rev="2.2" conf="*->default">
+ <dependency org="org.apache.any23" name="apache-any23-core" rev="2.3" conf="*->default">
+ <exclude org="javax.ws.rs" name="javax.ws.rs-api" />
<exclude org="org.apache.commons" name="commons-lang" />
<exclude org="org.apache.commons" name="commons-compress" />
- <exclude org="org.slf4j" name="slf4j-log4j12" />
<exclude org="org.slf4j" name="slf4j-api" />
- <exclude org="xerces" />
</dependency>
- <dependency org="org.apache.commons" name="commons-rdf-api" rev="0.5.0" conf="*->default"/>
Review comment:
Why did you remove this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org