You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jason Gerlowski (JIRA)" <ji...@apache.org> on 2015/12/01 15:49:11 UTC
[jira] [Updated] (SOLR-8330) Restrict logger visibility throughout
the codebase to private so that only the file that declares it can use it
[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Gerlowski updated SOLR-8330:
----------------------------------
Attachment: SOLR-8330.patch
I've updated the patch to sit on top of the latest trunk changes (as of maybe an hour or two ago).
I also added the fix that Greg mentioned below. With it, RequestLoggingTest passes now!
I'm in the process of running the tests in the background, and I'll post again if/when I see them pass.
> Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-8330
> URL: https://issues.apache.org/jira/browse/SOLR-8330
> Project: Solr
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jason Gerlowski
> Assignee: Anshum Gupta
> Labels: logging
> Fix For: Trunk
>
> Attachments: SOLR-8330-combined.patch, SOLR-8330-detector.patch, SOLR-8330-detector.patch, SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch
>
>
> As Mike Drob pointed out in Solr-8324, many loggers in Solr are unintentionally shared between classes. Many instances of this are caused by overzealous copy-paste. This can make debugging tougher, as messages appear to come from an incorrect location.
> As discussed in the comments on SOLR-8324, there also might be legitimate reasons for sharing loggers between classes. Where any ambiguity exists, these instances shouldn't be touched.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org