You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/04/14 11:40:20 UTC

Review Request 20315: CLOUDSTACK-6401: [hyper-v] fixed correct host state in cloudstack if the hyper-v agent is down

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20315/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Rajesh Battala.


Bugs: CLOUDSTACK-6401
    https://issues.apache.org/jira/browse/CLOUDSTACK-6401


Repository: cloudstack-git


Description
-------

fixed correct host state in cloudstack if the hyper-v agent is down. Added heartbeat file to monitor whether host is actually down or not


Diffs
-----

  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResource.csproj ec44568 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 4f4c14e 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs 5ddcbef 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/heartbeat.bat PRE-CREATION 

Diff: https://reviews.apache.org/r/20315/diff/


Testing
-------

verified various scenarios

1. agent is down but host is up
2. both are down
3. both are up


Thanks,

Anshul Gangwar


Re: Review Request 20315: CLOUDSTACK-6401: [hyper-v] fixed correct host state in cloudstack if the hyper-v agent is down

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20315/#review40359
-----------------------------------------------------------


Commit b78aee8f117f9e89a533afba86b3ff91da19744e in cloudstack's branch refs/heads/4.4 from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b78aee8 ]

CLOUDSTACK-6401: [hyper-v] fixed correct host state, if host is up and hyper-v agent is down then the host state will be shown as up(actual host state) in cloudstack


- ASF Subversion and Git Services


On April 15, 2014, 5:12 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20315/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 5:12 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6401
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6401
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> fixed correct host state in cloudstack if the hyper-v agent is down. Added heartbeat file to monitor whether host is actually down or not
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResource.csproj ec44568 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 4f4c14e 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs 5ddcbef 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/heartbeat.bat PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20315/diff/
> 
> 
> Testing
> -------
> 
> verified various scenarios
> 
> 1. agent is down but host is up
> 2. both are down
> 3. both are up
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request 20315: CLOUDSTACK-6401: [hyper-v] fixed correct host state in cloudstack if the hyper-v agent is down

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20315/#review40369
-----------------------------------------------------------


Commit 55f53e13e82179c2cbde3f667869495ec944f496 in cloudstack's branch refs/heads/master from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=55f53e1 ]

CLOUDSTACK-6401: [hyper-v] fixed correct host state, if host is up and hyper-v agent is down then the host state will be shown as up(actual host state) in cloudstack


- ASF Subversion and Git Services


On April 15, 2014, 5:12 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20315/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 5:12 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6401
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6401
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> fixed correct host state in cloudstack if the hyper-v agent is down. Added heartbeat file to monitor whether host is actually down or not
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResource.csproj ec44568 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 4f4c14e 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs 5ddcbef 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/heartbeat.bat PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20315/diff/
> 
> 
> Testing
> -------
> 
> verified various scenarios
> 
> 1. agent is down but host is up
> 2. both are down
> 3. both are up
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request 20315: CLOUDSTACK-6401: [hyper-v] fixed correct host state in cloudstack if the hyper-v agent is down

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20315/#review40372
-----------------------------------------------------------

Ship it!


Ship It!

- Devdeep Singh


On April 15, 2014, 5:12 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20315/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 5:12 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6401
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6401
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> fixed correct host state in cloudstack if the hyper-v agent is down. Added heartbeat file to monitor whether host is actually down or not
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResource.csproj ec44568 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 4f4c14e 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs 5ddcbef 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/heartbeat.bat PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20315/diff/
> 
> 
> Testing
> -------
> 
> verified various scenarios
> 
> 1. agent is down but host is up
> 2. both are down
> 3. both are up
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request 20315: CLOUDSTACK-6401: [hyper-v] fixed correct host state in cloudstack if the hyper-v agent is down

Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20315/
-----------------------------------------------------------

(Updated April 15, 2014, 5:12 a.m.)


Review request for cloudstack, Devdeep Singh and Rajesh Battala.


Changes
-------

added the license header to newly added file


Bugs: CLOUDSTACK-6401
    https://issues.apache.org/jira/browse/CLOUDSTACK-6401


Repository: cloudstack-git


Description
-------

fixed correct host state in cloudstack if the hyper-v agent is down. Added heartbeat file to monitor whether host is actually down or not


Diffs (updated)
-----

  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResource.csproj ec44568 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 4f4c14e 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs 5ddcbef 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/heartbeat.bat PRE-CREATION 

Diff: https://reviews.apache.org/r/20315/diff/


Testing
-------

verified various scenarios

1. agent is down but host is up
2. both are down
3. both are up


Thanks,

Anshul Gangwar