You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by trkurc <gi...@git.apache.org> on 2016/03/20 23:32:51 UTC
[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...
GitHub user trkurc opened a pull request:
https://github.com/apache/nifi/pull/292
NIFI-1656 Added locale support to ConvertAvroSchema and fixed locale …
…problems in unit tests
See:
https://issues.apache.org/jira/browse/NIFI-1656
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trkurc/nifi NIFI-1656
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #292
----
commit 56832747d365ca87ecc51660e3d9637d9dee825f
Author: trkurc <tk...@gizmolabs.org>
Date: 2016-03-20T22:25:04Z
NIFI-1656 Added locale support to ConvertAvroSchema and fixed locale problems in unit tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/292#issuecomment-199315775
Created a ticket to handle this task: https://issues.apache.org/jira/browse/NIFI-1657
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the pull request:
https://github.com/apache/nifi/pull/292#issuecomment-199134795
Everything OK, I'm a :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/292#issuecomment-199051348
@pvillard31 - can you try this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/292#issuecomment-199137191
Thanks for following up, @pvillard31 . I think maybe building with other default locales may be worth exploring to add to travis-ci (tagging @apiri who may know if that's possible (I added -Duser.language=fr -Duser.region=FR to my env when testing))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/292#issuecomment-199261919
Yeah, can certainly figure something out with the build matrix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---