You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "allisonwang-db (via GitHub)" <gi...@apache.org> on 2023/07/03 18:02:10 UTC

[GitHub] [spark] allisonwang-db commented on a diff in pull request #41792: [SPARK-44249][SQL][PYTHON] Refactor PythonUDTFRunner to send its return type separately

allisonwang-db commented on code in PR #41792:
URL: https://github.com/apache/spark/pull/41792#discussion_r1251156068


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/BatchEvalPythonUDTFExec.scala:
##########
@@ -173,3 +169,32 @@ case class BatchEvalPythonUDTFExec(
   override protected def withNewChildInternal(newChild: SparkPlan): BatchEvalPythonUDTFExec =
     copy(child = newChild)
 }
+
+class PythonUDTFRunner(

Review Comment:
   Thanks for the refactoring!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org