You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/18 14:42:20 UTC
[GitHub] [airflow] Jorricks opened a new pull request #20924: Add missing statsd metric for failing SLA Callback notification
Jorricks opened a new pull request #20924:
URL: https://github.com/apache/airflow/pull/20924
There is a statsd metric for failing email notifications but not for failing callbacks.
This PR makes it easier to monitor for failing callbacks to spot them sooner.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20924: Add missing statsd metric for failing SLA Callback notification
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20924:
URL: https://github.com/apache/airflow/pull/20924#issuecomment-1017098326
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #20924: Add missing statsd metric for failing SLA Callback notification
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #20924:
URL: https://github.com/apache/airflow/pull/20924#issuecomment-1033866848
> @uranusjr is there a new policy to not merge MRs right away? I am wondering what we are waiting for :)?
I think it was simply overlooked. If you look at the "traffic" in our PRs, you might understand that sometimes some things might simply slip under the radar. Generally speaking it's the author's responsibiliyt to Gently Ping if they see such a situation might happen. You, as author are ultimately mostly interested about this and I bet you have probably orders of magnitude less of PRs that you authored rather than any of the maintainers to approve/merge.
Little empathy goes a long way :). Just gently ping next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Jorricks commented on pull request #20924: Add missing statsd metric for failing SLA Callback notification
Posted by GitBox <gi...@apache.org>.
Jorricks commented on pull request #20924:
URL: https://github.com/apache/airflow/pull/20924#issuecomment-1033644297
@uranusjr is there a new policy to not merge MRs right away? I am wondering what we are waiting for :)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20924: Add missing statsd metric for failing SLA Callback notification
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20924:
URL: https://github.com/apache/airflow/pull/20924#issuecomment-1033866848
> @uranusjr is there a new policy to not merge MRs right away? I am wondering what we are waiting for :)?
I think it was simply overlooked. If you look at the "traffic" in our PRs, you might understand that sometimes some things might simply slip under the radar. Generally speaking it's the author's responsibiliyt to Gently Ping if they see such a situation might happen. You, as authopr are ultimately mostly interested about this and I bet you have probably orders of magnitude less of PRs that you authored rather than any of the maintainers to approve/merge.
Little empathy goes a long way :). Just gently ping next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20924: Add missing statsd metric for failing SLA Callback notification
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20924:
URL: https://github.com/apache/airflow/pull/20924#issuecomment-1033886585
> Sorry if it came over harsh
:) No worries. It just a bit harsh by the fact that you kinda abandoned it for 20 days (and obviously we did too :) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20924: Add missing statsd metric for failing SLA Callback notification
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20924:
URL: https://github.com/apache/airflow/pull/20924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Jorricks commented on pull request #20924: Add missing statsd metric for failing SLA Callback notification
Posted by GitBox <gi...@apache.org>.
Jorricks commented on pull request #20924:
URL: https://github.com/apache/airflow/pull/20924#issuecomment-1033883159
> > @uranusjr is there a new policy to not merge MRs right away? I am wondering what we are waiting for :)?
>
> I think it was simply overlooked. If you look at the "traffic" in our PRs, you might understand that sometimes some things might simply slip under the radar. Generally speaking it's the author's responsibiliyt to Gently Ping if they see such a situation might happen. You, as author are ultimately mostly interested about this and I bet you have probably orders of magnitude less of PRs that you authored rather than any of the maintainers to approve/merge.
>
> Little empathy goes a long way :). Just gently ping next time.
I understand. I didn't mean anything by my comment, I was just really wondering if I can find the policy on merging PRs somewhere. I appreciate all the work you are doing 🙏
Sorry if it came over harsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #20924: Add missing statsd metric for failing SLA Callback notification
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #20924:
URL: https://github.com/apache/airflow/pull/20924#issuecomment-1033886585
> Sorry if it came over harsh
:) No worries. It just came a bit harsh by the fact that you kinda abandoned it for 20 days (and obviously we did too :) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org