You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/07/08 22:20:18 UTC
[kudu-CR] [util] clean up on SCOPED OPENSSL NO PENDING ERRORS
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23148
Change subject: [util] clean up on SCOPED_OPENSSL_NO_PENDING_ERRORS
......................................................................
[util] clean up on SCOPED_OPENSSL_NO_PENDING_ERRORS
Add 'const' for ScopedCheckNoPendingSSLErrors instances in the
SCOPED_OPENSSL_NO_PENDING_ERRORS macro and instantiate those only
if DCHECK_IS_ON() since the corresponding constraints are enforced
with the DCHECK_EQ() macro.
The motivation for this change was seeing warnings in QtCreator IDE
on improving const-correctness for ScopedCheckNoPendingSSLErrors
instances as part of the SCOPED_OPENSSL_NO_PENDING_ERRORS macro.
This changelist doesn't contains any functional modifications.
Change-Id: I94a9b6d34b36567b414599fdd10db64c932074d4
---
M src/kudu/util/openssl_util.h
1 file changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/23148/1
--
To view, visit http://gerrit.cloudera.org:8080/23148
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94a9b6d34b36567b414599fdd10db64c932074d4
Gerrit-Change-Number: 23148
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [util] clean up on SCOPED OPENSSL NO PENDING ERRORS
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23148 )
Change subject: [util] clean up on SCOPED_OPENSSL_NO_PENDING_ERRORS
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1556/
--
To view, visit http://gerrit.cloudera.org:8080/23148
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94a9b6d34b36567b414599fdd10db64c932074d4
Gerrit-Change-Number: 23148
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Jul 2025 22:20:27 +0000
Gerrit-HasComments: No
[kudu-CR] [util] clean up on SCOPED OPENSSL NO PENDING ERRORS
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23148 )
Change subject: [util] clean up on SCOPED_OPENSSL_NO_PENDING_ERRORS
......................................................................
[util] clean up on SCOPED_OPENSSL_NO_PENDING_ERRORS
Add 'const' for ScopedCheckNoPendingSSLErrors instances in the
SCOPED_OPENSSL_NO_PENDING_ERRORS macro and instantiate those only
if DCHECK_IS_ON() since the corresponding constraints are enforced
with the DCHECK_EQ() macro.
The motivation for this change was seeing warnings in QtCreator IDE
on improving const-correctness for ScopedCheckNoPendingSSLErrors
instances as part of the SCOPED_OPENSSL_NO_PENDING_ERRORS macro.
This changelist doesn't contains any functional modifications.
Change-Id: I94a9b6d34b36567b414599fdd10db64c932074d4
Reviewed-on: http://gerrit.cloudera.org:8080/23148
Reviewed-by: KeDeng <kd...@gmail.com>
Tested-by: KeDeng <kd...@gmail.com>
---
M src/kudu/util/openssl_util.h
1 file changed, 8 insertions(+), 3 deletions(-)
Approvals:
KeDeng: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23148
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I94a9b6d34b36567b414599fdd10db64c932074d4
Gerrit-Change-Number: 23148
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [util] clean up on SCOPED OPENSSL NO PENDING ERRORS
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/23148 )
Change subject: [util] clean up on SCOPED_OPENSSL_NO_PENDING_ERRORS
......................................................................
Patch Set 1: Verified+1 Code-Review+2
Unreleated raft_consensus-itest.0 maintenance_mode-itest.2 ablet_server_quiescing-itest.0 fails
--
To view, visit http://gerrit.cloudera.org:8080/23148
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94a9b6d34b36567b414599fdd10db64c932074d4
Gerrit-Change-Number: 23148
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 09 Jul 2025 02:32:40 +0000
Gerrit-HasComments: No
[kudu-CR] [util] clean up on SCOPED OPENSSL NO PENDING ERRORS
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has removed a vote on this change.
Change subject: [util] clean up on SCOPED_OPENSSL_NO_PENDING_ERRORS
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23148
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I94a9b6d34b36567b414599fdd10db64c932074d4
Gerrit-Change-Number: 23148
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [util] clean up on SCOPED OPENSSL NO PENDING ERRORS
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23148 )
Change subject: [util] clean up on SCOPED_OPENSSL_NO_PENDING_ERRORS
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1556/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23148
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94a9b6d34b36567b414599fdd10db64c932074d4
Gerrit-Change-Number: 23148
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 08 Jul 2025 23:17:53 +0000
Gerrit-HasComments: No