[jira] [Commented] (LUCENE-7564) AnalyzingInfixSuggester should close its IndexWriter by default at the end of build()

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671791#comment-15671791 ] 

Michael McCandless commented on LUCENE-7564:
--------------------------------------------

+1, thanks [~steve_rowe].

> AnalyzingInfixSuggester should close its IndexWriter by default at the end of build()
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7564
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7564
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Steve Rowe
>         Attachments: LUCENE-7564.patch, LUCENE-7564.patch
>
>
> From SOLR-6246, where AnalyzingInfixSuggester's write lock on its index is causing trouble when reloading a Solr core:
> [~gsingers] wrote:
> bq. One suggestion that might minimize the impact: close the writer after build
> [~varunthacker] wrote:
> {quote}
> This is what I am thinking -
> Create a Lucene issue in which {{AnalyzingInfixSuggester#build}} closes the writer by default at the end.
> The {{add}} and {{update}} methods call {{ensureOpen}} and those who do frequent real time updates directly via lucene won't see any slowdowns.
> [~mikemccand] - Would this approach have any major drawback from Lucene's perspective? Else I can go ahead an tackle this in a Lucene issue
> {quote}
> [~mikemccand] wrote:
> bq. Fixing {{AnalyzingInfixSuggester}} to close the writer at the end of build seems reasonable?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org