You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by inbar stolberg <no...@github.com> on 2014/10/08 06:19:34 UTC
[jclouds] bug fix keystone role api + bug fix host aggregates (#559)
fix no authentication required (token) for keystone RoleAdminApi
fixed mandatory AZ for host aggregate on nova
You can merge this Pull Request by running:
git pull https://github.com/inbarsto/cloudband-jclouds keystoneNovaAgg
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/559
-- Commit Summary --
* bug fix keystone role api + bug fix host aggregates
-- File Changes --
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/RoleAdminApi.java (3)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/domain/HostAggregate.java (6)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/559.patch
https://github.com/jclouds/jclouds/pull/559.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by Adrian Cole <no...@github.com>.
Closed #559.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#event-175563934
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by Adrian Cole <no...@github.com>.
tested locally
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#issuecomment-58309828
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by inbar stolberg <no...@github.com>.
tested on live env btw (Havanah and IceHouse)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#issuecomment-58308234
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #1748](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1748/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#issuecomment-58314003
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by inbar stolberg <no...@github.com>.
you are correct sir :) (exactly what happened to me...)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#issuecomment-58307152
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by Adrian Cole <no...@github.com>.
LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#issuecomment-58308146
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #166](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/166/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#issuecomment-58310612
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by inbar stolberg <no...@github.com>.
cheers :+1: more on the way :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#issuecomment-58311312
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by Jeremy Daggett <no...@github.com>.
> @@ -47,6 +49,7 @@
> */
> @Beta
> @Extension(of = ServiceType.IDENTITY, namespace = ExtensionNamespaces.OS_KSADM)
> +@RequestFilters(AuthenticateRequest.class)
There would have been no way to access this API without this line! :+1:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559/files#r18563955
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1255](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1255/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#issuecomment-58311202
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by Adrian Cole <no...@github.com>.
cherry-picked into master, 1.8.x
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#issuecomment-58310582
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by Andrew Phillips <no...@github.com>.
> cherry-picked into master, 1.8.x
Thanks, @adriancole!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#issuecomment-58399153
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by inbar stolberg <no...@github.com>.
so... are we good to go?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#issuecomment-58309883
Re: [jclouds] bug fix keystone role api + bug fix host aggregates
(#559)
Posted by Adrian Cole <no...@github.com>.
yep.. merging in a minute
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/559#issuecomment-58309964