You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "Ralph Goers (JIRA)" <ji...@apache.org> on 2018/09/22 06:15:00 UTC
[jira] [Resolved] (LOG4J2-2420) RequestContextFilter logging
cleanup
[ https://issues.apache.org/jira/browse/LOG4J2-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ralph Goers resolved LOG4J2-2420.
---------------------------------
Resolution: Fixed
Fix Version/s: Log4j-Audit 1.0.1
Patch applied. Please verify and close.
> RequestContextFilter logging cleanup
> ------------------------------------
>
> Key: LOG4J2-2420
> URL: https://issues.apache.org/jira/browse/LOG4J2-2420
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
> Affects Versions: Log4j-Audit 1.0.0
> Reporter: Andrei Ivanov
> Priority: Minor
> Fix For: Log4j-Audit 1.0.1
>
>
> The {{RequestContextFilter}} logs some details that should be done on {{DEBUG}} or {{TRACE}} instead of {{INFO}}.
> {noformat}
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Starting request {}/productrepository/2594
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Request /productrepository/2594 completed in 0.139279500 seconds
> {noformat}
> There's even a small bug on the 1st [line|https://github.com/apache/logging-log4j-audit/blob/9bab5dad26e67642573cbc8257b6cbcafb23bf3c/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/rest/RequestContextFilter.java#L82] where concatenation was used.
> The calculation of the request duration should also be moved in an if block, to avoid it if it won't be logged.
> Same for the Maven plugin, I think it should print the name of the generated classes only on debug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)