You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2011/12/01 11:11:13 UTC

DO NOT REPLY [Bug 118662] New: removal/replacement for 3rd party component Berkeley DB

https://issues.apache.org/ooo/show_bug.cgi?id=118662

             Bug #: 118662
        Issue Type: DEFECT
           Summary: removal/replacement for 3rd party component Berkeley
                    DB
    Classification: Code
           Product: external
           Version: OOO340m0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: critical
          Priority: P2
         Component: www
        AssignedTo: orwittmann@googlemail.com
        ReportedBy: orwittmann@googlemail.com
                CC: ooo-issues@incubator.apache.org
            Blocks: 118566


As the 3rd party component Berkeley DB has a non-permissive license due to
Apache's 3rd party licensing policy it has to be removed and replaced.

Modules depending on Berkeley DB:
- l10ntools
- xmlhelp
- desktop

Dependency in module l10ntools is by 'dead' code. This can be easily removed.

Deeper investigation needed for modules xmlhelp and desktop

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Replace and remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

hdu@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|STARTED                     |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from hdu@apache.org 2011-12-12 11:25:50 UTC ---
On Oliver-Rainer's request I also committed his changes for xmlhelp
    http://svn.apache.org/viewvc?view=revision&revision=1213188
for l10tools
    http://svn.apache.org/viewvc?view=revision&revision=1213189
and for the wholesale removal of berkeleydb from AOO
    http://svn.apache.org/viewvc?view=revision&revision=1213190

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] clarify usage of 3rd party component Oracle Berkeley DB regarding license

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

hdu@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77061|                            |review?(orwittmann@googlema
              Flags|                            |il.com)

--- Comment #2 from hdu@apache.org 2011-12-06 09:38:19 UTC ---
Created attachment 77061
  --> https://issues.apache.org/ooo/attachment.cgi?id=77061
replace berkeleydb in the desktop module

Removes the berkeleydb dependency from the desktop module. It replaces the use
of *.db files with *.pmap files, which are used to keep the internal key-value
map persistent.

It also makes the files db.hxx and db.cxx of the desktop module superfluous. So
when committing they should be removed too.

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

hdu@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hdu@apache.org
            Summary|clarify usage of 3rd party  |IP clearance: Remove
                   |component Oracle Berkeley   |BerkeleyDB library
                   |DB regarding license        |

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Replace and remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

hdu@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |113229

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Replace and remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

--- Comment #11 from hdu@apache.org 2011-12-12 09:28:11 UTC ---
Also tested on Linux. Builds as fine as current trunk. Help works, also
searching in it. Extension manager works fine.

With Win/Mac/Linux tested I committed my part of the patches as
  http://svn.apache.org/viewvc?view=revision&revision=1213171
and the remaining changes for the desktop modules (by Oliver-Rainer) as
  http://svn.apache.org/viewvc?view=revision&revision=1213174

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] clarify usage of 3rd party component Oracle Berkeley DB regarding license

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

hdu@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77061|0                           |1
        is obsolete|                            |
  Attachment #77061|review?(orwittmann@googlema |
              Flags|il.com)                     |
  Attachment #77062|                            |review?(orwittmann@googlema
              Flags|                            |il.com)

--- Comment #3 from hdu@apache.org 2011-12-06 13:15:10 UTC ---
Created attachment 77062
  --> https://issues.apache.org/ooo/attachment.cgi?id=77062
replace berkeleydb in the desktop module, v2

The second version of the patch prevents the creation of *.pmap files if they
would end up being empty of information. The patch also deletes the source
files db.hxx and db.cxx that are no longer needed.

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Replace and remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

Oliver-Rainer Wittmann <or...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |STARTED

--- Comment #9 from Oliver-Rainer Wittmann <or...@googlemail.com> 2011-12-08 15:50:42 UTC ---
Attached you find four patches to replace and remove the 3rd party component
Berkeley DB (BDB):
- removal of dependency on BDB in module l10ntools - 'dead code'
- removal of dependency on BDB in module xmlhelp - more or less 'dead code'
- replace usage of BDB in module desktop - thanks to hdu (Herbert Dürr)
- removal of BDB itself

These patches affect the help system and the extension management.
I have tested these patches on Windows. Before committing to trunk I am asking
for testing it on other platforms - at least on Mac OS X and Linux.
Thanks in advance.

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Replace and remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

--- Comment #6 from Oliver-Rainer Wittmann <or...@googlemail.com> 2011-12-08 15:43:55 UTC ---
Created attachment 77068
  --> https://issues.apache.org/ooo/attachment.cgi?id=77068
patch to remove dependency on Berkeley DB in module xmlhelp

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Replace and remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

eric.bachard@free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.bachard@free.fr

--- Comment #10 from eric.bachard@free.fr 2011-12-09 10:58:34 UTC ---
Patches tested on Mac OS X Intel (10.4 aka Tiger)

* No fuzz, nor reject
* Builds ok (en-US, fr, de)
* Installs finely
* Help works, no apparent issue
* Opening various document, no problem detected

I built and installed presenter screen extension,

* installed without a glitch (got to go, so not tested though)


HTH

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

hdu@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77062|0                           |1
        is obsolete|                            |
  Attachment #77062|review?(orwittmann@googlema |
              Flags|il.com)                     |
  Attachment #77065|                            |review?(orwittmann@googlema
              Flags|                            |il.com)

--- Comment #4 from hdu@apache.org 2011-12-08 07:02:20 UTC ---
Created attachment 77065
  --> https://issues.apache.org/ooo/attachment.cgi?id=77065
replace berkeleydb in the desktop module, v3

Updated patch to check the header magic, to handle positive cases of
PersistentMap::has() (thanks Oliver-Rainer!) and to delimit the *.pmap file's
key-value enumeration (in the form of an empty key name).

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] clarify usage of 3rd party component Oracle Berkeley DB regarding license

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

Oliver-Rainer Wittmann <or...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|removal/replacement for 3rd |clarify usage of 3rd party
                   |party component Berkeley DB |component Oracle Berkeley
                   |                            |DB regarding license

--- Comment #1 from Oliver-Rainer Wittmann <or...@googlemail.com> 2011-12-01 12:32:32 UTC ---
Ok, somehow too fast.

Changing this issue due to the corresponding post on mailing list ooo-dev and
JIRA-legal issue https://issues.apache.org/jira/browse/LEGAL-113 regarding the
discussion of the Berkeley DB license.

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Replace and remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

Oliver-Rainer Wittmann <or...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77065|0                           |1
        is obsolete|                            |
  Attachment #77065|review?(orwittmann@googlema |
              Flags|il.com)                     |

--- Comment #7 from Oliver-Rainer Wittmann <or...@googlemail.com> 2011-12-08 15:45:29 UTC ---
Created attachment 77069
  --> https://issues.apache.org/ooo/attachment.cgi?id=77069
patch to replace Berkeley DB in module desktop, containing hdu's patch + minor
stuff in makefiles

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Replace and remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

--- Comment #5 from Oliver-Rainer Wittmann <or...@googlemail.com> 2011-12-08 15:43:19 UTC ---
Created attachment 77067
  --> https://issues.apache.org/ooo/attachment.cgi?id=77067
patch to remove dependency on Berkeley DB in module l10ntools

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Replace and remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

hdu@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from hdu@apache.org 2012-01-16 08:53:52 UTC ---
Closing resolved issue.

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Replace and remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

--- Comment #8 from Oliver-Rainer Wittmann <or...@googlemail.com> 2011-12-08 15:46:43 UTC ---
Created attachment 77070
  --> https://issues.apache.org/ooo/attachment.cgi?id=77070
patch to remove 3rd party component Berkeley DB

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

DO NOT REPLY [Bug 118662] IP clearance: Replace and remove BerkeleyDB library

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118662

Oliver-Rainer Wittmann <or...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|IP clearance: Remove        |IP clearance: Replace and
                   |BerkeleyDB library          |remove BerkeleyDB library

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.