You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mateen Mansoori <ma...@gmail.com> on 2019/08/13 12:33:49 UTC
Review Request 71279: RANGER-2526 :Log does not get generated for
"Deny All Other Accesses" toggle button available on Policy page.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71279/
-----------------------------------------------------------
Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-2526
https://issues.apache.org/jira/browse/RANGER-2526
Repository: ranger
Description
-------
Steps to Reproduce:
1. Create a Policy with "Deny All Other Accesses" toggle button.(True/False)
2. Go to Audit>>Admin Tab, "Deny All Other Accesses" field does not display in created/updated Policy log.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 95342c3
security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyService.java d33b24b
Diff: https://reviews.apache.org/r/71279/diff/1/
Testing
-------
Build : success
When a access type policy is created, the log should be generated for the "Deny All Other Accesses" toggle button available on Policy page.
->Create a access type policy with "Deny All Other Accesses" toggle button(T/F).
->EXPECTED : Log should be generated for the same.
->ACTUAL : Logs getting generated for the same.
Log will not be generated for Masking and Row Level Filter policies with this patch(NEED SUGGESTION FOR THIS THING).
Thanks,
Mateen Mansoori
Re: Review Request 71279: RANGER-2526 :Log does not get generated for
"Deny All Other Accesses" toggle button available on Policy page.
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71279/#review217357
-----------------------------------------------------------
Ship it!
Ship It!
- Pradeep Agrawal
On Aug. 16, 2019, 1:32 p.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71279/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2019, 1:32 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2526
> https://issues.apache.org/jira/browse/RANGER-2526
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Steps to Reproduce:
>
> 1. Create a Policy with "Deny All Other Accesses" toggle button.(True/False)
> 2. Go to Audit>>Admin Tab, "Deny All Other Accesses" field does not display in created/updated Policy log.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 95342c3
> security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyService.java d33b24b
>
>
> Diff: https://reviews.apache.org/r/71279/diff/2/
>
>
> Testing
> -------
>
> Build : success
>
> When a access type policy is created, the log should be generated for the "Deny All Other Accesses" toggle button available on Policy page.
> ->Create a access type policy with "Deny All Other Accesses" toggle button(T/F).
> ->EXPECTED : Log should be generated for the same.
> ->ACTUAL : Logs getting generated for the same.
>
> Log will not be generated for Masking and Row Level Filter policies for "Deny All Other Accesses" with this patch(NEED SUGGESTION FOR THIS THING).
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 71279: RANGER-2526 :Log does not get generated for
"Deny All Other Accesses" toggle button available on Policy page.
Posted by Mateen Mansoori <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71279/
-----------------------------------------------------------
(Updated Aug. 16, 2019, 1:32 p.m.)
Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-2526
https://issues.apache.org/jira/browse/RANGER-2526
Repository: ranger
Description
-------
Steps to Reproduce:
1. Create a Policy with "Deny All Other Accesses" toggle button.(True/False)
2. Go to Audit>>Admin Tab, "Deny All Other Accesses" field does not display in created/updated Policy log.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 95342c3
security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyService.java d33b24b
Diff: https://reviews.apache.org/r/71279/diff/2/
Changes: https://reviews.apache.org/r/71279/diff/1-2/
Testing
-------
Build : success
When a access type policy is created, the log should be generated for the "Deny All Other Accesses" toggle button available on Policy page.
->Create a access type policy with "Deny All Other Accesses" toggle button(T/F).
->EXPECTED : Log should be generated for the same.
->ACTUAL : Logs getting generated for the same.
Log will not be generated for Masking and Row Level Filter policies for "Deny All Other Accesses" with this patch(NEED SUGGESTION FOR THIS THING).
Thanks,
Mateen Mansoori
Re: Review Request 71279: RANGER-2526 :Log does not get generated for
"Deny All Other Accesses" toggle button available on Policy page.
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71279/#review217236
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Aug. 13, 2019, 12:37 p.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71279/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2019, 12:37 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2526
> https://issues.apache.org/jira/browse/RANGER-2526
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Steps to Reproduce:
>
> 1. Create a Policy with "Deny All Other Accesses" toggle button.(True/False)
> 2. Go to Audit>>Admin Tab, "Deny All Other Accesses" field does not display in created/updated Policy log.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 95342c3
> security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyService.java d33b24b
>
>
> Diff: https://reviews.apache.org/r/71279/diff/1/
>
>
> Testing
> -------
>
> Build : success
>
> When a access type policy is created, the log should be generated for the "Deny All Other Accesses" toggle button available on Policy page.
> ->Create a access type policy with "Deny All Other Accesses" toggle button(T/F).
> ->EXPECTED : Log should be generated for the same.
> ->ACTUAL : Logs getting generated for the same.
>
> Log will not be generated for Masking and Row Level Filter policies for "Deny All Other Accesses" with this patch(NEED SUGGESTION FOR THIS THING).
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 71279: RANGER-2526 :Log does not get generated for
"Deny All Other Accesses" toggle button available on Policy page.
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71279/#review217237
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
Lines 205 (patched)
<https://reviews.apache.org/r/71279/#comment304515>
What if 'xXSvcDef' is null ?
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
Lines 206 (patched)
<https://reviews.apache.org/r/71279/#comment304516>
What if 'xXSvcDefTag' is null ?
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
Lines 210 (patched)
<https://reviews.apache.org/r/71279/#comment304517>
add null check
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
Lines 214 (patched)
<https://reviews.apache.org/r/71279/#comment304518>
add null check, look at other places also.
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
Lines 240 (patched)
<https://reviews.apache.org/r/71279/#comment304519>
Are you trying to compare string and long values
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
Lines 245 (patched)
<https://reviews.apache.org/r/71279/#comment304520>
check string vs. long comparison properly. may be a typing mistake from your end.
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
Lines 346 (patched)
<https://reviews.apache.org/r/71279/#comment304521>
it seems there are multiple return statement. see if its possible to have only one.
- Pradeep Agrawal
On Aug. 13, 2019, 12:37 p.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71279/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2019, 12:37 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2526
> https://issues.apache.org/jira/browse/RANGER-2526
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Steps to Reproduce:
>
> 1. Create a Policy with "Deny All Other Accesses" toggle button.(True/False)
> 2. Go to Audit>>Admin Tab, "Deny All Other Accesses" field does not display in created/updated Policy log.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 95342c3
> security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyService.java d33b24b
>
>
> Diff: https://reviews.apache.org/r/71279/diff/1/
>
>
> Testing
> -------
>
> Build : success
>
> When a access type policy is created, the log should be generated for the "Deny All Other Accesses" toggle button available on Policy page.
> ->Create a access type policy with "Deny All Other Accesses" toggle button(T/F).
> ->EXPECTED : Log should be generated for the same.
> ->ACTUAL : Logs getting generated for the same.
>
> Log will not be generated for Masking and Row Level Filter policies for "Deny All Other Accesses" with this patch(NEED SUGGESTION FOR THIS THING).
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 71279: RANGER-2526 :Log does not get generated for
"Deny All Other Accesses" toggle button available on Policy page.
Posted by Mateen Mansoori <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71279/
-----------------------------------------------------------
(Updated Aug. 13, 2019, 12:37 p.m.)
Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-2526
https://issues.apache.org/jira/browse/RANGER-2526
Repository: ranger
Description
-------
Steps to Reproduce:
1. Create a Policy with "Deny All Other Accesses" toggle button.(True/False)
2. Go to Audit>>Admin Tab, "Deny All Other Accesses" field does not display in created/updated Policy log.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 95342c3
security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyService.java d33b24b
Diff: https://reviews.apache.org/r/71279/diff/1/
Testing (updated)
-------
Build : success
When a access type policy is created, the log should be generated for the "Deny All Other Accesses" toggle button available on Policy page.
->Create a access type policy with "Deny All Other Accesses" toggle button(T/F).
->EXPECTED : Log should be generated for the same.
->ACTUAL : Logs getting generated for the same.
Log will not be generated for Masking and Row Level Filter policies for "Deny All Other Accesses" with this patch(NEED SUGGESTION FOR THIS THING).
Thanks,
Mateen Mansoori