You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Joseph Walton (JIRA)" <ji...@apache.org> on 2014/10/28 13:08:33 UTC
[jira] [Updated] (HTTPCLIENT-1575)
PoolingHttpClientConnectionManager.setMaxPerRoute accepts, but ignores,
HttpRoutes with default ports
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joseph Walton updated HTTPCLIENT-1575:
--------------------------------------
Attachment: HTTPCLIENT-1575-fail-when-setmaxperroute-uses-default-port.diff
> PoolingHttpClientConnectionManager.setMaxPerRoute accepts, but ignores, HttpRoutes with default ports
> -----------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1575
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1575
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Reporter: Joseph Walton
> Attachments: HTTPCLIENT-1575-fail-when-setmaxperroute-uses-default-port.diff
>
>
> {{PoolingHttpClientConnectionManager.setMaxPerRoute}} can be called with an {{HttpRoute}} constructed from an {{HttpHost}} using -1 to indicate the default port:
> {noformat}
> connectionManager.setMaxPerRoute(new HttpRoute(new HttpHost("localhost", -1, "http")));
> {noformat}
> However, when it's consulted during establishing a connection, the default port number will have been filled in:
> {noformat}
> getMaxPerRoute(new HttpRoute(new HttpHost("localhost", 80, "http)));
> {noformat}
> The lookup for the maximum is by object equality, so this route will get the default of 2.
> The simplest change here is to fail when an unspecified port is passed in, to indicate that this is not supported. Alternatively, pass all {{HttpHost}} ports through {{DefaultSchemePortResolver.INSTANCE}} before using them as keys in a map.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org