You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/19 13:14:28 UTC
[GitHub] [flink] dawidwys opened a new pull request #11141:
[FLINK-16033][table-api] Construct expressions through factory methods
dawidwys opened a new pull request #11141: [FLINK-16033][table-api] Construct expressions through factory methods
URL: https://github.com/apache/flink/pull/11141
## What is the purpose of the change
This commit is a preparation step for next commits. The only entry point
to constructing api expression are methods in ApiExpressionUtils. This
way we can put additional logic in the factory methods without polluting
the ctors.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11141:
[FLINK-16033][table-api] Construct expressions through factory methods
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11141: [FLINK-16033][table-api] Construct expressions through factory methods
URL: https://github.com/apache/flink/pull/11141#issuecomment-588223895
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8c3e6379e3b4ef7df9d1a5bf4d2752476f11d8df (Wed Feb 19 13:16:52 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys merged pull request #11141:
[FLINK-16033][table-api] Construct expressions through factory methods
Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #11141: [FLINK-16033][table-api] Construct expressions through factory methods
URL: https://github.com/apache/flink/pull/11141
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11141:
[FLINK-16033][table-api] Construct expressions through factory methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11141: [FLINK-16033][table-api] Construct expressions through factory methods
URL: https://github.com/apache/flink/pull/11141#issuecomment-588249074
<!--
Meta data
Hash:8c3e6379e3b4ef7df9d1a5bf4d2752476f11d8df Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149639632 TriggerType:PUSH TriggerID:8c3e6379e3b4ef7df9d1a5bf4d2752476f11d8df
-->
## CI report:
* 8c3e6379e3b4ef7df9d1a5bf4d2752476f11d8df Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149639632)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11141:
[FLINK-16033][table-api] Construct expressions through factory methods
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11141: [FLINK-16033][table-api] Construct expressions through factory methods
URL: https://github.com/apache/flink/pull/11141#issuecomment-588249074
<!--
Meta data
Hash:8c3e6379e3b4ef7df9d1a5bf4d2752476f11d8df Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8c3e6379e3b4ef7df9d1a5bf4d2752476f11d8df
-->
## CI report:
* 8c3e6379e3b4ef7df9d1a5bf4d2752476f11d8df UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11141:
[FLINK-16033][table-api] Construct expressions through factory methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11141: [FLINK-16033][table-api] Construct expressions through factory methods
URL: https://github.com/apache/flink/pull/11141#issuecomment-588249074
<!--
Meta data
Hash:8c3e6379e3b4ef7df9d1a5bf4d2752476f11d8df Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149639632 TriggerType:PUSH TriggerID:8c3e6379e3b4ef7df9d1a5bf4d2752476f11d8df
-->
## CI report:
* 8c3e6379e3b4ef7df9d1a5bf4d2752476f11d8df Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149639632)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services