You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by mice xia <mi...@tcloudcomputing.com> on 2012/07/31 13:46:15 UTC

Review Request: CS-15780 Global configuration 'account.cleanup.interval' is used by event purge thread

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6191/
-----------------------------------------------------------

Review request for cloudstack and Kishan Kavala.


Summary (updated)
-----------------

CS-15780 Global configuration 'account.cleanup.interval' is used by event purge thread


Description (updated)
-------

changes:
add a new global configuration event.purge.interval for event purge thread
leave account.cleanup.interval only for account cleanup thread


This addresses bug CS-15780.


Diffs (updated)
-----

  server/src/com/cloud/configuration/Config.java 6c0af1b 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java a02c3be 
  server/src/com/cloud/server/ManagementServerImpl.java bcdafa9 
  server/src/com/cloud/test/DatabaseConfig.java 6c2f44f 

Diff: https://reviews.apache.org/r/6191/diff/


Testing (updated)
-------

verified in UI


Thanks,

mice xia


Re: Review Request: CS-15780 Global configuration 'account.cleanup.interval' is used by event purge thread

Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6191/#review9758
-----------------------------------------------------------

Ship it!


Ship It!

- Nitin Mehta


On Aug. 2, 2012, 2:01 p.m., mice xia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6191/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2012, 2:01 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Nitin Mehta.
> 
> 
> Description
> -------
> 
> changes:
> add a new global configuration event.purge.interval for event purge thread
> leave account.cleanup.interval only for account cleanup thread
> 
> 
> This addresses bug CS-15780.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/configuration/Config.java b77537e 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java a02c3be 
>   server/src/com/cloud/server/ManagementServerImpl.java bcdafa9 
>   server/src/com/cloud/test/DatabaseConfig.java 6c2f44f 
>   setup/db/db/schema-303to40.sql 4ce8e65 
> 
> Diff: https://reviews.apache.org/r/6191/diff/
> 
> 
> Testing
> -------
> 
> verified in UI
> 
> 
> Thanks,
> 
> mice xia
> 
>


Re: Review Request: CS-15780 Global configuration 'account.cleanup.interval' is used by event purge thread

Posted by mice xia <mi...@tcloudcomputing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6191/
-----------------------------------------------------------

(Updated Aug. 2, 2012, 2:01 p.m.)


Review request for cloudstack, Kishan Kavala and Nitin Mehta.


Changes
-------

add db upgrade sql in schema-303to40.sql


Description
-------

changes:
add a new global configuration event.purge.interval for event purge thread
leave account.cleanup.interval only for account cleanup thread


This addresses bug CS-15780.


Diffs (updated)
-----

  server/src/com/cloud/configuration/Config.java b77537e 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java a02c3be 
  server/src/com/cloud/server/ManagementServerImpl.java bcdafa9 
  server/src/com/cloud/test/DatabaseConfig.java 6c2f44f 
  setup/db/db/schema-303to40.sql 4ce8e65 

Diff: https://reviews.apache.org/r/6191/diff/


Testing
-------

verified in UI


Thanks,

mice xia