You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/05 04:13:41 UTC
[GitHub] [airflow] Sonins opened a new pull request #17428: Fix elasticsearch-secret template port default function
Sonins opened a new pull request #17428:
URL: https://github.com/apache/airflow/pull/17428
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Default function in helm template should be "default GIVEN_VALUE DEFAULT_VALUE".
Refer `Using the default function` section below link.
https://helm.sh/docs/chart_template_guide/functions_and_pipelines/
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-896230424
> Cool. I think new issue for that will be necessary later.
Yep, we can do this as a follow up π.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on a change in pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on a change in pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#discussion_r685708706
##########
File path: chart/tests/test_elasticsearch_secret.py
##########
@@ -96,3 +96,24 @@ def test_should_correctly_handle_password_with_special_characters(self):
"http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
"elastichostname:80" == connection
)
+
+ def test_should_generate_secret_with_specified_port(self):
+ connection = self._get_connection(
+ {
+ "elasticsearch": {
+ "enabled": True,
+ "connection": {
+ "user": "username!@#$%%^&*()",
+ "pass": "password!@#$%%^&*()",
+ "host": "elastichostname",
+ "port": 9200,
+ },
+ }
+ }
+ )
+
+ assert (
+ "http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
+ "elastichostname:9200" == connection
+ )
Review comment:
OK, It turns out there is a little problem.
Without user and pass field, `<no+value>` is included in url string, like this.
`http://<no+value>:<no+value>@elastichostname:2222`
It makes test fail.
My mistake, I should've tested for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-898034985
Thanks for your suggest, @jedcunningham. The reason of static-check failure was formatting problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham closed pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
jedcunningham closed pull request #17428:
URL: https://github.com/apache/airflow/pull/17428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#discussion_r686234475
##########
File path: chart/tests/test_elasticsearch_secret.py
##########
@@ -96,3 +96,24 @@ def test_should_correctly_handle_password_with_special_characters(self):
"http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
"elastichostname:80" == connection
)
+
+ def test_should_generate_secret_with_specified_port(self):
+ connection = self._get_connection(
+ {
+ "elasticsearch": {
+ "enabled": True,
+ "connection": {
+ "user": "username!@#$%%^&*()",
+ "pass": "password!@#$%%^&*()",
+ "host": "elastichostname",
+ "port": 9200,
+ },
+ }
+ }
+ )
+
+ assert (
+ "http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
+ "elastichostname:9200" == connection
+ )
Review comment:
Ugh, no worries, just put in simple values for now. Might be another follow up we need to look at.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-895341826
> And also, Should default port be 80? As far as i know, Elasticsearch uses port 9200 as default.
Yeah, we should change it to 9200.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham closed pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
jedcunningham closed pull request #17428:
URL: https://github.com/apache/airflow/pull/17428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-898724073
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-898034985
Thanks for your suggest, @jedcunningham. Static-check failure is because of formatting problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-897026685
@Sonins, looks like there is a static check failure in `chart/tests/test_elasticsearch_secret.py`. I'd suggest that you [set up the pre-commit hooks](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks), they help catch these issues early π.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972
I wrote new test coverage. Here's my local test result.
with original template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
with fixed template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
And also, Should default port be 80? Elasticsearch uses port 9200 as default, as far as i know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-895740341
> Yeah, we should change it to 9200.
Cool. I think new issue for that will be necessary later.
Or is there any necessary change for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-896918356
I guess CI has an issue right now. All `Build image` phases are now pending, including other PRs.
Perhaps we should wait for CI problem to vanish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on a change in pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on a change in pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#discussion_r686419578
##########
File path: chart/tests/test_elasticsearch_secret.py
##########
@@ -96,3 +96,24 @@ def test_should_correctly_handle_password_with_special_characters(self):
"http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
"elastichostname:80" == connection
)
+
+ def test_should_generate_secret_with_specified_port(self):
+ connection = self._get_connection(
+ {
+ "elasticsearch": {
+ "enabled": True,
+ "connection": {
+ "user": "username!@#$%%^&*()",
+ "pass": "password!@#$%%^&*()",
+ "host": "elastichostname",
+ "port": 9200,
+ },
+ }
+ }
+ )
+
+ assert (
+ "http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
+ "elastichostname:9200" == connection
+ )
Review comment:
Resolve: https://github.com/apache/airflow/pull/17428/commits/ef2e80b6fe6c747b040ea7f4954f8ae95a7aefa1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on a change in pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on a change in pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#discussion_r685708706
##########
File path: chart/tests/test_elasticsearch_secret.py
##########
@@ -96,3 +96,24 @@ def test_should_correctly_handle_password_with_special_characters(self):
"http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
"elastichostname:80" == connection
)
+
+ def test_should_generate_secret_with_specified_port(self):
+ connection = self._get_connection(
+ {
+ "elasticsearch": {
+ "enabled": True,
+ "connection": {
+ "user": "username!@#$%%^&*()",
+ "pass": "password!@#$%%^&*()",
+ "host": "elastichostname",
+ "port": 9200,
+ },
+ }
+ }
+ )
+
+ assert (
+ "http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
+ "elastichostname:9200" == connection
+ )
Review comment:
OK, It turns out there is a little problem.
Without user and pass field, `<no+value>` is included in url string, like this.
`http://<no+value>:<no+value>@elastichostname:2222`
It makes test fail.
My mistake, I should've tested for this before i committed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-896858088
(I closed/reopened to try and get CI to run)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-895740341
> Yeah, we should change it to 9200.
Cool. I think new issue for that will be necessary later.
Or is there any necessary change for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972
I wrote new test coverage. Here's my local test result.
with original template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
with fixed template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
And also, Should default port be 80? As far as i know, Elasticsearch uses port 9200 as default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on a change in pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on a change in pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#discussion_r686419578
##########
File path: chart/tests/test_elasticsearch_secret.py
##########
@@ -96,3 +96,24 @@ def test_should_correctly_handle_password_with_special_characters(self):
"http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
"elastichostname:80" == connection
)
+
+ def test_should_generate_secret_with_specified_port(self):
+ connection = self._get_connection(
+ {
+ "elasticsearch": {
+ "enabled": True,
+ "connection": {
+ "user": "username!@#$%%^&*()",
+ "pass": "password!@#$%%^&*()",
+ "host": "elastichostname",
+ "port": 9200,
+ },
+ }
+ }
+ )
+
+ assert (
+ "http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
+ "elastichostname:9200" == connection
+ )
Review comment:
Resolve:
https://github.com/apache/airflow/pull/17428/commits/ef2e80b6fe6c747b040ea7f4954f8ae95a7aefa1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on a change in pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on a change in pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#discussion_r685708706
##########
File path: chart/tests/test_elasticsearch_secret.py
##########
@@ -96,3 +96,24 @@ def test_should_correctly_handle_password_with_special_characters(self):
"http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
"elastichostname:80" == connection
)
+
+ def test_should_generate_secret_with_specified_port(self):
+ connection = self._get_connection(
+ {
+ "elasticsearch": {
+ "enabled": True,
+ "connection": {
+ "user": "username!@#$%%^&*()",
+ "pass": "password!@#$%%^&*()",
+ "host": "elastichostname",
+ "port": 9200,
+ },
+ }
+ }
+ )
+
+ assert (
+ "http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
+ "elastichostname:9200" == connection
+ )
Review comment:
OK, It turns out it is not good.
Without user and pass field, `<no+value>` is included in url string, like this.
`http://<no+value>:<no+value>@elastichostname:2222`
It makes test fail.
My mistake, I should've tested for this.
##########
File path: chart/tests/test_elasticsearch_secret.py
##########
@@ -96,3 +96,24 @@ def test_should_correctly_handle_password_with_special_characters(self):
"http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
"elastichostname:80" == connection
)
+
+ def test_should_generate_secret_with_specified_port(self):
+ connection = self._get_connection(
+ {
+ "elasticsearch": {
+ "enabled": True,
+ "connection": {
+ "user": "username!@#$%%^&*()",
+ "pass": "password!@#$%%^&*()",
+ "host": "elastichostname",
+ "port": 9200,
+ },
+ }
+ }
+ )
+
+ assert (
+ "http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
+ "elastichostname:9200" == connection
+ )
Review comment:
OK, It turns out it is not that good.
Without user and pass field, `<no+value>` is included in url string, like this.
`http://<no+value>:<no+value>@elastichostname:2222`
It makes test fail.
My mistake, I should've tested for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
jedcunningham merged pull request #17428:
URL: https://github.com/apache/airflow/pull/17428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972
I wrote new test coverage. Here's my local test result.
with original template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
with fixed template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-898724516
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-896918356
I think CI has an issue right now. All `Build image` phases are now pending, including other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-893149835
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itβs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-896918356
> (I closed/reopened to try and get CI to run)
I guess CI has an issue right now. All `Build image` phases are now pending, including other PRs.
Perhaps we should wait for CI problem to vanish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972
I wrote new test coverage. Here's my local test result.
with original template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
with fixed template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
And also, Should default port be 80? As far as i know, Elasticsearch uses port 9200 as default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on a change in pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on a change in pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#discussion_r685708706
##########
File path: chart/tests/test_elasticsearch_secret.py
##########
@@ -96,3 +96,24 @@ def test_should_correctly_handle_password_with_special_characters(self):
"http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
"elastichostname:80" == connection
)
+
+ def test_should_generate_secret_with_specified_port(self):
+ connection = self._get_connection(
+ {
+ "elasticsearch": {
+ "enabled": True,
+ "connection": {
+ "user": "username!@#$%%^&*()",
+ "pass": "password!@#$%%^&*()",
+ "host": "elastichostname",
+ "port": 9200,
+ },
+ }
+ }
+ )
+
+ assert (
+ "http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
+ "elastichostname:9200" == connection
+ )
Review comment:
OK. It turns out it is not good.
Without user and pass field, `<no+value>` is included in url string, like this.
`http://<no+value>:<no+value>@elastichostname:2222`
It makes test fail.
My mistake, I should've tested for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-893149835
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itβs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972
I wrote new test coverage in test_elasticsearch_secret.py. Here's my local test result.
with original template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
with fixed template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
And also, Should default port be 80? As far as i know, Elasticsearch uses port 9200 as default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-893932430
Thank you for your review @jedcunningham .
I did the unit test using pytest in breeze environment, but I don't know how to attach the result to this PR in fancy style.
So, I just paste the result of pytest.
```
============================= test session starts ==============================
platform linux -- Python 3.6.14, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, configfile: pytest.ini
plugins: requests-mock-1.9.3, flaky-3.7.0, timeouts-1.2.1, anyio-3.3.0, forked-1.3.0, httpx-0.12.0, instafail-0.4.2, cov-2.12.1, xdist-2.3.0, rerunfailures-9.1.1, celery-4.4.7
setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s
collected 400 items
tests/test_airflow_common.py::AirflowCommon::test_annotations PASSED [ 0%]
tests/test_airflow_common.py::AirflowCommon::test_dags_mount_0 PASSED [ 0%]
tests/test_airflow_common.py::AirflowCommon::test_dags_mount_1 PASSED [ 0%]
tests/test_airflow_common.py::AirflowCommon::test_dags_mount_2 PASSED [ 1%]
tests/test_annotations.py::AnnotationsTest::test_service_account_annotations PASSED [ 1%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_annotations_on_airflow_pods_in_deployment PASSED [ 1%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_basic_deployment_without_default_users PASSED [ 1%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_basic_deployments PASSED [ 2%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_chart_is_consistent_with_official_airflow_image PASSED [ 2%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_dags_access_mode PASSED [ 2%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_0_airflow PASSED [ 2%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_1_pod_template PASSED [ 3%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_2_flower PASSED [ 3%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_3_statsd PASSED [ 3%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_4_redis PASSED [ 3%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_5_pgbouncer PASSED [ 4%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_6_pgbouncerExporter PASSED [ 4%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_7_gitSync PASSED [ 4%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_labels_are_valid PASSED [ 4%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_network_policies_are_valid PASSED [ 5%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_unsupported_executor PASSED [ 5%]
tests/test_celery_kubernetes_executor.py::CeleryKubernetesExecutorTest::test_should_create_a_worker_deployment_with_the_celery_executor PASSED [ 5%]
tests/test_celery_kubernetes_executor.py::CeleryKubernetesExecutorTest::test_should_create_a_worker_deployment_with_the_celery_kubernetes_executor PASSED [ 5%]
tests/test_chart_quality.py::ChartQualityTest::test_values_validate_schema PASSED [ 6%]
tests/test_cleanup_pods.py::CleanupPodsTest::test_should_change_image_when_set_airflow_image PASSED [ 6%]
tests/test_cleanup_pods.py::CleanupPodsTest::test_should_create_cronjob_for_enabled_cleanup PASSED [ 6%]
tests/test_cleanup_pods.py::CleanupPodsTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 6%]
tests/test_configmap.py::ConfigmapTest::test_airflow_local_settings PASSED [ 7%]
tests/test_configmap.py::ConfigmapTest::test_kerberos_config_available_with_celery_executor PASSED [ 7%]
tests/test_configmap.py::ConfigmapTest::test_multiple_annotations PASSED [ 7%]
tests/test_configmap.py::ConfigmapTest::test_no_airflow_local_settings_by_default PASSED [ 7%]
tests/test_configmap.py::ConfigmapTest::test_single_annotation PASSED [ 8%]
tests/test_create_user_job.py::CreateUserJobTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 8%]
tests/test_create_user_job.py::CreateUserJobTest::test_should_run_by_default PASSED [ 8%]
tests/test_create_user_job.py::CreateUserJobTest::test_should_support_annotations PASSED [ 8%]
tests/test_dags_persistent_volume_claim.py::DagsPersistentVolumeClaimTest::test_should_generate_a_document_if_persistence_is_enabled_and_not_using_an_existing_claim PASSED [ 9%]
tests/test_dags_persistent_volume_claim.py::DagsPersistentVolumeClaimTest::test_should_not_generate_a_document_if_persistence_is_disabled PASSED [ 9%]
tests/test_dags_persistent_volume_claim.py::DagsPersistentVolumeClaimTest::test_should_not_generate_a_document_when_using_an_existing_claim PASSED [ 9%]
tests/test_dags_persistent_volume_claim.py::DagsPersistentVolumeClaimTest::test_should_set_pvc_details_correctly PASSED [ 9%]
tests/test_elasticsearch_secret.py::ElasticsearchSecretTest::test_should_correctly_handle_password_with_special_characters PASSED [ 10%]
tests/test_elasticsearch_secret.py::ElasticsearchSecretTest::test_should_not_generate_a_document_if_elasticsearch_disabled PASSED [ 10%]
tests/test_elasticsearch_secret.py::ElasticsearchSecretTest::test_should_raise_error_when_conflicting_options PASSED [ 10%]
tests/test_elasticsearch_secret.py::ElasticsearchSecretTest::test_should_raise_error_when_connection_not_provided PASSED [ 10%]
tests/test_extra_configmaps_secrets.py::ExtraConfigMapsSecretsTest::test_extra_configmaps PASSED [ 11%]
tests/test_extra_configmaps_secrets.py::ExtraConfigMapsSecretsTest::test_extra_secrets PASSED [ 11%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_0 PASSED [ 11%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_1 PASSED [ 11%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_2 PASSED [ 12%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_3 PASSED [ 12%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_4 PASSED [ 12%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_from_0 PASSED [ 12%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_from_1 PASSED [ 13%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_from_2 PASSED [ 13%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_from_3 PASSED [ 13%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_from_4 PASSED [ 13%]
tests/test_flower.py::TestFlowerDeployment::test_create_flower[CeleryExecutor-False-False] PASSED [ 14%]
tests/test_flower.py::TestFlowerDeployment::test_create_flower[CeleryKubernetesExecutor-False-False] PASSED [ 14%]
tests/test_flower.py::TestFlowerDeployment::test_create_flower[KubernetesExecutor-False-False] PASSED [ 14%]
tests/test_flower.py::TestFlowerDeployment::test_create_flower[CeleryExecutor-True-True] PASSED [ 14%]
tests/test_flower.py::TestFlowerDeployment::test_create_flower[CeleryKubernetesExecutor-True-True] PASSED [ 15%]
tests/test_flower.py::TestFlowerDeployment::test_create_flower[KubernetesExecutor-True-False] PASSED [ 15%]
tests/test_flower.py::TestFlowerDeployment::test_args_with_airflow_version[2.0.2-airflow celery flower] PASSED [ 15%]
tests/test_flower.py::TestFlowerDeployment::test_args_with_airflow_version[1.10.14-airflow flower] PASSED [ 15%]
tests/test_flower.py::TestFlowerDeployment::test_args_with_airflow_version[1.9.0-airflow flower] PASSED [ 16%]
tests/test_flower.py::TestFlowerDeployment::test_args_with_airflow_version[2.1.0-airflow celery flower] PASSED [ 16%]
tests/test_flower.py::TestFlowerDeployment::test_command_and_args_overrides[None-None] PASSED [ 16%]
tests/test_flower.py::TestFlowerDeployment::test_command_and_args_overrides[None-args1] PASSED [ 16%]
tests/test_flower.py::TestFlowerDeployment::test_command_and_args_overrides[command2-None] PASSED [ 17%]
tests/test_flower.py::TestFlowerDeployment::test_command_and_args_overrides[command3-args3] PASSED [ 17%]
tests/test_flower.py::TestFlowerDeployment::test_command_and_args_overrides_are_templated PASSED [ 17%]
tests/test_flower.py::TestFlowerDeployment::test_should_create_flower_deployment_with_authorization PASSED [ 17%]
tests/test_flower.py::TestFlowerDeployment::test_should_create_flower_deployment_without_authorization PASSED [ 18%]
tests/test_flower.py::TestFlowerDeployment::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 18%]
tests/test_flower.py::TestFlowerDeployment::test_flower_resources_are_configurable PASSED [ 18%]
tests/test_flower.py::TestFlowerDeployment::test_flower_resources_are_not_added_by_default PASSED [ 18%]
tests/test_flower.py::TestFlowerDeployment::test_should_add_extra_containers PASSED [ 19%]
tests/test_flower.py::TestFlowerDeployment::test_should_add_extra_volumes PASSED [ 19%]
tests/test_flower.py::TestFlowerService::test_create_flower[CeleryExecutor-False-False] PASSED [ 19%]
tests/test_flower.py::TestFlowerService::test_create_flower[CeleryKubernetesExecutor-False-False] PASSED [ 19%]
tests/test_flower.py::TestFlowerService::test_create_flower[KubernetesExecutor-False-False] PASSED [ 20%]
tests/test_flower.py::TestFlowerService::test_create_flower[CeleryExecutor-True-True] PASSED [ 20%]
tests/test_flower.py::TestFlowerService::test_create_flower[CeleryKubernetesExecutor-True-True] PASSED [ 20%]
tests/test_flower.py::TestFlowerService::test_create_flower[KubernetesExecutor-True-False] PASSED [ 20%]
tests/test_flower.py::TestFlowerService::test_default_service PASSED [ 21%]
tests/test_flower.py::TestFlowerService::test_overrides PASSED [ 21%]
tests/test_flower.py::TestFlowerService::test_ports_overrides[ports0-expected_ports0] PASSED [ 21%]
tests/test_flower.py::TestFlowerService::test_ports_overrides[ports1-expected_ports1] PASSED [ 21%]
tests/test_flower.py::TestFlowerService::test_ports_overrides[ports2-expected_ports2] PASSED [ 22%]
tests/test_flower.py::TestFlowerService::test_ports_overrides[ports3-expected_ports3] PASSED [ 22%]
tests/test_flower.py::TestFlowerNetworkPolicy::test_off_by_default PASSED [ 22%]
tests/test_flower.py::TestFlowerNetworkPolicy::test_defaults PASSED [ 22%]
tests/test_flower.py::TestFlowerNetworkPolicy::test_ports_overrides[ports0-expected_ports0] PASSED [ 23%]
tests/test_flower.py::TestFlowerNetworkPolicy::test_ports_overrides[ports1-expected_ports1] PASSED [ 23%]
tests/test_flower.py::TestFlowerNetworkPolicy::test_ports_overrides[ports2-expected_ports2] PASSED [ 23%]
tests/test_flower.py::TestFlowerNetworkPolicy::test_deprecated_from_param PASSED [ 23%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_extra_volume_and_git_sync_extra_volume_mount PASSED [ 24%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_resources_are_configurable PASSED [ 24%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_should_add_dags_volume PASSED [ 24%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_should_add_env PASSED [ 24%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_should_add_extra_volume_and_extra_volume_mount PASSED [ 25%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_should_set_the_volume_claim_correctly_when_using_an_existing_claim PASSED [ 25%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_should_set_username_and_pass_env_variables PASSED [ 25%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_validate_if_ssh_params_are_added PASSED [ 25%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_validate_the_git_sync_container_spec PASSED [ 26%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_git_sync_with_different_airflow_versions_0_2_0_0 PASSED [ 26%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_git_sync_with_different_airflow_versions_1_2_0_2 PASSED [ 26%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_git_sync_with_different_airflow_versions_2_1_10_14 PASSED [ 26%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_git_sync_with_different_airflow_versions_3_1_9_0 PASSED [ 27%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_git_sync_with_different_airflow_versions_4_2_1_0 PASSED [ 27%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_resources_are_configurable PASSED [ 27%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_should_add_dags_volume_to_the_webserver_if_git_sync_and_persistence_is_enabled PASSED [ 27%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_should_add_dags_volume_to_the_webserver_if_git_sync_is_enabled_and_persistence_is_disabled PASSED [ 28%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_should_add_env PASSED [ 28%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_should_add_git_sync_container_to_webserver_if_persistence_is_not_enabled_but_git_sync_is PASSED [ 28%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_should_have_service_account_defined PASSED [ 28%]
tests/test_git_sync_worker.py::GitSyncWorkerTest::test_resources_are_configurable PASSED [ 29%]
tests/test_git_sync_worker.py::GitSyncWorkerTest::test_should_add_dags_volume_to_the_worker_if_git_sync_and_persistence_is_enabled PASSED [ 29%]
tests/test_git_sync_worker.py::GitSyncWorkerTest::test_should_add_dags_volume_to_the_worker_if_git_sync_is_enabled_and_persistence_is_disabled PASSED [ 29%]
tests/test_git_sync_worker.py::GitSyncWorkerTest::test_should_add_env PASSED [ 29%]
tests/test_git_sync_worker.py::GitSyncWorkerTest::test_should_add_git_sync_container_to_worker_if_persistence_is_not_enabled_but_git_sync_is PASSED [ 30%]
tests/test_git_sync_worker.py::GitSyncWorkerTest::test_should_not_add_sync_container_to_worker_if_git_sync_and_persistence_are_enabled PASSED [ 30%]
tests/test_ingress_flower.py::IngressFlowerTest::test_should_allow_more_than_one_annotation PASSED [ 30%]
tests/test_ingress_flower.py::IngressFlowerTest::test_should_pass_validation_with_just_ingress_enabled PASSED [ 30%]
tests/test_ingress_web.py::IngressWebTest::test_should_allow_more_than_one_annotation PASSED [ 31%]
tests/test_ingress_web.py::IngressWebTest::test_should_pass_validation_with_just_ingress_enabled PASSED [ 31%]
tests/test_keda.py::TestKeda::test_keda_disabled_by_default PASSED [ 31%]
tests/test_keda.py::TestKeda::test_keda_enabled_0_CeleryExecutor PASSED [ 31%]
tests/test_keda.py::TestKeda::test_keda_enabled_1_CeleryKubernetesExecutor PASSED [ 32%]
tests/test_keda.py::TestKeda::test_keda_concurrency_0_CeleryExecutor PASSED [ 32%]
tests/test_keda.py::TestKeda::test_keda_concurrency_1_CeleryExecutor PASSED [ 32%]
tests/test_keda.py::TestKeda::test_keda_concurrency_2_CeleryKubernetesExecutor PASSED [ 32%]
tests/test_keda.py::TestKeda::test_keda_concurrency_3_CeleryKubernetesExecutor PASSED [ 33%]
tests/test_keda.py::TestKeda::test_persistence_0_enabled PASSED [ 33%]
tests/test_keda.py::TestKeda::test_persistence_1_not_enabled PASSED [ 33%]
tests/test_kerberos.py::KerberosTest::test_keberos_sidecar_resources_are_not_added_by_default PASSED [ 33%]
tests/test_kerberos.py::KerberosTest::test_kerberos_envs_available_in_worker_with_persistence PASSED [ 34%]
tests/test_kerberos.py::KerberosTest::test_kerberos_not_mentioned_in_render_if_disabled PASSED [ 34%]
tests/test_kerberos.py::KerberosTest::test_kerberos_sidecar_resources PASSED [ 34%]
tests/test_limit_ranges.py::LimitRangesTest::test_limit_ranges_are_not_added_by_default PASSED [ 34%]
tests/test_limit_ranges.py::LimitRangesTest::test_limit_ranges_template PASSED [ 35%]
tests/test_logs_persistent_volume_claim.py::LogsPersistentVolumeClaimTest::test_should_generate_a_document_if_persistence_is_enabled_and_not_using_an_existing_claim PASSED [ 35%]
tests/test_logs_persistent_volume_claim.py::LogsPersistentVolumeClaimTest::test_should_not_generate_a_document_if_persistence_is_disabled PASSED [ 35%]
tests/test_logs_persistent_volume_claim.py::LogsPersistentVolumeClaimTest::test_should_not_generate_a_document_when_using_an_existing_claim PASSED [ 35%]
tests/test_logs_persistent_volume_claim.py::LogsPersistentVolumeClaimTest::test_should_set_pvc_details_correctly PASSED [ 36%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_default_connection PASSED [ 36%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_should_correctly_handle_password_with_special_characters PASSED [ 36%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_should_correctly_use_non_chart_database PASSED [ 36%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_should_not_generate_a_document_if_using_existing_secret PASSED [ 37%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_should_set_pgbouncer_overrides_when_enabled PASSED [ 37%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_should_set_pgbouncer_overrides_with_non_chart_database_when_enabled PASSED [ 37%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_should_support_non_postgres_db PASSED [ 37%]
tests/test_migrate_database_job.py::MigrateDatabaseJobTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 38%]
tests/test_migrate_database_job.py::MigrateDatabaseJobTest::test_should_run_by_default PASSED [ 38%]
tests/test_migrate_database_job.py::MigrateDatabaseJobTest::test_should_support_annotations PASSED [ 38%]
tests/test_pgbouncer.py::PgbouncerTest::test_existing_secret PASSED [ 38%]
tests/test_pgbouncer.py::PgbouncerTest::test_metrics_exporter_resources PASSED [ 39%]
tests/test_pgbouncer.py::PgbouncerTest::test_no_existing_secret PASSED [ 39%]
tests/test_pgbouncer.py::PgbouncerTest::test_pgbouncer_resources_are_configurable PASSED [ 39%]
tests/test_pgbouncer.py::PgbouncerTest::test_pgbouncer_resources_are_not_added_by_default PASSED [ 39%]
tests/test_pgbouncer.py::PgbouncerTest::test_pgbouncer_resources_not_created_by_default_0_pgbouncer_deployment PASSED [ 40%]
tests/test_pgbouncer.py::PgbouncerTest::test_pgbouncer_resources_not_created_by_default_1_pgbouncer_service PASSED [ 40%]
tests/test_pgbouncer.py::PgbouncerTest::test_pgbouncer_service_extra_annotations PASSED [ 40%]
tests/test_pgbouncer.py::PgbouncerTest::test_pgbouncer_service_with_custom_ports PASSED [ 40%]
tests/test_pgbouncer.py::PgbouncerTest::test_should_create_pgbouncer PASSED [ 41%]
tests/test_pgbouncer.py::PgbouncerTest::test_should_create_pgbouncer_service PASSED [ 41%]
tests/test_pgbouncer.py::PgbouncerTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 41%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_config_defaults PASSED [ 41%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_config_not_created_by_default PASSED [ 42%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_config_overrides PASSED [ 42%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_databases_default PASSED [ 42%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_databases_override PASSED [ 42%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_extra_ini_configs PASSED [ 43%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_ssl_config PASSED [ 43%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_ssl_defaults_dont_create_cert_secret PASSED [ 43%]
tests/test_pgbouncer.py::PgbouncerExporterTest::test_default_exporter_secret PASSED [ 43%]
tests/test_pgbouncer.py::PgbouncerExporterTest::test_exporter_secret_with_overrides PASSED [ 44%]
tests/test_pgbouncer.py::PgbouncerExporterTest::test_secret_not_created_by_default PASSED [ 44%]
tests/test_pod_launcher_role.py::PodLauncherTest::test_pod_launcher_role_0_CeleryKubernetesExecutor PASSED [ 44%]
tests/test_pod_launcher_role.py::PodLauncherTest::test_pod_launcher_role_1_KubernetesExecutor PASSED [ 44%]
tests/test_pod_launcher_role.py::PodLauncherTest::test_pod_launcher_role_2_CeleryExecutor PASSED [ 45%]
tests/test_pod_launcher_role.py::PodLauncherTest::test_pod_launcher_role_3_LocalExecutor PASSED [ 45%]
tests/test_pod_launcher_role.py::PodLauncherTest::test_pod_launcher_role_4_LocalExecutor PASSED [ 45%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_airflow_local_settings PASSED [ 45%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_airflow_pod_annotations PASSED [ 46%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_dags_mount_0 PASSED [ 46%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_dags_mount_1 PASSED [ 46%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_dags_mount_2 PASSED [ 46%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_empty_resources PASSED [ 47%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_logs_persistence_changes_volume_0 PASSED [ 47%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_logs_persistence_changes_volume_1 PASSED [ 47%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_logs_persistence_changes_volume_2 PASSED [ 47%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_mount_airflow_cfg PASSED [ 48%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_no_airflow_local_settings_by_default PASSED [ 48%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_add_an_init_container_if_git_sync_is_true PASSED [ 48%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_add_env_for_gitsync PASSED [ 48%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_add_extra_init_containers PASSED [ 49%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_add_fsgroup_to_the_pod_template PASSED [ 49%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_add_pod_labels PASSED [ 49%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_add_resources PASSED [ 49%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_create_valid_affinity_and_node_selector PASSED [ 50%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 50%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_create_valid_volume_mount_and_volume PASSED [ 50%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_not_add_init_container_if_dag_persistence_is_true PASSED [ 50%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_set_a_custom_image_in_pod_template PASSED [ 51%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_set_the_dags_volume_claim_correctly_when_using_an_existing_claim PASSED [ 51%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_set_username_and_pass_env_variables PASSED [ 51%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_use_empty_dir_for_gitsync_without_persistence PASSED [ 51%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_work PASSED [ 52%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_validate_if_ssh_known_hosts_are_added PASSED [ 52%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_validate_if_ssh_params_are_added PASSED [ 52%]
tests/test_rbac.py::RBACTest::test_deployments_no_rbac_no_sa PASSED [ 52%]
tests/test_rbac.py::RBACTest::test_deployments_no_rbac_with_sa PASSED [ 53%]
tests/test_rbac.py::RBACTest::test_deployments_with_rbac_no_sa PASSED [ 53%]
tests/test_rbac.py::RBACTest::test_deployments_with_rbac_with_sa PASSED [ 53%]
tests/test_rbac.py::RBACTest::test_service_account_custom_names PASSED [ 53%]
tests/test_rbac.py::RBACTest::test_service_account_custom_names_in_objects PASSED [ 54%]
tests/test_rbac.py::RBACTest::test_service_account_without_resource PASSED [ 54%]
tests/test_redis.py::RedisTest::test_default_redis_secrets_created_with_non_celery_executor PASSED [ 54%]
tests/test_redis.py::RedisTest::test_external_redis_broker_url_0_CeleryExecutor PASSED [ 54%]
tests/test_redis.py::RedisTest::test_external_redis_broker_url_1_CeleryKubernetesExecutor PASSED [ 55%]
tests/test_redis.py::RedisTest::test_external_redis_broker_url_secret_name_0_CeleryExecutor PASSED [ 55%]
tests/test_redis.py::RedisTest::test_external_redis_broker_url_secret_name_1_CeleryKubernetesExecutor PASSED [ 55%]
tests/test_redis.py::RedisTest::test_redis_by_chart_default_0_CeleryExecutor PASSED [ 55%]
tests/test_redis.py::RedisTest::test_redis_by_chart_default_1_CeleryKubernetesExecutor PASSED [ 56%]
tests/test_redis.py::RedisTest::test_redis_by_chart_password_0_CeleryExecutor PASSED [ 56%]
tests/test_redis.py::RedisTest::test_redis_by_chart_password_1_CeleryKubernetesExecutor PASSED [ 56%]
tests/test_redis.py::RedisTest::test_redis_by_chart_password_secret_name_0_CeleryExecutor PASSED [ 56%]
tests/test_redis.py::RedisTest::test_redis_by_chart_password_secret_name_1_CeleryKubernetesExecutor PASSED [ 57%]
tests/test_redis.py::RedisTest::test_redis_by_chart_password_secret_name_missing_broker_url_secret_name_0_CeleryExecutor PASSED [ 57%]
tests/test_redis.py::RedisTest::test_redis_by_chart_password_secret_name_missing_broker_url_secret_name_1_CeleryKubernetesExecutor PASSED [ 57%]
tests/test_redis.py::RedisTest::test_redis_resources_are_configurable PASSED [ 57%]
tests/test_redis.py::RedisTest::test_redis_resources_are_not_added_by_default PASSED [ 58%]
tests/test_redis.py::RedisTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 58%]
tests/test_resource_quota.py::ResourceQuotaTest::test_resource_quota_are_not_added_by_default PASSED [ 58%]
tests/test_resource_quota.py::ResourceQuotaTest::test_resource_quota_template PASSED [ 58%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_default_connection PASSED [ 59%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_a_document_be_generated_for_executor_0_CeleryExecutor PASSED [ 59%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_a_document_be_generated_for_executor_1_CeleryKubernetesExecutor PASSED [ 59%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_a_document_be_generated_for_executor_2_LocalExecutor PASSED [ 59%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_correctly_handle_password_with_special_characters PASSED [ 60%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_correctly_use_non_chart_database PASSED [ 60%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_correctly_use_non_chart_database_when_both_db_are_external PASSED [ 60%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_default_to_custom_metadata_db_connection PASSED [ 60%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_default_to_custom_metadata_db_connection_with_pgbouncer_overrides PASSED [ 61%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_not_generate_a_document_if_using_existing_secret PASSED [ 61%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_set_pgbouncer_overrides_when_enabled PASSED [ 61%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_set_pgbouncer_overrides_with_non_chart_database_when_enabled PASSED [ 61%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_support_non_postgres_db PASSED [ 62%]
tests/test_scheduler.py::SchedulerTest::test_airflow_local_settings PASSED [ 62%]
tests/test_scheduler.py::SchedulerTest::test_command_and_args_overrides_0 PASSED [ 62%]
tests/test_scheduler.py::SchedulerTest::test_command_and_args_overrides_1 PASSED [ 62%]
tests/test_scheduler.py::SchedulerTest::test_command_and_args_overrides_2 PASSED [ 63%]
tests/test_scheduler.py::SchedulerTest::test_command_and_args_overrides_3 PASSED [ 63%]
tests/test_scheduler.py::SchedulerTest::test_command_and_args_overrides_are_templated PASSED [ 63%]
tests/test_scheduler.py::SchedulerTest::test_dags_gitsync_sidecar_and_init_container_0 PASSED [ 63%]
tests/test_scheduler.py::SchedulerTest::test_dags_gitsync_sidecar_and_init_container_1 PASSED [ 64%]
tests/test_scheduler.py::SchedulerTest::test_default_command_and_args PASSED [ 64%]
tests/test_scheduler.py::SchedulerTest::test_livenessprobe_values_are_configurable PASSED [ 64%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_collector_can_be_disabled PASSED [ 64%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_collector_default_command_and_args PASSED [ 65%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_command_and_args_overrides_0 PASSED [ 65%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_command_and_args_overrides_1 PASSED [ 65%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_command_and_args_overrides_2 PASSED [ 65%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_command_and_args_overrides_3 PASSED [ 66%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_command_and_args_overrides_are_templated PASSED [ 66%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_resources PASSED [ 66%]
tests/test_scheduler.py::SchedulerTest::test_logs_persistence_changes_volume_0 PASSED [ 66%]
tests/test_scheduler.py::SchedulerTest::test_logs_persistence_changes_volume_1 PASSED [ 67%]
tests/test_scheduler.py::SchedulerTest::test_logs_persistence_changes_volume_2 PASSED [ 67%]
tests/test_scheduler.py::SchedulerTest::test_no_airflow_local_settings_by_default PASSED [ 67%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_kind_0_CeleryExecutor PASSED [ 67%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_kind_1_CeleryExecutor PASSED [ 68%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_kind_2_CeleryKubernetesExecutor PASSED [ 68%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_kind_3_KubernetesExecutor PASSED [ 68%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_kind_4_LocalExecutor PASSED [ 68%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_kind_5_LocalExecutor PASSED [ 69%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_resources_are_configurable PASSED [ 69%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_resources_are_not_added_by_default PASSED [ 69%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_0_LocalExecutor PASSED [ 69%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_1_LocalExecutor PASSED [ 70%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_2_LocalExecutor PASSED [ 70%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_3_CeleryExecutor PASSED [ 70%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_4_CeleryExecutor PASSED [ 70%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_5_CeleryExecutor PASSED [ 71%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_6_CeleryExecutor PASSED [ 71%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_update_strategy_0_CeleryExecutor PASSED [ 71%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_update_strategy_1_CeleryExecutor PASSED [ 71%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_update_strategy_2_LocalExecutor PASSED [ 72%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_update_strategy_3_LocalExecutor PASSED [ 72%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_update_strategy_4_LocalExecutor PASSED [ 72%]
tests/test_scheduler.py::SchedulerTest::test_should_add_extra_containers PASSED [ 72%]
tests/test_scheduler.py::SchedulerTest::test_should_add_extra_init_containers PASSED [ 73%]
tests/test_scheduler.py::SchedulerTest::test_should_add_extra_volume_and_extra_volume_mount PASSED [ 73%]
tests/test_scheduler.py::SchedulerTest::test_should_create_default_affinity PASSED [ 73%]
tests/test_scheduler.py::SchedulerTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 73%]
tests/test_statsd.py::StatsdTest::test_should_add_volume_and_volume_mount_when_exist_extra_mappings PASSED [ 74%]
tests/test_statsd.py::StatsdTest::test_should_create_statsd_default PASSED [ 74%]
tests/test_statsd.py::StatsdTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 74%]
tests/test_statsd.py::StatsdTest::test_stastd_resources_are_configurable PASSED [ 74%]
tests/test_statsd.py::StatsdTest::test_statsd_resources_are_not_added_by_default PASSED [ 75%]
tests/test_webserver.py::WebserverDeploymentTest::test_airflow_local_settings PASSED [ 75%]
tests/test_webserver.py::WebserverDeploymentTest::test_command_and_args_overrides_0 PASSED [ 75%]
tests/test_webserver.py::WebserverDeploymentTest::test_command_and_args_overrides_1 PASSED [ 75%]
tests/test_webserver.py::WebserverDeploymentTest::test_command_and_args_overrides_2 PASSED [ 76%]
tests/test_webserver.py::WebserverDeploymentTest::test_command_and_args_overrides_3 PASSED [ 76%]
tests/test_webserver.py::WebserverDeploymentTest::test_command_and_args_overrides_are_templated PASSED [ 76%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_gitsync_volume_and_sidecar_and_init_container PASSED [ 76%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_mount_0_1_10_15 PASSED [ 77%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_mount_1_1_10_15 PASSED [ 77%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_mount_2_1_10_15 PASSED [ 77%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_persistence_volume_no_sidecar_0 PASSED [ 77%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_persistence_volume_no_sidecar_1 PASSED [ 78%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_persistence_volume_no_sidecar_2 PASSED [ 78%]
tests/test_webserver.py::WebserverDeploymentTest::test_default_command_and_args PASSED [ 78%]
tests/test_webserver.py::WebserverDeploymentTest::test_default_update_strategy_0_2_0_2 PASSED [ 78%]
tests/test_webserver.py::WebserverDeploymentTest::test_default_update_strategy_1_1_10_14 PASSED [ 79%]
tests/test_webserver.py::WebserverDeploymentTest::test_default_update_strategy_2_1_9_0 PASSED [ 79%]
tests/test_webserver.py::WebserverDeploymentTest::test_default_update_strategy_3_2_1_0 PASSED [ 79%]
tests/test_webserver.py::WebserverDeploymentTest::test_logs_persistence_adds_volume_and_mount_0 PASSED [ 79%]
tests/test_webserver.py::WebserverDeploymentTest::test_logs_persistence_adds_volume_and_mount_1 PASSED [ 80%]
tests/test_webserver.py::WebserverDeploymentTest::test_logs_persistence_adds_volume_and_mount_2 PASSED [ 80%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_airflow_local_settings_by_default PASSED [ 80%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_0_1_10_15 PASSED [ 80%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_1_1_10_15 PASSED [ 81%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_2_1_10_15 PASSED [ 81%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_3_2_0_0 PASSED [ 81%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_4_2_0_0 PASSED [ 81%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_5_2_0_0 PASSED [ 82%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_6_2_0_0 PASSED [ 82%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_7_2_0_0 PASSED [ 82%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_add_extra_containers PASSED [ 82%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_add_extra_init_containers PASSED [ 83%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_add_host_header_to_liveness_and_readiness_probes PASSED [ 83%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_add_path_to_liveness_and_readiness_probes PASSED [ 83%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_add_volume_and_volume_mount_when_exist_webserver_config PASSED [ 83%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_create_default_affinity PASSED [ 84%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 84%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_not_contain_host_header_0 PASSED [ 84%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_not_contain_host_header_1 PASSED [ 84%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_use_templated_base_url_for_probes PASSED [ 85%]
tests/test_webserver.py::WebserverDeploymentTest::test_update_strategy PASSED [ 85%]
tests/test_webserver.py::WebserverDeploymentTest::test_webserver_resources_are_configurable PASSED [ 85%]
tests/test_webserver.py::WebserverDeploymentTest::test_webserver_resources_are_not_added_by_default PASSED [ 85%]
tests/test_webserver.py::WebserverServiceTest::test_default_service PASSED [ 86%]
tests/test_webserver.py::WebserverServiceTest::test_overrides PASSED [ 86%]
tests/test_webserver.py::WebserverServiceTest::test_ports_overrides_0 PASSED [ 86%]
tests/test_webserver.py::WebserverServiceTest::test_ports_overrides_1 PASSED [ 86%]
tests/test_webserver.py::WebserverServiceTest::test_ports_overrides_2 PASSED [ 87%]
tests/test_webserver.py::WebserverServiceTest::test_ports_overrides_3 PASSED [ 87%]
tests/test_webserver.py::WebserverConfigmapTest::test_no_webserver_config_configmap_by_default PASSED [ 87%]
tests/test_webserver.py::WebserverConfigmapTest::test_webserver_config_configmap PASSED [ 87%]
tests/test_webserver.py::WebserverNetworkPolicyTest::test_defaults PASSED [ 88%]
tests/test_webserver.py::WebserverNetworkPolicyTest::test_deprecated_from_param PASSED [ 88%]
tests/test_webserver.py::WebserverNetworkPolicyTest::test_off_by_default PASSED [ 88%]
tests/test_webserver.py::WebserverNetworkPolicyTest::test_ports_overrides_0 PASSED [ 88%]
tests/test_webserver.py::WebserverNetworkPolicyTest::test_ports_overrides_1 PASSED [ 89%]
tests/test_webserver.py::WebserverNetworkPolicyTest::test_ports_overrides_2 PASSED [ 89%]
tests/test_worker.py::WorkerTest::test_airflow_local_settings PASSED [ 89%]
tests/test_worker.py::WorkerTest::test_airflow_local_settings_kerberos_sidecar PASSED [ 89%]
tests/test_worker.py::WorkerTest::test_command_and_args_overrides_0 PASSED [ 90%]
tests/test_worker.py::WorkerTest::test_command_and_args_overrides_1 PASSED [ 90%]
tests/test_worker.py::WorkerTest::test_command_and_args_overrides_2 PASSED [ 90%]
tests/test_worker.py::WorkerTest::test_command_and_args_overrides_3 PASSED [ 90%]
tests/test_worker.py::WorkerTest::test_command_and_args_overrides_are_templated PASSED [ 91%]
tests/test_worker.py::WorkerTest::test_dags_gitsync_sidecar_and_init_container PASSED [ 91%]
tests/test_worker.py::WorkerTest::test_dags_gitsync_with_persistence_no_sidecar_or_init_container PASSED [ 91%]
tests/test_worker.py::WorkerTest::test_default_command_and_args_airflow_version_0_1_9_0 PASSED [ 91%]
tests/test_worker.py::WorkerTest::test_default_command_and_args_airflow_version_1_1_10_14 PASSED [ 92%]
tests/test_worker.py::WorkerTest::test_default_command_and_args_airflow_version_2_2_0_2 PASSED [ 92%]
tests/test_worker.py::WorkerTest::test_default_command_and_args_airflow_version_3_2_1_0 PASSED [ 92%]
tests/test_worker.py::WorkerTest::test_log_groomer_command_and_args_overrides_0 PASSED [ 92%]
tests/test_worker.py::WorkerTest::test_log_groomer_command_and_args_overrides_1 PASSED [ 93%]
tests/test_worker.py::WorkerTest::test_log_groomer_command_and_args_overrides_2 PASSED [ 93%]
tests/test_worker.py::WorkerTest::test_log_groomer_command_and_args_overrides_3 PASSED [ 93%]
tests/test_worker.py::WorkerTest::test_log_groomer_command_and_args_overrides_are_templated PASSED [ 93%]
tests/test_worker.py::WorkerTest::test_log_groomer_default_command_and_args PASSED [ 94%]
tests/test_worker.py::WorkerTest::test_log_groomer_resources PASSED [ 94%]
tests/test_worker.py::WorkerTest::test_logs_persistence_changes_volume_0 PASSED [ 94%]
tests/test_worker.py::WorkerTest::test_logs_persistence_changes_volume_1 PASSED [ 94%]
tests/test_worker.py::WorkerTest::test_logs_persistence_changes_volume_2 PASSED [ 95%]
tests/test_worker.py::WorkerTest::test_no_airflow_local_settings_by_default PASSED [ 95%]
tests/test_worker.py::WorkerTest::test_should_add_extra_containers PASSED [ 95%]
tests/test_worker.py::WorkerTest::test_should_add_extra_init_containers PASSED [ 95%]
tests/test_worker.py::WorkerTest::test_should_add_extra_volume_and_extra_volume_mount PASSED [ 96%]
tests/test_worker.py::WorkerTest::test_should_create_default_affinity PASSED [ 96%]
tests/test_worker.py::WorkerTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 96%]
tests/test_worker.py::WorkerTest::test_should_create_valid_affinity_tolerations_and_node_selector_override PASSED [ 96%]
tests/test_worker.py::WorkerTest::test_worker_kind_0_CeleryExecutor PASSED [ 97%]
tests/test_worker.py::WorkerTest::test_worker_kind_1_CeleryExecutor PASSED [ 97%]
tests/test_worker.py::WorkerTest::test_worker_kind_2_CeleryKubernetesExecutor PASSED [ 97%]
tests/test_worker.py::WorkerTest::test_worker_kind_3_CeleryKubernetesExecutor PASSED [ 97%]
tests/test_worker.py::WorkerTest::test_worker_resources_are_configurable PASSED [ 98%]
tests/test_worker.py::WorkerTest::test_worker_resources_are_not_added_by_default PASSED [ 98%]
tests/test_worker.py::WorkerTest::test_workers_host_aliases PASSED [ 98%]
tests/test_worker.py::WorkerTest::test_workers_strategy_0 PASSED [ 98%]
tests/test_worker.py::WorkerTest::test_workers_strategy_1 PASSED [ 99%]
tests/test_worker.py::WorkerTest::test_workers_strategy_2 PASSED [ 99%]
tests/test_worker.py::WorkerTest::test_workers_update_strategy_0 PASSED [ 99%]
tests/test_worker.py::WorkerTest::test_workers_update_strategy_1 PASSED [ 99%]
tests/test_worker.py::WorkerTest::test_workers_update_strategy_2 PASSED [100%]
======================= 400 passed in 1535.73s (0:25:35) =======================
```
This is the result of you mentioned in example: `test_metadata_connection_secret.py`
As I already mentioned, I don't know how to add test coverage for this in fancy style, so sorry for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972
I wrote new test coverage. Here's my local test result.
with original template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
with fixed template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
And also, Should the default port be 80? As I know, elasticsearch uses port 9200 as default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-896918356
I think CI has an issue right now. All `Build image` phases are now pending, including other PRs.
Perhaps we should wait for CI problem to vanish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#discussion_r685317827
##########
File path: chart/tests/test_elasticsearch_secret.py
##########
@@ -96,3 +96,24 @@ def test_should_correctly_handle_password_with_special_characters(self):
"http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
"elastichostname:80" == connection
)
+
+ def test_should_generate_secret_with_specified_port(self):
+ connection = self._get_connection(
+ {
+ "elasticsearch": {
+ "enabled": True,
+ "connection": {
+ "user": "username!@#$%%^&*()",
+ "pass": "password!@#$%%^&*()",
+ "host": "elastichostname",
+ "port": 9200,
+ },
+ }
+ }
+ )
+
+ assert (
+ "http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
+ "elastichostname:9200" == connection
+ )
Review comment:
```suggestion
"host": "elastichostname",
"port": 2222,
},
}
}
)
assert "http://elastichostname:2222" == connection
```
Let's keep it simple and also use a non-default port?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on a change in pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on a change in pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#discussion_r685333753
##########
File path: chart/tests/test_elasticsearch_secret.py
##########
@@ -96,3 +96,24 @@ def test_should_correctly_handle_password_with_special_characters(self):
"http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
"elastichostname:80" == connection
)
+
+ def test_should_generate_secret_with_specified_port(self):
+ connection = self._get_connection(
+ {
+ "elasticsearch": {
+ "enabled": True,
+ "connection": {
+ "user": "username!@#$%%^&*()",
+ "pass": "password!@#$%%^&*()",
+ "host": "elastichostname",
+ "port": 9200,
+ },
+ }
+ }
+ )
+
+ assert (
+ "http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
+ "elastichostname:9200" == connection
+ )
Review comment:
Good. I committed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972
I wrote new test coverage. Here's my local test result.
with original template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
with fixed template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
And also, Should default port be 80? As I know, elasticsearch uses port 9200 as default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972
OK. I wrote new test coverage. Here's my local test result.
with original template
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-898763140
> @Sonins, congrats on your first commit! Thanks for the fix
Thanks for your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on a change in pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on a change in pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#discussion_r685708706
##########
File path: chart/tests/test_elasticsearch_secret.py
##########
@@ -96,3 +96,24 @@ def test_should_correctly_handle_password_with_special_characters(self):
"http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
"elastichostname:80" == connection
)
+
+ def test_should_generate_secret_with_specified_port(self):
+ connection = self._get_connection(
+ {
+ "elasticsearch": {
+ "enabled": True,
+ "connection": {
+ "user": "username!@#$%%^&*()",
+ "pass": "password!@#$%%^&*()",
+ "host": "elastichostname",
+ "port": 9200,
+ },
+ }
+ }
+ )
+
+ assert (
+ "http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
+ "elastichostname:9200" == connection
+ )
Review comment:
OK, It turns out there is a little problem.
Without user and pass field, `<no+value>` is included in url string, like this.
`http://<no+value>:<no+value>@elastichostname:2222`
It makes test fail.
My mistake, I should've tested for this before i committed it, sorry.
For now I can think 2 options.
1. Insert simple username and pass into test function.
2. Fix something that makes user and pass in url string <no+value>. And make default username something like 'root', instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972
I wrote new test coverage. Here's my local test result.
with original template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
with fixed template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
And also, why should elasticsearch default port be 80? As I know, elasticsearch uses port 9200 as default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972
OK. I wrote new test coverage. Here's my local test result.
with original template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
with fixed template
```
root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_secret.py
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894562815
Hey @Sonins, what I meant was we need to write new tests to cover this change (well, and the whole elasticsearch secret). The tests in `test_metadata_connection_secret.py` are very similar so they are a good example of how it is done.
If you get stuck, I (and I'm sure others) wouldn't mind helping get you moving again, just post in the #airflow-how-to-pr channel on slack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-893932430
Thank you for your review @jedcunningham .
I did the unit test using pytest in breeze environment, but I don't know how to attach the result to this PR in fancy style.
So, I just paste the result of pytest.
```
root@fa3d600de005:/opt/airflow/chart# pytest tests/
============================= test session starts ==============================
platform linux -- Python 3.6.14, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, configfile: pytest.ini
plugins: requests-mock-1.9.3, flaky-3.7.0, timeouts-1.2.1, anyio-3.3.0, forked-1.3.0, httpx-0.12.0, instafail-0.4.2, cov-2.12.1, xdist-2.3.0, rerunfailures-9.1.1, celery-4.4.7
setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s
collected 400 items
tests/test_airflow_common.py::AirflowCommon::test_annotations PASSED [ 0%]
tests/test_airflow_common.py::AirflowCommon::test_dags_mount_0 PASSED [ 0%]
tests/test_airflow_common.py::AirflowCommon::test_dags_mount_1 PASSED [ 0%]
tests/test_airflow_common.py::AirflowCommon::test_dags_mount_2 PASSED [ 1%]
tests/test_annotations.py::AnnotationsTest::test_service_account_annotations PASSED [ 1%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_annotations_on_airflow_pods_in_deployment PASSED [ 1%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_basic_deployment_without_default_users PASSED [ 1%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_basic_deployments PASSED [ 2%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_chart_is_consistent_with_official_airflow_image PASSED [ 2%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_dags_access_mode PASSED [ 2%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_0_airflow PASSED [ 2%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_1_pod_template PASSED [ 3%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_2_flower PASSED [ 3%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_3_statsd PASSED [ 3%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_4_redis PASSED [ 3%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_5_pgbouncer PASSED [ 4%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_6_pgbouncerExporter PASSED [ 4%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_7_gitSync PASSED [ 4%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_labels_are_valid PASSED [ 4%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_network_policies_are_valid PASSED [ 5%]
tests/test_basic_helm_chart.py::TestBaseChartTest::test_unsupported_executor PASSED [ 5%]
tests/test_celery_kubernetes_executor.py::CeleryKubernetesExecutorTest::test_should_create_a_worker_deployment_with_the_celery_executor PASSED [ 5%]
tests/test_celery_kubernetes_executor.py::CeleryKubernetesExecutorTest::test_should_create_a_worker_deployment_with_the_celery_kubernetes_executor PASSED [ 5%]
tests/test_chart_quality.py::ChartQualityTest::test_values_validate_schema PASSED [ 6%]
tests/test_cleanup_pods.py::CleanupPodsTest::test_should_change_image_when_set_airflow_image PASSED [ 6%]
tests/test_cleanup_pods.py::CleanupPodsTest::test_should_create_cronjob_for_enabled_cleanup PASSED [ 6%]
tests/test_cleanup_pods.py::CleanupPodsTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 6%]
tests/test_configmap.py::ConfigmapTest::test_airflow_local_settings PASSED [ 7%]
tests/test_configmap.py::ConfigmapTest::test_kerberos_config_available_with_celery_executor PASSED [ 7%]
tests/test_configmap.py::ConfigmapTest::test_multiple_annotations PASSED [ 7%]
tests/test_configmap.py::ConfigmapTest::test_no_airflow_local_settings_by_default PASSED [ 7%]
tests/test_configmap.py::ConfigmapTest::test_single_annotation PASSED [ 8%]
tests/test_create_user_job.py::CreateUserJobTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 8%]
tests/test_create_user_job.py::CreateUserJobTest::test_should_run_by_default PASSED [ 8%]
tests/test_create_user_job.py::CreateUserJobTest::test_should_support_annotations PASSED [ 8%]
tests/test_dags_persistent_volume_claim.py::DagsPersistentVolumeClaimTest::test_should_generate_a_document_if_persistence_is_enabled_and_not_using_an_existing_claim PASSED [ 9%]
tests/test_dags_persistent_volume_claim.py::DagsPersistentVolumeClaimTest::test_should_not_generate_a_document_if_persistence_is_disabled PASSED [ 9%]
tests/test_dags_persistent_volume_claim.py::DagsPersistentVolumeClaimTest::test_should_not_generate_a_document_when_using_an_existing_claim PASSED [ 9%]
tests/test_dags_persistent_volume_claim.py::DagsPersistentVolumeClaimTest::test_should_set_pvc_details_correctly PASSED [ 9%]
tests/test_elasticsearch_secret.py::ElasticsearchSecretTest::test_should_correctly_handle_password_with_special_characters PASSED [ 10%]
tests/test_elasticsearch_secret.py::ElasticsearchSecretTest::test_should_not_generate_a_document_if_elasticsearch_disabled PASSED [ 10%]
tests/test_elasticsearch_secret.py::ElasticsearchSecretTest::test_should_raise_error_when_conflicting_options PASSED [ 10%]
tests/test_elasticsearch_secret.py::ElasticsearchSecretTest::test_should_raise_error_when_connection_not_provided PASSED [ 10%]
tests/test_extra_configmaps_secrets.py::ExtraConfigMapsSecretsTest::test_extra_configmaps PASSED [ 11%]
tests/test_extra_configmaps_secrets.py::ExtraConfigMapsSecretsTest::test_extra_secrets PASSED [ 11%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_0 PASSED [ 11%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_1 PASSED [ 11%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_2 PASSED [ 12%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_3 PASSED [ 12%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_4 PASSED [ 12%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_from_0 PASSED [ 12%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_from_1 PASSED [ 13%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_from_2 PASSED [ 13%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_from_3 PASSED [ 13%]
tests/test_extra_env_env_from.py::ExtraEnvEnvFromTest::test_extra_env_from_4 PASSED [ 13%]
tests/test_flower.py::TestFlowerDeployment::test_create_flower[CeleryExecutor-False-False] PASSED [ 14%]
tests/test_flower.py::TestFlowerDeployment::test_create_flower[CeleryKubernetesExecutor-False-False] PASSED [ 14%]
tests/test_flower.py::TestFlowerDeployment::test_create_flower[KubernetesExecutor-False-False] PASSED [ 14%]
tests/test_flower.py::TestFlowerDeployment::test_create_flower[CeleryExecutor-True-True] PASSED [ 14%]
tests/test_flower.py::TestFlowerDeployment::test_create_flower[CeleryKubernetesExecutor-True-True] PASSED [ 15%]
tests/test_flower.py::TestFlowerDeployment::test_create_flower[KubernetesExecutor-True-False] PASSED [ 15%]
tests/test_flower.py::TestFlowerDeployment::test_args_with_airflow_version[2.0.2-airflow celery flower] PASSED [ 15%]
tests/test_flower.py::TestFlowerDeployment::test_args_with_airflow_version[1.10.14-airflow flower] PASSED [ 15%]
tests/test_flower.py::TestFlowerDeployment::test_args_with_airflow_version[1.9.0-airflow flower] PASSED [ 16%]
tests/test_flower.py::TestFlowerDeployment::test_args_with_airflow_version[2.1.0-airflow celery flower] PASSED [ 16%]
tests/test_flower.py::TestFlowerDeployment::test_command_and_args_overrides[None-None] PASSED [ 16%]
tests/test_flower.py::TestFlowerDeployment::test_command_and_args_overrides[None-args1] PASSED [ 16%]
tests/test_flower.py::TestFlowerDeployment::test_command_and_args_overrides[command2-None] PASSED [ 17%]
tests/test_flower.py::TestFlowerDeployment::test_command_and_args_overrides[command3-args3] PASSED [ 17%]
tests/test_flower.py::TestFlowerDeployment::test_command_and_args_overrides_are_templated PASSED [ 17%]
tests/test_flower.py::TestFlowerDeployment::test_should_create_flower_deployment_with_authorization PASSED [ 17%]
tests/test_flower.py::TestFlowerDeployment::test_should_create_flower_deployment_without_authorization PASSED [ 18%]
tests/test_flower.py::TestFlowerDeployment::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 18%]
tests/test_flower.py::TestFlowerDeployment::test_flower_resources_are_configurable PASSED [ 18%]
tests/test_flower.py::TestFlowerDeployment::test_flower_resources_are_not_added_by_default PASSED [ 18%]
tests/test_flower.py::TestFlowerDeployment::test_should_add_extra_containers PASSED [ 19%]
tests/test_flower.py::TestFlowerDeployment::test_should_add_extra_volumes PASSED [ 19%]
tests/test_flower.py::TestFlowerService::test_create_flower[CeleryExecutor-False-False] PASSED [ 19%]
tests/test_flower.py::TestFlowerService::test_create_flower[CeleryKubernetesExecutor-False-False] PASSED [ 19%]
tests/test_flower.py::TestFlowerService::test_create_flower[KubernetesExecutor-False-False] PASSED [ 20%]
tests/test_flower.py::TestFlowerService::test_create_flower[CeleryExecutor-True-True] PASSED [ 20%]
tests/test_flower.py::TestFlowerService::test_create_flower[CeleryKubernetesExecutor-True-True] PASSED [ 20%]
tests/test_flower.py::TestFlowerService::test_create_flower[KubernetesExecutor-True-False] PASSED [ 20%]
tests/test_flower.py::TestFlowerService::test_default_service PASSED [ 21%]
tests/test_flower.py::TestFlowerService::test_overrides PASSED [ 21%]
tests/test_flower.py::TestFlowerService::test_ports_overrides[ports0-expected_ports0] PASSED [ 21%]
tests/test_flower.py::TestFlowerService::test_ports_overrides[ports1-expected_ports1] PASSED [ 21%]
tests/test_flower.py::TestFlowerService::test_ports_overrides[ports2-expected_ports2] PASSED [ 22%]
tests/test_flower.py::TestFlowerService::test_ports_overrides[ports3-expected_ports3] PASSED [ 22%]
tests/test_flower.py::TestFlowerNetworkPolicy::test_off_by_default PASSED [ 22%]
tests/test_flower.py::TestFlowerNetworkPolicy::test_defaults PASSED [ 22%]
tests/test_flower.py::TestFlowerNetworkPolicy::test_ports_overrides[ports0-expected_ports0] PASSED [ 23%]
tests/test_flower.py::TestFlowerNetworkPolicy::test_ports_overrides[ports1-expected_ports1] PASSED [ 23%]
tests/test_flower.py::TestFlowerNetworkPolicy::test_ports_overrides[ports2-expected_ports2] PASSED [ 23%]
tests/test_flower.py::TestFlowerNetworkPolicy::test_deprecated_from_param PASSED [ 23%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_extra_volume_and_git_sync_extra_volume_mount PASSED [ 24%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_resources_are_configurable PASSED [ 24%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_should_add_dags_volume PASSED [ 24%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_should_add_env PASSED [ 24%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_should_add_extra_volume_and_extra_volume_mount PASSED [ 25%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_should_set_the_volume_claim_correctly_when_using_an_existing_claim PASSED [ 25%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_should_set_username_and_pass_env_variables PASSED [ 25%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_validate_if_ssh_params_are_added PASSED [ 25%]
tests/test_git_sync_scheduler.py::GitSyncSchedulerTest::test_validate_the_git_sync_container_spec PASSED [ 26%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_git_sync_with_different_airflow_versions_0_2_0_0 PASSED [ 26%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_git_sync_with_different_airflow_versions_1_2_0_2 PASSED [ 26%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_git_sync_with_different_airflow_versions_2_1_10_14 PASSED [ 26%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_git_sync_with_different_airflow_versions_3_1_9_0 PASSED [ 27%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_git_sync_with_different_airflow_versions_4_2_1_0 PASSED [ 27%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_resources_are_configurable PASSED [ 27%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_should_add_dags_volume_to_the_webserver_if_git_sync_and_persistence_is_enabled PASSED [ 27%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_should_add_dags_volume_to_the_webserver_if_git_sync_is_enabled_and_persistence_is_disabled PASSED [ 28%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_should_add_env PASSED [ 28%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_should_add_git_sync_container_to_webserver_if_persistence_is_not_enabled_but_git_sync_is PASSED [ 28%]
tests/test_git_sync_webserver.py::GitSyncWebserverTest::test_should_have_service_account_defined PASSED [ 28%]
tests/test_git_sync_worker.py::GitSyncWorkerTest::test_resources_are_configurable PASSED [ 29%]
tests/test_git_sync_worker.py::GitSyncWorkerTest::test_should_add_dags_volume_to_the_worker_if_git_sync_and_persistence_is_enabled PASSED [ 29%]
tests/test_git_sync_worker.py::GitSyncWorkerTest::test_should_add_dags_volume_to_the_worker_if_git_sync_is_enabled_and_persistence_is_disabled PASSED [ 29%]
tests/test_git_sync_worker.py::GitSyncWorkerTest::test_should_add_env PASSED [ 29%]
tests/test_git_sync_worker.py::GitSyncWorkerTest::test_should_add_git_sync_container_to_worker_if_persistence_is_not_enabled_but_git_sync_is PASSED [ 30%]
tests/test_git_sync_worker.py::GitSyncWorkerTest::test_should_not_add_sync_container_to_worker_if_git_sync_and_persistence_are_enabled PASSED [ 30%]
tests/test_ingress_flower.py::IngressFlowerTest::test_should_allow_more_than_one_annotation PASSED [ 30%]
tests/test_ingress_flower.py::IngressFlowerTest::test_should_pass_validation_with_just_ingress_enabled PASSED [ 30%]
tests/test_ingress_web.py::IngressWebTest::test_should_allow_more_than_one_annotation PASSED [ 31%]
tests/test_ingress_web.py::IngressWebTest::test_should_pass_validation_with_just_ingress_enabled PASSED [ 31%]
tests/test_keda.py::TestKeda::test_keda_disabled_by_default PASSED [ 31%]
tests/test_keda.py::TestKeda::test_keda_enabled_0_CeleryExecutor PASSED [ 31%]
tests/test_keda.py::TestKeda::test_keda_enabled_1_CeleryKubernetesExecutor PASSED [ 32%]
tests/test_keda.py::TestKeda::test_keda_concurrency_0_CeleryExecutor PASSED [ 32%]
tests/test_keda.py::TestKeda::test_keda_concurrency_1_CeleryExecutor PASSED [ 32%]
tests/test_keda.py::TestKeda::test_keda_concurrency_2_CeleryKubernetesExecutor PASSED [ 32%]
tests/test_keda.py::TestKeda::test_keda_concurrency_3_CeleryKubernetesExecutor PASSED [ 33%]
tests/test_keda.py::TestKeda::test_persistence_0_enabled PASSED [ 33%]
tests/test_keda.py::TestKeda::test_persistence_1_not_enabled PASSED [ 33%]
tests/test_kerberos.py::KerberosTest::test_keberos_sidecar_resources_are_not_added_by_default PASSED [ 33%]
tests/test_kerberos.py::KerberosTest::test_kerberos_envs_available_in_worker_with_persistence PASSED [ 34%]
tests/test_kerberos.py::KerberosTest::test_kerberos_not_mentioned_in_render_if_disabled PASSED [ 34%]
tests/test_kerberos.py::KerberosTest::test_kerberos_sidecar_resources PASSED [ 34%]
tests/test_limit_ranges.py::LimitRangesTest::test_limit_ranges_are_not_added_by_default PASSED [ 34%]
tests/test_limit_ranges.py::LimitRangesTest::test_limit_ranges_template PASSED [ 35%]
tests/test_logs_persistent_volume_claim.py::LogsPersistentVolumeClaimTest::test_should_generate_a_document_if_persistence_is_enabled_and_not_using_an_existing_claim PASSED [ 35%]
tests/test_logs_persistent_volume_claim.py::LogsPersistentVolumeClaimTest::test_should_not_generate_a_document_if_persistence_is_disabled PASSED [ 35%]
tests/test_logs_persistent_volume_claim.py::LogsPersistentVolumeClaimTest::test_should_not_generate_a_document_when_using_an_existing_claim PASSED [ 35%]
tests/test_logs_persistent_volume_claim.py::LogsPersistentVolumeClaimTest::test_should_set_pvc_details_correctly PASSED [ 36%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_default_connection PASSED [ 36%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_should_correctly_handle_password_with_special_characters PASSED [ 36%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_should_correctly_use_non_chart_database PASSED [ 36%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_should_not_generate_a_document_if_using_existing_secret PASSED [ 37%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_should_set_pgbouncer_overrides_when_enabled PASSED [ 37%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_should_set_pgbouncer_overrides_with_non_chart_database_when_enabled PASSED [ 37%]
tests/test_metadata_connection_secret.py::MetadataConnectionSecretTest::test_should_support_non_postgres_db PASSED [ 37%]
tests/test_migrate_database_job.py::MigrateDatabaseJobTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 38%]
tests/test_migrate_database_job.py::MigrateDatabaseJobTest::test_should_run_by_default PASSED [ 38%]
tests/test_migrate_database_job.py::MigrateDatabaseJobTest::test_should_support_annotations PASSED [ 38%]
tests/test_pgbouncer.py::PgbouncerTest::test_existing_secret PASSED [ 38%]
tests/test_pgbouncer.py::PgbouncerTest::test_metrics_exporter_resources PASSED [ 39%]
tests/test_pgbouncer.py::PgbouncerTest::test_no_existing_secret PASSED [ 39%]
tests/test_pgbouncer.py::PgbouncerTest::test_pgbouncer_resources_are_configurable PASSED [ 39%]
tests/test_pgbouncer.py::PgbouncerTest::test_pgbouncer_resources_are_not_added_by_default PASSED [ 39%]
tests/test_pgbouncer.py::PgbouncerTest::test_pgbouncer_resources_not_created_by_default_0_pgbouncer_deployment PASSED [ 40%]
tests/test_pgbouncer.py::PgbouncerTest::test_pgbouncer_resources_not_created_by_default_1_pgbouncer_service PASSED [ 40%]
tests/test_pgbouncer.py::PgbouncerTest::test_pgbouncer_service_extra_annotations PASSED [ 40%]
tests/test_pgbouncer.py::PgbouncerTest::test_pgbouncer_service_with_custom_ports PASSED [ 40%]
tests/test_pgbouncer.py::PgbouncerTest::test_should_create_pgbouncer PASSED [ 41%]
tests/test_pgbouncer.py::PgbouncerTest::test_should_create_pgbouncer_service PASSED [ 41%]
tests/test_pgbouncer.py::PgbouncerTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 41%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_config_defaults PASSED [ 41%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_config_not_created_by_default PASSED [ 42%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_config_overrides PASSED [ 42%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_databases_default PASSED [ 42%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_databases_override PASSED [ 42%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_extra_ini_configs PASSED [ 43%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_ssl_config PASSED [ 43%]
tests/test_pgbouncer.py::PgbouncerConfigTest::test_ssl_defaults_dont_create_cert_secret PASSED [ 43%]
tests/test_pgbouncer.py::PgbouncerExporterTest::test_default_exporter_secret PASSED [ 43%]
tests/test_pgbouncer.py::PgbouncerExporterTest::test_exporter_secret_with_overrides PASSED [ 44%]
tests/test_pgbouncer.py::PgbouncerExporterTest::test_secret_not_created_by_default PASSED [ 44%]
tests/test_pod_launcher_role.py::PodLauncherTest::test_pod_launcher_role_0_CeleryKubernetesExecutor PASSED [ 44%]
tests/test_pod_launcher_role.py::PodLauncherTest::test_pod_launcher_role_1_KubernetesExecutor PASSED [ 44%]
tests/test_pod_launcher_role.py::PodLauncherTest::test_pod_launcher_role_2_CeleryExecutor PASSED [ 45%]
tests/test_pod_launcher_role.py::PodLauncherTest::test_pod_launcher_role_3_LocalExecutor PASSED [ 45%]
tests/test_pod_launcher_role.py::PodLauncherTest::test_pod_launcher_role_4_LocalExecutor PASSED [ 45%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_airflow_local_settings PASSED [ 45%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_airflow_pod_annotations PASSED [ 46%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_dags_mount_0 PASSED [ 46%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_dags_mount_1 PASSED [ 46%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_dags_mount_2 PASSED [ 46%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_empty_resources PASSED [ 47%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_logs_persistence_changes_volume_0 PASSED [ 47%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_logs_persistence_changes_volume_1 PASSED [ 47%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_logs_persistence_changes_volume_2 PASSED [ 47%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_mount_airflow_cfg PASSED [ 48%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_no_airflow_local_settings_by_default PASSED [ 48%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_add_an_init_container_if_git_sync_is_true PASSED [ 48%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_add_env_for_gitsync PASSED [ 48%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_add_extra_init_containers PASSED [ 49%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_add_fsgroup_to_the_pod_template PASSED [ 49%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_add_pod_labels PASSED [ 49%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_add_resources PASSED [ 49%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_create_valid_affinity_and_node_selector PASSED [ 50%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 50%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_create_valid_volume_mount_and_volume PASSED [ 50%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_not_add_init_container_if_dag_persistence_is_true PASSED [ 50%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_set_a_custom_image_in_pod_template PASSED [ 51%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_set_the_dags_volume_claim_correctly_when_using_an_existing_claim PASSED [ 51%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_set_username_and_pass_env_variables PASSED [ 51%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_use_empty_dir_for_gitsync_without_persistence PASSED [ 51%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_should_work PASSED [ 52%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_validate_if_ssh_known_hosts_are_added PASSED [ 52%]
tests/test_pod_template_file.py::PodTemplateFileTest::test_validate_if_ssh_params_are_added PASSED [ 52%]
tests/test_rbac.py::RBACTest::test_deployments_no_rbac_no_sa PASSED [ 52%]
tests/test_rbac.py::RBACTest::test_deployments_no_rbac_with_sa PASSED [ 53%]
tests/test_rbac.py::RBACTest::test_deployments_with_rbac_no_sa PASSED [ 53%]
tests/test_rbac.py::RBACTest::test_deployments_with_rbac_with_sa PASSED [ 53%]
tests/test_rbac.py::RBACTest::test_service_account_custom_names PASSED [ 53%]
tests/test_rbac.py::RBACTest::test_service_account_custom_names_in_objects PASSED [ 54%]
tests/test_rbac.py::RBACTest::test_service_account_without_resource PASSED [ 54%]
tests/test_redis.py::RedisTest::test_default_redis_secrets_created_with_non_celery_executor PASSED [ 54%]
tests/test_redis.py::RedisTest::test_external_redis_broker_url_0_CeleryExecutor PASSED [ 54%]
tests/test_redis.py::RedisTest::test_external_redis_broker_url_1_CeleryKubernetesExecutor PASSED [ 55%]
tests/test_redis.py::RedisTest::test_external_redis_broker_url_secret_name_0_CeleryExecutor PASSED [ 55%]
tests/test_redis.py::RedisTest::test_external_redis_broker_url_secret_name_1_CeleryKubernetesExecutor PASSED [ 55%]
tests/test_redis.py::RedisTest::test_redis_by_chart_default_0_CeleryExecutor PASSED [ 55%]
tests/test_redis.py::RedisTest::test_redis_by_chart_default_1_CeleryKubernetesExecutor PASSED [ 56%]
tests/test_redis.py::RedisTest::test_redis_by_chart_password_0_CeleryExecutor PASSED [ 56%]
tests/test_redis.py::RedisTest::test_redis_by_chart_password_1_CeleryKubernetesExecutor PASSED [ 56%]
tests/test_redis.py::RedisTest::test_redis_by_chart_password_secret_name_0_CeleryExecutor PASSED [ 56%]
tests/test_redis.py::RedisTest::test_redis_by_chart_password_secret_name_1_CeleryKubernetesExecutor PASSED [ 57%]
tests/test_redis.py::RedisTest::test_redis_by_chart_password_secret_name_missing_broker_url_secret_name_0_CeleryExecutor PASSED [ 57%]
tests/test_redis.py::RedisTest::test_redis_by_chart_password_secret_name_missing_broker_url_secret_name_1_CeleryKubernetesExecutor PASSED [ 57%]
tests/test_redis.py::RedisTest::test_redis_resources_are_configurable PASSED [ 57%]
tests/test_redis.py::RedisTest::test_redis_resources_are_not_added_by_default PASSED [ 58%]
tests/test_redis.py::RedisTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 58%]
tests/test_resource_quota.py::ResourceQuotaTest::test_resource_quota_are_not_added_by_default PASSED [ 58%]
tests/test_resource_quota.py::ResourceQuotaTest::test_resource_quota_template PASSED [ 58%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_default_connection PASSED [ 59%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_a_document_be_generated_for_executor_0_CeleryExecutor PASSED [ 59%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_a_document_be_generated_for_executor_1_CeleryKubernetesExecutor PASSED [ 59%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_a_document_be_generated_for_executor_2_LocalExecutor PASSED [ 59%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_correctly_handle_password_with_special_characters PASSED [ 60%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_correctly_use_non_chart_database PASSED [ 60%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_correctly_use_non_chart_database_when_both_db_are_external PASSED [ 60%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_default_to_custom_metadata_db_connection PASSED [ 60%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_default_to_custom_metadata_db_connection_with_pgbouncer_overrides PASSED [ 61%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_not_generate_a_document_if_using_existing_secret PASSED [ 61%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_set_pgbouncer_overrides_when_enabled PASSED [ 61%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_set_pgbouncer_overrides_with_non_chart_database_when_enabled PASSED [ 61%]
tests/test_result_backend_connection_secret.py::ResultBackendConnectionSecretTest::test_should_support_non_postgres_db PASSED [ 62%]
tests/test_scheduler.py::SchedulerTest::test_airflow_local_settings PASSED [ 62%]
tests/test_scheduler.py::SchedulerTest::test_command_and_args_overrides_0 PASSED [ 62%]
tests/test_scheduler.py::SchedulerTest::test_command_and_args_overrides_1 PASSED [ 62%]
tests/test_scheduler.py::SchedulerTest::test_command_and_args_overrides_2 PASSED [ 63%]
tests/test_scheduler.py::SchedulerTest::test_command_and_args_overrides_3 PASSED [ 63%]
tests/test_scheduler.py::SchedulerTest::test_command_and_args_overrides_are_templated PASSED [ 63%]
tests/test_scheduler.py::SchedulerTest::test_dags_gitsync_sidecar_and_init_container_0 PASSED [ 63%]
tests/test_scheduler.py::SchedulerTest::test_dags_gitsync_sidecar_and_init_container_1 PASSED [ 64%]
tests/test_scheduler.py::SchedulerTest::test_default_command_and_args PASSED [ 64%]
tests/test_scheduler.py::SchedulerTest::test_livenessprobe_values_are_configurable PASSED [ 64%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_collector_can_be_disabled PASSED [ 64%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_collector_default_command_and_args PASSED [ 65%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_command_and_args_overrides_0 PASSED [ 65%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_command_and_args_overrides_1 PASSED [ 65%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_command_and_args_overrides_2 PASSED [ 65%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_command_and_args_overrides_3 PASSED [ 66%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_command_and_args_overrides_are_templated PASSED [ 66%]
tests/test_scheduler.py::SchedulerTest::test_log_groomer_resources PASSED [ 66%]
tests/test_scheduler.py::SchedulerTest::test_logs_persistence_changes_volume_0 PASSED [ 66%]
tests/test_scheduler.py::SchedulerTest::test_logs_persistence_changes_volume_1 PASSED [ 67%]
tests/test_scheduler.py::SchedulerTest::test_logs_persistence_changes_volume_2 PASSED [ 67%]
tests/test_scheduler.py::SchedulerTest::test_no_airflow_local_settings_by_default PASSED [ 67%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_kind_0_CeleryExecutor PASSED [ 67%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_kind_1_CeleryExecutor PASSED [ 68%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_kind_2_CeleryKubernetesExecutor PASSED [ 68%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_kind_3_KubernetesExecutor PASSED [ 68%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_kind_4_LocalExecutor PASSED [ 68%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_kind_5_LocalExecutor PASSED [ 69%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_resources_are_configurable PASSED [ 69%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_resources_are_not_added_by_default PASSED [ 69%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_0_LocalExecutor PASSED [ 69%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_1_LocalExecutor PASSED [ 70%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_2_LocalExecutor PASSED [ 70%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_3_CeleryExecutor PASSED [ 70%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_4_CeleryExecutor PASSED [ 70%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_5_CeleryExecutor PASSED [ 71%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_strategy_6_CeleryExecutor PASSED [ 71%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_update_strategy_0_CeleryExecutor PASSED [ 71%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_update_strategy_1_CeleryExecutor PASSED [ 71%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_update_strategy_2_LocalExecutor PASSED [ 72%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_update_strategy_3_LocalExecutor PASSED [ 72%]
tests/test_scheduler.py::SchedulerTest::test_scheduler_update_strategy_4_LocalExecutor PASSED [ 72%]
tests/test_scheduler.py::SchedulerTest::test_should_add_extra_containers PASSED [ 72%]
tests/test_scheduler.py::SchedulerTest::test_should_add_extra_init_containers PASSED [ 73%]
tests/test_scheduler.py::SchedulerTest::test_should_add_extra_volume_and_extra_volume_mount PASSED [ 73%]
tests/test_scheduler.py::SchedulerTest::test_should_create_default_affinity PASSED [ 73%]
tests/test_scheduler.py::SchedulerTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 73%]
tests/test_statsd.py::StatsdTest::test_should_add_volume_and_volume_mount_when_exist_extra_mappings PASSED [ 74%]
tests/test_statsd.py::StatsdTest::test_should_create_statsd_default PASSED [ 74%]
tests/test_statsd.py::StatsdTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 74%]
tests/test_statsd.py::StatsdTest::test_stastd_resources_are_configurable PASSED [ 74%]
tests/test_statsd.py::StatsdTest::test_statsd_resources_are_not_added_by_default PASSED [ 75%]
tests/test_webserver.py::WebserverDeploymentTest::test_airflow_local_settings PASSED [ 75%]
tests/test_webserver.py::WebserverDeploymentTest::test_command_and_args_overrides_0 PASSED [ 75%]
tests/test_webserver.py::WebserverDeploymentTest::test_command_and_args_overrides_1 PASSED [ 75%]
tests/test_webserver.py::WebserverDeploymentTest::test_command_and_args_overrides_2 PASSED [ 76%]
tests/test_webserver.py::WebserverDeploymentTest::test_command_and_args_overrides_3 PASSED [ 76%]
tests/test_webserver.py::WebserverDeploymentTest::test_command_and_args_overrides_are_templated PASSED [ 76%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_gitsync_volume_and_sidecar_and_init_container PASSED [ 76%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_mount_0_1_10_15 PASSED [ 77%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_mount_1_1_10_15 PASSED [ 77%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_mount_2_1_10_15 PASSED [ 77%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_persistence_volume_no_sidecar_0 PASSED [ 77%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_persistence_volume_no_sidecar_1 PASSED [ 78%]
tests/test_webserver.py::WebserverDeploymentTest::test_dags_persistence_volume_no_sidecar_2 PASSED [ 78%]
tests/test_webserver.py::WebserverDeploymentTest::test_default_command_and_args PASSED [ 78%]
tests/test_webserver.py::WebserverDeploymentTest::test_default_update_strategy_0_2_0_2 PASSED [ 78%]
tests/test_webserver.py::WebserverDeploymentTest::test_default_update_strategy_1_1_10_14 PASSED [ 79%]
tests/test_webserver.py::WebserverDeploymentTest::test_default_update_strategy_2_1_9_0 PASSED [ 79%]
tests/test_webserver.py::WebserverDeploymentTest::test_default_update_strategy_3_2_1_0 PASSED [ 79%]
tests/test_webserver.py::WebserverDeploymentTest::test_logs_persistence_adds_volume_and_mount_0 PASSED [ 79%]
tests/test_webserver.py::WebserverDeploymentTest::test_logs_persistence_adds_volume_and_mount_1 PASSED [ 80%]
tests/test_webserver.py::WebserverDeploymentTest::test_logs_persistence_adds_volume_and_mount_2 PASSED [ 80%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_airflow_local_settings_by_default PASSED [ 80%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_0_1_10_15 PASSED [ 80%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_1_1_10_15 PASSED [ 81%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_2_1_10_15 PASSED [ 81%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_3_2_0_0 PASSED [ 81%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_4_2_0_0 PASSED [ 81%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_5_2_0_0 PASSED [ 82%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_6_2_0_0 PASSED [ 82%]
tests/test_webserver.py::WebserverDeploymentTest::test_no_dags_mount_or_volume_or_gitsync_sidecar_expected_7_2_0_0 PASSED [ 82%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_add_extra_containers PASSED [ 82%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_add_extra_init_containers PASSED [ 83%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_add_host_header_to_liveness_and_readiness_probes PASSED [ 83%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_add_path_to_liveness_and_readiness_probes PASSED [ 83%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_add_volume_and_volume_mount_when_exist_webserver_config PASSED [ 83%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_create_default_affinity PASSED [ 84%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 84%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_not_contain_host_header_0 PASSED [ 84%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_not_contain_host_header_1 PASSED [ 84%]
tests/test_webserver.py::WebserverDeploymentTest::test_should_use_templated_base_url_for_probes PASSED [ 85%]
tests/test_webserver.py::WebserverDeploymentTest::test_update_strategy PASSED [ 85%]
tests/test_webserver.py::WebserverDeploymentTest::test_webserver_resources_are_configurable PASSED [ 85%]
tests/test_webserver.py::WebserverDeploymentTest::test_webserver_resources_are_not_added_by_default PASSED [ 85%]
tests/test_webserver.py::WebserverServiceTest::test_default_service PASSED [ 86%]
tests/test_webserver.py::WebserverServiceTest::test_overrides PASSED [ 86%]
tests/test_webserver.py::WebserverServiceTest::test_ports_overrides_0 PASSED [ 86%]
tests/test_webserver.py::WebserverServiceTest::test_ports_overrides_1 PASSED [ 86%]
tests/test_webserver.py::WebserverServiceTest::test_ports_overrides_2 PASSED [ 87%]
tests/test_webserver.py::WebserverServiceTest::test_ports_overrides_3 PASSED [ 87%]
tests/test_webserver.py::WebserverConfigmapTest::test_no_webserver_config_configmap_by_default PASSED [ 87%]
tests/test_webserver.py::WebserverConfigmapTest::test_webserver_config_configmap PASSED [ 87%]
tests/test_webserver.py::WebserverNetworkPolicyTest::test_defaults PASSED [ 88%]
tests/test_webserver.py::WebserverNetworkPolicyTest::test_deprecated_from_param PASSED [ 88%]
tests/test_webserver.py::WebserverNetworkPolicyTest::test_off_by_default PASSED [ 88%]
tests/test_webserver.py::WebserverNetworkPolicyTest::test_ports_overrides_0 PASSED [ 88%]
tests/test_webserver.py::WebserverNetworkPolicyTest::test_ports_overrides_1 PASSED [ 89%]
tests/test_webserver.py::WebserverNetworkPolicyTest::test_ports_overrides_2 PASSED [ 89%]
tests/test_worker.py::WorkerTest::test_airflow_local_settings PASSED [ 89%]
tests/test_worker.py::WorkerTest::test_airflow_local_settings_kerberos_sidecar PASSED [ 89%]
tests/test_worker.py::WorkerTest::test_command_and_args_overrides_0 PASSED [ 90%]
tests/test_worker.py::WorkerTest::test_command_and_args_overrides_1 PASSED [ 90%]
tests/test_worker.py::WorkerTest::test_command_and_args_overrides_2 PASSED [ 90%]
tests/test_worker.py::WorkerTest::test_command_and_args_overrides_3 PASSED [ 90%]
tests/test_worker.py::WorkerTest::test_command_and_args_overrides_are_templated PASSED [ 91%]
tests/test_worker.py::WorkerTest::test_dags_gitsync_sidecar_and_init_container PASSED [ 91%]
tests/test_worker.py::WorkerTest::test_dags_gitsync_with_persistence_no_sidecar_or_init_container PASSED [ 91%]
tests/test_worker.py::WorkerTest::test_default_command_and_args_airflow_version_0_1_9_0 PASSED [ 91%]
tests/test_worker.py::WorkerTest::test_default_command_and_args_airflow_version_1_1_10_14 PASSED [ 92%]
tests/test_worker.py::WorkerTest::test_default_command_and_args_airflow_version_2_2_0_2 PASSED [ 92%]
tests/test_worker.py::WorkerTest::test_default_command_and_args_airflow_version_3_2_1_0 PASSED [ 92%]
tests/test_worker.py::WorkerTest::test_log_groomer_command_and_args_overrides_0 PASSED [ 92%]
tests/test_worker.py::WorkerTest::test_log_groomer_command_and_args_overrides_1 PASSED [ 93%]
tests/test_worker.py::WorkerTest::test_log_groomer_command_and_args_overrides_2 PASSED [ 93%]
tests/test_worker.py::WorkerTest::test_log_groomer_command_and_args_overrides_3 PASSED [ 93%]
tests/test_worker.py::WorkerTest::test_log_groomer_command_and_args_overrides_are_templated PASSED [ 93%]
tests/test_worker.py::WorkerTest::test_log_groomer_default_command_and_args PASSED [ 94%]
tests/test_worker.py::WorkerTest::test_log_groomer_resources PASSED [ 94%]
tests/test_worker.py::WorkerTest::test_logs_persistence_changes_volume_0 PASSED [ 94%]
tests/test_worker.py::WorkerTest::test_logs_persistence_changes_volume_1 PASSED [ 94%]
tests/test_worker.py::WorkerTest::test_logs_persistence_changes_volume_2 PASSED [ 95%]
tests/test_worker.py::WorkerTest::test_no_airflow_local_settings_by_default PASSED [ 95%]
tests/test_worker.py::WorkerTest::test_should_add_extra_containers PASSED [ 95%]
tests/test_worker.py::WorkerTest::test_should_add_extra_init_containers PASSED [ 95%]
tests/test_worker.py::WorkerTest::test_should_add_extra_volume_and_extra_volume_mount PASSED [ 96%]
tests/test_worker.py::WorkerTest::test_should_create_default_affinity PASSED [ 96%]
tests/test_worker.py::WorkerTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 96%]
tests/test_worker.py::WorkerTest::test_should_create_valid_affinity_tolerations_and_node_selector_override PASSED [ 96%]
tests/test_worker.py::WorkerTest::test_worker_kind_0_CeleryExecutor PASSED [ 97%]
tests/test_worker.py::WorkerTest::test_worker_kind_1_CeleryExecutor PASSED [ 97%]
tests/test_worker.py::WorkerTest::test_worker_kind_2_CeleryKubernetesExecutor PASSED [ 97%]
tests/test_worker.py::WorkerTest::test_worker_kind_3_CeleryKubernetesExecutor PASSED [ 97%]
tests/test_worker.py::WorkerTest::test_worker_resources_are_configurable PASSED [ 98%]
tests/test_worker.py::WorkerTest::test_worker_resources_are_not_added_by_default PASSED [ 98%]
tests/test_worker.py::WorkerTest::test_workers_host_aliases PASSED [ 98%]
tests/test_worker.py::WorkerTest::test_workers_strategy_0 PASSED [ 98%]
tests/test_worker.py::WorkerTest::test_workers_strategy_1 PASSED [ 99%]
tests/test_worker.py::WorkerTest::test_workers_strategy_2 PASSED [ 99%]
tests/test_worker.py::WorkerTest::test_workers_update_strategy_0 PASSED [ 99%]
tests/test_worker.py::WorkerTest::test_workers_update_strategy_1 PASSED [ 99%]
tests/test_worker.py::WorkerTest::test_workers_update_strategy_2 PASSED [100%]
======================= 400 passed in 1535.73s (0:25:35) =======================
```
This is the result of you mentioned in example: `test_metadata_connection_secret.py`
As I already mentioned, I don't know how to add test coverage for this in fancy style, so sorry for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894733668
OK. I misunderstood badly. I will commit new test function as soon as i finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-898724877
@Sonins, congrats on your first commit! Thanks for the fix πΊ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on a change in pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on a change in pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#discussion_r685708706
##########
File path: chart/tests/test_elasticsearch_secret.py
##########
@@ -96,3 +96,24 @@ def test_should_correctly_handle_password_with_special_characters(self):
"http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
"elastichostname:80" == connection
)
+
+ def test_should_generate_secret_with_specified_port(self):
+ connection = self._get_connection(
+ {
+ "elasticsearch": {
+ "enabled": True,
+ "connection": {
+ "user": "username!@#$%%^&*()",
+ "pass": "password!@#$%%^&*()",
+ "host": "elastichostname",
+ "port": 9200,
+ },
+ }
+ }
+ )
+
+ assert (
+ "http://username%21%40%23$%25%25%5E&%2A%28%29:password%21%40%23$%25%25%5E&%2A%28%29@"
+ "elastichostname:9200" == connection
+ )
Review comment:
OK, It turns out there is a little problem.
Without user and pass field, `<no+value>` is included in url string, like this.
`http://<no+value>:<no+value>@elastichostname:2222`
It makes test fail.
My mistake, I should've tested for this before i committed it, sorry.
For now I can think 2 options.
1. Insert simple username and pass into test function.
2. Fix something that makes user and pass in url string <no+value>, use username something like 'root', instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Posted by GitBox <gi...@apache.org>.
Sonins commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-896394743
I added simple username and password.
Here's test result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org